tests/provider: Update hardcoded AZs (DB instance) #14778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
size/XL
YakDriver
force-pushed
the
t-hardaz-db-instance
branch
5 times, most recently
from
ae5adf1 to
b48d7d7
Compare
ghost
added
the
service/opsworks
YakDriver
force-pushed
the
t-hardaz-db-instance
branch
2 times, most recently
from
deba2b9 to
3b5d2b3
Compare
YakDriver
force-pushed
the
t-hardaz-db-instance
branch
from
3b5d2b3 to
c8cb4a6
Compare
ghost
added
size/XXL
YakDriver
force-pushed
the
t-hardaz-db-instance
branch
2 times, most recently
from
03efbfc to
649c366
Compare
|
Since the last tctest run, these tests should be fixed. These tests are not fixed on GovCloud and have unrelated issues: |
|
|
|
That test is part of the failures noted in #14384 and will be addressed as part of this quarter's tech debt theme. |
|
One issue to note is that RDS requires the latest minor version for the s3 import but, for mysql, on commericial that's 5.6.44 and on GovCloud that's 5.6.41. |
|
Can you remove the specification for the engine version? |
|
Oh I guess it would pick some (likely random) version in that case. Maybe a simple workaround of the below? Would require a more complicated lookup if the support varies across other partitions 🙁 |
|
I'll try it out. But getting past the version issue just leads to another problem (at least on GovCloud): |
|
We could also consider a |
|
👍 Cool yeah, #13391 is now the issue for tracking that if you feel super inclined to deal with the special backup file and potentially AWS Support. |
This was referenced Sep 2, 2020
YakDriver
force-pushed
the
t-hardaz-db-instance
branch
from
649c366 to
7a0cca7
Compare
YakDriver
force-pushed
the
t-hardaz-db-instance
branch
from
7a0cca7 to
51cffd6
Compare
|
Performance insights aren't supported on GovCloud so I need to add a pre check. #15022 has a pre check that this resource can also use. I'll wait on that to merge before finishing this. |
YakDriver
force-pushed
the
t-hardaz-db-instance
branch
4 times, most recently
from
bb768e4 to
80f0a2e
Compare
This was referenced Sep 17, 2020
|
This PR was waiting on #15022 (merged). |
|
This was waiting on #15228 (merged). |
YakDriver
force-pushed
the
t-hardaz-db-instance
branch
2 times, most recently
from
f05d047 to
2318ec7
Compare
YakDriver
force-pushed
the
t-hardaz-db-instance
branch
3 times, most recently
from
9431aa2 to
063d3a8
Compare
YakDriver
force-pushed
the
t-hardaz-db-instance
branch
from
063d3a8 to
b6dd0c9
Compare
bflad
approved these changes
Sep 30, 2020
There was a problem hiding this comment.
🚀
Output from acceptance testing in AWS Commercial (test failures being tracked elsewhere):
--- FAIL: TestAccAWSDBInstance_DbSubnetGroupName_RamShared (2.33s)
--- FAIL: TestAccAWSDBInstance_ReplicateSourceDb_BackupRetentionPeriod (1343.08s)
--- FAIL: TestAccAWSDBInstance_ReplicateSourceDb_DbSubnetGroupName_RamShared (0.95s)
--- FAIL: TestAccAWSDBInstance_S3Import (682.03s)
--- FAIL: TestAccAWSDBInstance_SnapshotIdentifier_DbSubnetGroupName_RamShared (1.08s)
--- PASS: TestAccAWSDBInstance_AllowMajorVersionUpgrade (536.94s)
--- PASS: TestAccAWSDBInstance_basic (467.01s)
--- PASS: TestAccAWSDBInstance_CACertificateIdentifier (428.20s)
--- PASS: TestAccAWSDBInstance_cloudwatchLogsExportConfiguration (522.85s)
--- PASS: TestAccAWSDBInstance_cloudwatchLogsExportConfigurationUpdate (777.66s)
--- PASS: TestAccAWSDBInstance_DbSubnetGroupName (401.44s)
--- PASS: TestAccAWSDBInstance_DbSubnetGroupName_VpcSecurityGroupIds (530.41s)
--- PASS: TestAccAWSDBInstance_DeletionProtection (389.53s)
--- PASS: TestAccAWSDBInstance_EnabledCloudwatchLogsExports_MSSQL (758.11s)
--- PASS: TestAccAWSDBInstance_EnabledCloudwatchLogsExports_Oracle (813.75s)
--- PASS: TestAccAWSDBInstance_EnabledCloudwatchLogsExports_Postgresql (550.69s)
--- PASS: TestAccAWSDBInstance_FinalSnapshotIdentifier (737.80s)
--- PASS: TestAccAWSDBInstance_FinalSnapshotIdentifier_SkipFinalSnapshot (786.45s)
--- PASS: TestAccAWSDBInstance_generatedName (530.22s)
--- PASS: TestAccAWSDBInstance_iamAuth (534.67s)
--- PASS: TestAccAWSDBInstance_IsAlreadyBeingDeleted (369.48s)
--- PASS: TestAccAWSDBInstance_kmsKey (515.03s)
--- PASS: TestAccAWSDBInstance_MaxAllocatedStorage (697.89s)
--- PASS: TestAccAWSDBInstance_MinorVersion (458.03s)
--- PASS: TestAccAWSDBInstance_MonitoringInterval (1072.86s)
--- PASS: TestAccAWSDBInstance_MonitoringRoleArn_EnabledToDisabled (736.29s)
--- PASS: TestAccAWSDBInstance_MonitoringRoleArn_EnabledToRemoved (685.29s)
--- PASS: TestAccAWSDBInstance_MonitoringRoleArn_RemovedToEnabled (440.76s)
--- PASS: TestAccAWSDBInstance_MSSQL_Domain (3674.59s)
--- PASS: TestAccAWSDBInstance_MSSQL_DomainSnapshotRestore (3710.44s)
--- PASS: TestAccAWSDBInstance_MSSQL_TZ (1666.26s)
--- PASS: TestAccAWSDBInstance_MySQL_SnapshotRestoreWithEngineVersion (2072.50s)
--- PASS: TestAccAWSDBInstance_namePrefix (510.86s)
--- PASS: TestAccAWSDBInstance_NoDeleteAutomatedBackups (801.78s)
--- PASS: TestAccAWSDBInstance_optionGroup (495.88s)
--- PASS: TestAccAWSDBInstance_Password (449.57s)
--- PASS: TestAccAWSDBInstance_PerformanceInsightsEnabled_DisabledToEnabled (764.33s)
--- PASS: TestAccAWSDBInstance_PerformanceInsightsEnabled_EnabledToDisabled (856.05s)
--- PASS: TestAccAWSDBInstance_PerformanceInsightsKmsKeyId (1081.61s)
--- PASS: TestAccAWSDBInstance_PerformanceInsightsRetentionPeriod (997.28s)
--- PASS: TestAccAWSDBInstance_portUpdate (528.42s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb (1333.69s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_AllocatedStorage (1524.08s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_AllowMajorVersionUpgrade (1474.29s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_AutoMinorVersionUpgrade (1411.78s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_AvailabilityZone (1298.79s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_BackupWindow (1287.28s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_CACertificateIdentifier (1267.96s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_DbSubnetGroupName (2373.24s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_DbSubnetGroupName_VpcSecurityGroupIds (2250.34s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_IamDatabaseAuthenticationEnabled (1429.01s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_MaintenanceWindow (1166.06s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_MaxAllocatedStorage (1540.00s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_Monitoring (1561.64s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_MultiAZ (1893.17s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_ParameterGroupName (1580.56s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_PerformanceInsightsEnabled (1792.83s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_Port (1317.92s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_VpcSecurityGroupIds (1399.70s)
--- PASS: TestAccAWSDBInstance_separateIopsUpdate (892.38s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier (1065.64s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_AllocatedStorage (1336.27s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_AllowMajorVersionUpgrade (2034.64s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_AutoMinorVersionUpgrade (1135.07s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_AvailabilityZone (1124.14s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_BackupRetentionPeriod (1479.42s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_BackupRetentionPeriod_Unset (1356.38s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_BackupWindow (1235.87s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_DbSubnetGroupName (1145.18s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_DbSubnetGroupName_VpcSecurityGroupIds (1135.27s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_DeletionProtection (1247.93s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_IamDatabaseAuthenticationEnabled (973.22s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_Io1Storage (1609.23s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_MaintenanceWindow (1023.83s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_MaxAllocatedStorage (1205.47s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_Monitoring (1478.25s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_MultiAZ (2054.68s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_MultiAZ_SQLServer (3841.89s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_ParameterGroupName (1315.93s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_PerformanceInsightsEnabled (1489.33s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_Port (963.86s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_Tags (1205.64s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_VpcSecurityGroupIds (1285.83s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_VpcSecurityGroupIds_Tags (1130.23s)
--- PASS: TestAccAWSDBInstance_subnetGroup (834.37s)
--- PASS: TestAccAWSOpsworksRdsDbInstance_basic (882.56s)
--- SKIP: TestAccAWSDBInstance_ec2Classic (1.14s)
--- SKIP: TestAccAWSDBInstance_ReplicateSourceDb_DeletionProtection (0.00s)
--- SKIP: TestAccAWSDBInstance_SnapshotIdentifier_Tags_Unset (0.00s)
Output from acceptance testing in AWS GovCloud (US) (test failures being tracked elsewhere):
--- FAIL: TestAccAWSDBInstance_CACertificateIdentifier (437.51s)
--- FAIL: TestAccAWSDBInstance_DbSubnetGroupName_RamShared (2.11s)
--- FAIL: TestAccAWSDBInstance_ec2Classic (0.37s)
--- FAIL: TestAccAWSDBInstance_MSSQL_Domain (2580.84s)
--- FAIL: TestAccAWSDBInstance_MSSQL_DomainSnapshotRestore (2879.60s)
--- FAIL: TestAccAWSDBInstance_ReplicateSourceDb_CACertificateIdentifier (619.90s)
--- FAIL: TestAccAWSDBInstance_ReplicateSourceDb_DbSubnetGroupName (9.90s)
--- FAIL: TestAccAWSDBInstance_ReplicateSourceDb_DbSubnetGroupName_RamShared (0.35s)
--- FAIL: TestAccAWSDBInstance_ReplicateSourceDb_DbSubnetGroupName_VpcSecurityGroupIds (9.64s)
--- FAIL: TestAccAWSDBInstance_S3Import (670.25s)
--- FAIL: TestAccAWSDBInstance_SnapshotIdentifier_DbSubnetGroupName_RamShared (0.47s)
--- FAIL: TestAccAWSOpsworksRdsDbInstance_basic (417.92s)
--- PASS: TestAccAWSDBInstance_AllowMajorVersionUpgrade (311.46s)
--- PASS: TestAccAWSDBInstance_basic (454.97s)
--- PASS: TestAccAWSDBInstance_cloudwatchLogsExportConfiguration (505.91s)
--- PASS: TestAccAWSDBInstance_cloudwatchLogsExportConfigurationUpdate (759.30s)
--- PASS: TestAccAWSDBInstance_DbSubnetGroupName (476.84s)
--- PASS: TestAccAWSDBInstance_DbSubnetGroupName_VpcSecurityGroupIds (558.55s)
--- PASS: TestAccAWSDBInstance_DeletionProtection (612.27s)
--- PASS: TestAccAWSDBInstance_EnabledCloudwatchLogsExports_MSSQL (726.20s)
--- PASS: TestAccAWSDBInstance_EnabledCloudwatchLogsExports_Oracle (897.23s)
--- PASS: TestAccAWSDBInstance_EnabledCloudwatchLogsExports_Postgresql (343.35s)
--- PASS: TestAccAWSDBInstance_FinalSnapshotIdentifier (856.53s)
--- PASS: TestAccAWSDBInstance_FinalSnapshotIdentifier_SkipFinalSnapshot (635.91s)
--- PASS: TestAccAWSDBInstance_generatedName (533.60s)
--- PASS: TestAccAWSDBInstance_iamAuth (514.40s)
--- PASS: TestAccAWSDBInstance_IsAlreadyBeingDeleted (409.62s)
--- PASS: TestAccAWSDBInstance_kmsKey (466.67s)
--- PASS: TestAccAWSDBInstance_MaxAllocatedStorage (591.89s)
--- PASS: TestAccAWSDBInstance_MinorVersion (481.90s)
--- PASS: TestAccAWSDBInstance_MonitoringInterval (1119.55s)
--- PASS: TestAccAWSDBInstance_MonitoringRoleArn_EnabledToDisabled (816.62s)
--- PASS: TestAccAWSDBInstance_MonitoringRoleArn_EnabledToRemoved (804.73s)
--- PASS: TestAccAWSDBInstance_MonitoringRoleArn_RemovedToEnabled (690.38s)
--- PASS: TestAccAWSDBInstance_MSSQL_TZ (1724.16s)
--- PASS: TestAccAWSDBInstance_MySQL_SnapshotRestoreWithEngineVersion (1756.31s)
--- PASS: TestAccAWSDBInstance_namePrefix (464.88s)
--- PASS: TestAccAWSDBInstance_NoDeleteAutomatedBackups (572.47s)
--- PASS: TestAccAWSDBInstance_optionGroup (515.22s)
--- PASS: TestAccAWSDBInstance_Password (444.94s)
--- PASS: TestAccAWSDBInstance_portUpdate (508.89s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb (1422.57s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_AllocatedStorage (1654.63s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_AllowMajorVersionUpgrade (1251.41s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_AutoMinorVersionUpgrade (1563.31s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_AvailabilityZone (1311.17s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_BackupRetentionPeriod (1564.16s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_BackupWindow (1373.04s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_IamDatabaseAuthenticationEnabled (1523.89s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_MaintenanceWindow (1371.90s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_MaxAllocatedStorage (1463.30s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_Monitoring (1483.21s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_MultiAZ (2230.38s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_ParameterGroupName (1322.48s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_Port (1383.18s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_VpcSecurityGroupIds (1372.90s)
--- PASS: TestAccAWSDBInstance_separateIopsUpdate (711.01s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier (1219.29s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_AllocatedStorage (1381.85s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_AllowMajorVersionUpgrade (1836.41s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_AutoMinorVersionUpgrade (1088.88s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_AvailabilityZone (1089.35s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_BackupRetentionPeriod (1392.22s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_BackupRetentionPeriod_Unset (1502.34s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_BackupWindow (1118.30s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_DbSubnetGroupName (958.52s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_DbSubnetGroupName_VpcSecurityGroupIds (1098.60s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_DeletionProtection (1307.04s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_IamDatabaseAuthenticationEnabled (1098.70s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_Io1Storage (1502.29s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_MaintenanceWindow (1239.09s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_MaxAllocatedStorage (1160.11s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_Monitoring (1200.44s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_MultiAZ (1805.21s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_MultiAZ_SQLServer (3818.32s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_ParameterGroupName (1200.87s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_Port (1138.95s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_Tags (1219.38s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_VpcSecurityGroupIds (1088.40s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_VpcSecurityGroupIds_Tags (1059.13s)
--- PASS: TestAccAWSDBInstance_subnetGroup (960.33s)
--- SKIP: TestAccAWSDBInstance_PerformanceInsightsEnabled_DisabledToEnabled (0.27s)
--- SKIP: TestAccAWSDBInstance_PerformanceInsightsEnabled_EnabledToDisabled (0.31s)
--- SKIP: TestAccAWSDBInstance_PerformanceInsightsKmsKeyId (0.27s)
--- SKIP: TestAccAWSDBInstance_PerformanceInsightsRetentionPeriod (0.28s)
--- SKIP: TestAccAWSDBInstance_ReplicateSourceDb_DeletionProtection (0.00s)
--- SKIP: TestAccAWSDBInstance_ReplicateSourceDb_PerformanceInsightsEnabled (0.29s)
--- SKIP: TestAccAWSDBInstance_SnapshotIdentifier_PerformanceInsightsEnabled (0.27s)
--- SKIP: TestAccAWSDBInstance_SnapshotIdentifier_Tags_Unset (0.00s)
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Note
Relates #12995
Depends on #15228
Release note for CHANGELOG:
Output from acceptance testing (GovCloud partition):
Output from acceptance testing (commercial/standard partition):