d/aws_rds_orderable_db_instance: Make more useful

[YakDriver]

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
• If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Without being able to narrow down instance classes by performance insights and encryption compatibility, it requires trial and error to find a valid parameter combination (or using the CLI). When you get wrong, you see this error.

InvalidParameterCombination: Performance Insights not supported for this configuration, please disable this
feature.

I propose:

1. Convert supports_storage_encryption and supports_performance_insights to arguments and narrow down results in TF
2. Add a major_engine_version argument, similar to aws_db_option_group , for similarity/consistency with it. Sort the minor versions to get the latest (split numeric and alpha, sort on both).
3. Change the db_instance_class argument to instance_class to be less verbose and consistent with aws_db_instance
4. Change the preferred_db_instance_class argument to preferred_instance_class to be less verbose and consistent with 3.

New or Affected Resource(s)

• aws_rds_orderable_db_instance

Potential Terraform Configuration

data "aws_rds_orderable_db_instance" "test" {
  engine         = "mysql"
  major_engine_version = "5.6"
  license_model  = "general-public-license"
  storage_type   = "standard"
  
  supports_storage_encryption = true
  supports_performance_insights = true

  preferred_instance_classes = ["db.t3.small", "db.t2.small", "db.t2.medium"]
}

References

• tests/provider: Update hardcoded AZs (DB instance) #14778

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!