Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

d/rds_engine_version: New data source #15228

Merged
merged 1 commit into from
Sep 23, 2020
Merged

d/rds_engine_version: New data source #15228

merged 1 commit into from
Sep 23, 2020

Conversation

YakDriver
Copy link
Member

@YakDriver YakDriver commented Sep 18, 2020 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #15224
Relates #15253, #15259

Release note for CHANGELOG:

d/rds_engine_version: New data source

The output from acceptance testing (GovCloud):

--- PASS: TestAccAWSRDSEngineVersionDataSource_defaultOnly (16.47s)
--- PASS: TestAccAWSRDSEngineVersionDataSource_basic (16.47s)
--- PASS: TestAccAWSRDSEngineVersionDataSource_preferred (16.65s)

The output from acceptance testing (commercial):

--- PASS: TestAccAWSRDSEngineVersionDataSource_defaultOnly (11.33s)
--- PASS: TestAccAWSRDSEngineVersionDataSource_basic (11.34s)
--- PASS: TestAccAWSRDSEngineVersionDataSource_preferred (11.71s)

@YakDriver YakDriver requested a review from a team September 18, 2020 21:59
@ghost ghost added size/XL Managed by automation to categorize the size of a PR. provider Pertains to the provider itself, rather than any interaction with AWS. service/rds Issues and PRs that pertain to the rds service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Sep 18, 2020
@YakDriver YakDriver added the partition/aws-us-gov Pertains to the aws-us-gov partition. label Sep 18, 2020
@YakDriver YakDriver force-pushed the f-gov-engine-versions branch from b545f2e to b94c066 Compare September 18, 2020 22:34
@ghost ghost added the documentation Introduces or discusses updates to documentation. label Sep 18, 2020
@YakDriver YakDriver force-pushed the f-gov-engine-versions branch 4 times, most recently from 385939f to e129e99 Compare September 21, 2020 15:15
This was referenced Sep 21, 2020
Merged
Merged
@YakDriver YakDriver force-pushed the f-gov-engine-versions branch from e129e99 to 1fc8a0f Compare September 21, 2020 21:16
@YakDriver YakDriver mentioned this pull request Sep 21, 2020
Merged
@YakDriver YakDriver force-pushed the f-gov-engine-versions branch from 1fc8a0f to 5bca932 Compare September 21, 2020 23:17
@YakDriver YakDriver mentioned this pull request Sep 22, 2020
Merged
@bflad bflad self-assigned this Sep 23, 2020
@bflad bflad added the new-data-source Introduces a new data source. label Sep 23, 2020
bflad
bflad approved these changes Sep 23, 2020
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good to me, just suggestions around family versus name and other small documentation fixes. 🚀

Output from acceptance testing:

--- PASS: TestAccAWSRDSEngineVersionDataSource_defaultOnly (14.38s)
--- PASS: TestAccAWSRDSEngineVersionDataSource_upgradeTargets (15.19s)
--- PASS: TestAccAWSRDSEngineVersionDataSource_basic (15.51s)
--- PASS: TestAccAWSRDSEngineVersionDataSource_preferred (16.05s)

aws/data_source_aws_rds_engine_version.go Outdated Show resolved Hide resolved
aws/data_source_aws_rds_engine_version.go Outdated Show resolved Hide resolved
aws/data_source_aws_rds_engine_version.go Outdated Show resolved Hide resolved
aws/data_source_aws_rds_engine_version_test.go Outdated Show resolved Hide resolved
website/docs/d/rds_engine_version.markdown Outdated Show resolved Hide resolved
website/docs/d/rds_engine_version.markdown Outdated Show resolved Hide resolved
website/docs/d/rds_engine_version.markdown Outdated Show resolved Hide resolved
@YakDriver YakDriver force-pushed the f-gov-engine-versions branch 2 times, most recently from a13fbd6 to 39dea60 Compare September 23, 2020 19:09
@YakDriver YakDriver force-pushed the f-gov-engine-versions branch from 39dea60 to 485e470 Compare September 23, 2020 19:12
@YakDriver YakDriver added this to the v3.8.0 milestone Sep 23, 2020
@YakDriver YakDriver merged commit 2a4cddd into master Sep 23, 2020
@YakDriver YakDriver deleted the f-gov-engine-versions branch September 23, 2020 19:34
@ghost
Copy link

ghost commented Sep 24, 2020

This has been released in version 3.8.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@bflad bflad mentioned this pull request Sep 30, 2020
Closed
@ghost
Copy link

ghost commented Oct 24, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Oct 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees

@bflad bflad

Labels
documentation Introduces or discusses updates to documentation. new-data-source Introduces a new data source. partition/aws-us-gov Pertains to the aws-us-gov partition. provider Pertains to the provider itself, rather than any interaction with AWS. service/rds Issues and PRs that pertain to the rds service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.8.0
Development

Successfully merging this pull request may close these issues.

d/rds_engine_version: New data source
2 participants
@YakDriver @bflad