Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: AWS Shield Advanced: DRT AccessRole ARN and Access Log Bucket Associations #33328

Merged
merged 16 commits into from
Sep 6, 2023

Conversation

chasse-code
Copy link

Description

Add support for Shield DRT Access

  • Support adding DRT Access Role Arn Association
  • Support adding SRT Access Log Bucket Association

Relations

Closes #32626

Output from Acceptance Testing

make testacc  PKG=shield  TESTS=TestAccShieldDRTAccess
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/shield/... -v -count 1 -parallel 20 -run='TestAccShieldDRTAccess'  -timeout 180m
=== RUN   TestAccShieldDRTAccessLogBucketAssociation_basic
--- PASS: TestAccShieldDRTAccessLogBucketAssociation_basic (14.07s)
=== RUN   TestAccShieldDRTAccessLogBucketAssociation_multibucket
--- PASS: TestAccShieldDRTAccessLogBucketAssociation_multibucket (14.43s)
=== RUN   TestAccShieldDRTAccessLogBucketAssociation_disappears
--- PASS: TestAccShieldDRTAccessLogBucketAssociation_disappears (14.08s)
=== RUN   TestAccShieldDRTAccessRoleArnAssociation_basic
--- PASS: TestAccShieldDRTAccessRoleArnAssociation_basic (12.37s)
=== RUN   TestAccShieldDRTAccessRoleArnAssociation_disappears
--- PASS: TestAccShieldDRTAccessRoleArnAssociation_disappears (13.10s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/shield     71.329s

@github-actions
Copy link

github-actions bot commented Sep 6, 2023

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/shield Issues and PRs that pertain to the shield service. generators Relates to code generators. size/XL Managed by automation to categorize the size of a PR. and removed documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/shield Issues and PRs that pertain to the shield service. generators Relates to code generators. labels Sep 6, 2023
@terraform-aws-provider terraform-aws-provider bot added needs-triage Waiting for first response or review from a maintainer. partner Contribution from a partner. labels Sep 6, 2023
@ewbankkit ewbankkit added new-resource Introduces a new resource. service/shield Issues and PRs that pertain to the shield service. and removed needs-triage Waiting for first response or review from a maintainer. labels Sep 6, 2023
@chasse-code chasse-code changed the title F shield advanced Feature: AWS Shield Advanced: DRT AccessRole ARN and Access Log Bucket Associations Sep 6, 2023
@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. generators Relates to code generators. labels Sep 6, 2023
… a valid DRT managed policy attached' errors.
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccShieldDRTAccessLogBucketAssociation_' PKG=shield
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/shield/... -v -count 1 -parallel 20  -run=TestAccShieldDRTAccessLogBucketAssociation_ -timeout 180m
=== RUN   TestAccShieldDRTAccessLogBucketAssociation_basic
--- PASS: TestAccShieldDRTAccessLogBucketAssociation_basic (26.00s)
=== RUN   TestAccShieldDRTAccessLogBucketAssociation_multibucket
--- PASS: TestAccShieldDRTAccessLogBucketAssociation_multibucket (27.42s)
=== RUN   TestAccShieldDRTAccessLogBucketAssociation_disappears
--- PASS: TestAccShieldDRTAccessLogBucketAssociation_disappears (26.76s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/shield	85.920s
% make testacc TESTARGS='-run=TestAccShieldDRTAccessRoleARNAssociation_' PKG=shield
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/shield/... -v -count 1 -parallel 20  -run=TestAccShieldDRTAccessRoleARNAssociation_ -timeout 180m
=== RUN   TestAccShieldDRTAccessRoleARNAssociation_basic
--- PASS: TestAccShieldDRTAccessRoleARNAssociation_basic (33.17s)
=== RUN   TestAccShieldDRTAccessRoleARNAssociation_disappears
--- PASS: TestAccShieldDRTAccessRoleARNAssociation_disappears (20.86s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/shield	66.069s

@ewbankkit
Copy link
Contributor

@chasse-code Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit c6cea19 into hashicorp:main Sep 6, 2023
41 checks passed
@github-actions github-actions bot added this to the v5.16.0 milestone Sep 6, 2023
@github-actions
Copy link

github-actions bot commented Sep 8, 2023

This functionality has been released in v5.16.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Oct 8, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. new-resource Introduces a new resource. partner Contribution from a partner. service/shield Issues and PRs that pertain to the shield service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: Shield Advanced Full Support
3 participants