-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: AWS Shield Advanced: DRT AccessRole ARN and Access Log Bucket Associations #33328
Conversation
Community NoteVoting for Prioritization
For Submitters
|
… Headings should be surrounded by blank lines [Expected: 1; Actual: 0; Below]'.
…ws_partition data source'.
… a valid DRT managed policy attached' errors.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccShieldDRTAccessLogBucketAssociation_' PKG=shield
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/shield/... -v -count 1 -parallel 20 -run=TestAccShieldDRTAccessLogBucketAssociation_ -timeout 180m
=== RUN TestAccShieldDRTAccessLogBucketAssociation_basic
--- PASS: TestAccShieldDRTAccessLogBucketAssociation_basic (26.00s)
=== RUN TestAccShieldDRTAccessLogBucketAssociation_multibucket
--- PASS: TestAccShieldDRTAccessLogBucketAssociation_multibucket (27.42s)
=== RUN TestAccShieldDRTAccessLogBucketAssociation_disappears
--- PASS: TestAccShieldDRTAccessLogBucketAssociation_disappears (26.76s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/shield 85.920s
% make testacc TESTARGS='-run=TestAccShieldDRTAccessRoleARNAssociation_' PKG=shield
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/shield/... -v -count 1 -parallel 20 -run=TestAccShieldDRTAccessRoleARNAssociation_ -timeout 180m
=== RUN TestAccShieldDRTAccessRoleARNAssociation_basic
--- PASS: TestAccShieldDRTAccessRoleARNAssociation_basic (33.17s)
=== RUN TestAccShieldDRTAccessRoleARNAssociation_disappears
--- PASS: TestAccShieldDRTAccessRoleARNAssociation_disappears (20.86s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/shield 66.069s
@chasse-code Thanks for the contribution 🎉 👏. |
This functionality has been released in v5.16.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
Add support for Shield DRT Access
Relations
Closes #32626
Output from Acceptance Testing