Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: aws shield advanced #32889

Closed
wants to merge 6 commits into from

Conversation

chasse-code
Copy link

Description

Add support for Shield DRT Access

  • Support adding DRT Access Role Arn Association
  • Support adding SRT Access Log Bucket Association

Relations

Closes #32626

Output from Acceptance Testing

make testacc  PKG=shield  TESTS=TestAccShieldDRTAccess
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/shield/... -v -count 1 -parallel 20 -run='TestAccShieldDRTAccess'  -timeout 180m
=== RUN   TestAccShieldDRTAccessLogBucketAssociation_basic
--- PASS: TestAccShieldDRTAccessLogBucketAssociation_basic (14.07s)
=== RUN   TestAccShieldDRTAccessLogBucketAssociation_multibucket
--- PASS: TestAccShieldDRTAccessLogBucketAssociation_multibucket (14.43s)
=== RUN   TestAccShieldDRTAccessLogBucketAssociation_disappears
--- PASS: TestAccShieldDRTAccessLogBucketAssociation_disappears (14.08s)
=== RUN   TestAccShieldDRTAccessRoleArnAssociation_basic
--- PASS: TestAccShieldDRTAccessRoleArnAssociation_basic (12.37s)
=== RUN   TestAccShieldDRTAccessRoleArnAssociation_disappears
--- PASS: TestAccShieldDRTAccessRoleArnAssociation_disappears (13.10s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/shield     71.329s

@github-actions
Copy link

github-actions bot commented Aug 7, 2023

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/shield Issues and PRs that pertain to the shield service. generators Relates to code generators. size/XL Managed by automation to categorize the size of a PR. labels Aug 7, 2023
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Aug 7, 2023
@github-actions
Copy link

github-actions bot commented Aug 7, 2023

Thank you for your contribution! 🚀

Please note that typically Go dependency changes are handled in this repository by dependabot or the maintainers. This is to prevent pull request merge conflicts and further delay reviews of contributions. Remove any changes to the go.mod or go.sum files and commit them into this pull request.

Additional details:

  • Check open pull requests with the dependencies label to view other dependency updates.
  • If this pull request includes an update the AWS Go SDK (or any other dependency) version, only updates submitted via dependabot will be merged. This pull request will need to remove these changes and will need to be rebased after the existing dependency update via dependabot has been merged for this pull request to be reviewed.
  • If this pull request is for supporting a new AWS service:
    • Ensure the new AWS service changes are following the Contributing Guide section on new services, in particular that the dependency addition and initial provider support are in a separate pull request from other changes (e.g. new resources). Contributions not following this item will not be reviewed until the changes are split.
    • If this pull request is already a separate pull request from the above item, you can ignore this message.

@justinretzolk justinretzolk added new-resource Introduces a new resource. and removed needs-triage Waiting for first response or review from a maintainer. labels Aug 7, 2023
@AdamTylerLynch AdamTylerLynch added the partner Contribution from a partner. label Aug 11, 2023
@chasse-code chasse-code closed this Sep 6, 2023
@chasse-code
Copy link
Author

Due to the accidental files encroaching on this PR i've created a new one that is clean
#33328

@github-actions
Copy link

github-actions bot commented Oct 7, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. new-resource Introduces a new resource. partner Contribution from a partner. service/shield Issues and PRs that pertain to the shield service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: Shield Advanced Full Support
4 participants