Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: Shield Advanced Full Support #32626

Closed
chasse-code opened this issue Jul 20, 2023 · 3 comments · Fixed by #33328
Closed

[Enhancement]: Shield Advanced Full Support #32626

chasse-code opened this issue Jul 20, 2023 · 3 comments · Fixed by #33328
Labels
enhancement Requests to existing resources that expand the functionality or scope. new-resource Introduces a new resource. service/shield Issues and PRs that pertain to the shield service.
Milestone

Comments

@chasse-code
Copy link

Description

Determine what is missing from Shield resources in order to fully support Shield Advanced.

Affected Resource(s) and/or Data Source(s)

aws_shield_* - Existing resources
aws_shield_drt_role_association - New

Potential Terraform Configuration

data "aws_availability_zones" "available" {}
data "aws_region" "current" {}
data "aws_caller_identity" "current" {}

resource "aws_eip" "example" {
  domain = "vpc"
}

resource "aws_shield_protection" "example" {
  name         = "example"
  resource_arn = "arn:aws:ec2:${data.aws_region.current.name}:${data.aws_caller_identity.current.account_id}:eip-allocation/${aws_eip.example.id}"

  tags = {
    Environment = "Dev"
  }
}

References

https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-shield-proactiveengagement.html
https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-shield-drtaccess.html
#22848
#26873

Would you like to implement a fix?

Yes

@chasse-code chasse-code added enhancement Requests to existing resources that expand the functionality or scope. needs-triage Waiting for first response or review from a maintainer. labels Jul 20, 2023
@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@github-actions github-actions bot added service/ec2 Issues and PRs that pertain to the ec2 service. service/shield Issues and PRs that pertain to the shield service. service/sts Issues and PRs that pertain to the sts service. labels Jul 20, 2023
@justinretzolk justinretzolk added new-resource Introduces a new resource. and removed service/ec2 Issues and PRs that pertain to the ec2 service. service/sts Issues and PRs that pertain to the sts service. needs-triage Waiting for first response or review from a maintainer. labels Jul 24, 2023
@github-actions github-actions bot added this to the v5.16.0 milestone Sep 6, 2023
@github-actions
Copy link

github-actions bot commented Sep 8, 2023

This functionality has been released in v5.16.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Oct 8, 2023

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. new-resource Introduces a new resource. service/shield Issues and PRs that pertain to the shield service.
Projects
None yet
2 participants