Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS Shield Advance support #26511

Closed
z-mani opened this issue Aug 29, 2022 · 3 comments
Closed

AWS Shield Advance support #26511

z-mani opened this issue Aug 29, 2022 · 3 comments
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/shield Issues and PRs that pertain to the shield service.

Comments

@z-mani
Copy link

z-mani commented Aug 29, 2022

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Hi there,

I'm wanting to enable AWS Shield Advance and enable shield advance protection on a NLB resource. Is this possible through the current Terraform AWS options? I see there is a shield option (not advance) that allows us to add protection to a resource, but shield doesn't have support for NLBs, only shield advanced does.

The resource I'm trying to attach shield advance to is an NLB

There currently is support for aws_shield_protection. This doesn't seem to have the option for shield advance resources.

Potential Terraform Configuration

resource "aws_shield_advance_protection" "example" {
  name         = "example"
  resource_arn = "arn:aws:elasticloadbalancer:${data.aws_region.current.name}:${data.aws_caller_identity.current.account_id}:eip-allocation/${aws_eip.example.id}"

  tags = {
    Environment = "Dev"
  }
}

References

  • #0000
@z-mani z-mani added the enhancement Requests to existing resources that expand the functionality or scope. label Aug 29, 2022
@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. service/shield Issues and PRs that pertain to the shield service. labels Aug 29, 2022
@justinretzolk
Copy link
Member

Hey @z-mani 👋 Thank you for taking the time to raise this! I took a quick look, and based on the documentation, I believe the aws_shield_protection resource is actually what you're looking for. From the documentation page:

Enables AWS Shield Advanced for a specific AWS resource. The resource can be an Amazon CloudFront distribution, Elastic Load Balancing load balancer, AWS Global Accelerator accelerator, Elastic IP Address, or an Amazon Route 53 hosted zone.

This seems to line up with how Amazon describes Shield Advanced. If I've misunderstood, I'd be happy to take another look.

@justinretzolk justinretzolk added waiting-response Maintainers are waiting on response from community or contributor. and removed needs-triage Waiting for first response or review from a maintainer. labels Aug 30, 2022
@ewbankkit
Copy link
Contributor

Closed via #33328.

@terraform-aws-provider terraform-aws-provider bot removed the waiting-response Maintainers are waiting on response from community or contributor. label Sep 13, 2023
@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/shield Issues and PRs that pertain to the shield service.
Projects
None yet
Development

No branches or pull requests

3 participants