UI: Storybook upgrade #11279
Merged
UI: Storybook upgrade #11279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hopefully this work gets merged into ember-cli-storybook. For the time being, we get a fork instead.
Ember Asset Size actionAs of b9937df Files that stayed the same size 🤷:
|
Ember Test Audit comparison
|
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This upgrades us from Storybook v5 to Storybook v6 which unlocks #11274
For the most part this went smoothly. The only hiccup was that the hack we had in place for tricking the Ember router into being okay with links being in iframes stopped working. The patch this time included modifying
ember-cli-storybookto allow for environment overrides.Right now, this is pointed at my fork. If the Storybook PR merges, then I'll come back and update the dep.
How to test:
Just click around the Storybook preview and look for anything completely busted or missing.