-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI: Extract stories.json for Storybook composition #11274
Conversation
Ember Asset Size actionAs of 57e59eb Files that stayed the same size 🤷:
|
Lol, this requires storybook 6 and we're on storybook five 😂 😭 I'll change this to a draft and look into how much of a lift the upgrade is. |
Ember Test Audit comparison
|
9dee5b9
to
a98401a
Compare
a98401a
to
ac96f5b
Compare
ac96f5b
to
475b41b
Compare
{ | ||
"versions": { | ||
"main": "https://nomad-storybook-and-ui.vercel.app/storybook" | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i need to look into this comment https://github.com/hashicorp/cloud-ui/pull/1457#discussion_r724258881
i'm thinking it may not apply to nomad, cause the product is self-hosted, not cloud?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh snap, it definitely still applies. Everything in /public
gets shrink-wrapped into the nomad binary via go-bindata-assetfs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to follow up here, i removed /public/metadata.json
from cloud-ui
, since we don't seem to need versions
i will see if i can use the storybook link from this build in design-system-website
next
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
totally works! thanks for your help with this @DingoEatingFuzz, much appreciated https://github.com/hashicorp/design-system-website/pull/13
475b41b
to
57e59eb
Compare
still needs a change for the metadata.json to not be in prod, but moved to /dist or something @didoo @Dhaulagiri please update the URL on https://github.com/hashicorp/design-system-website/blob/main/taskbox/.storybook/main.js when this is merged |
We can close this to keep Nomad tidy, I filed https://github.com/hashicorp/unofficial-design-system-search/issues/44 to keep track, if |
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
This follows what we do in structure1 to surface the stories in Nomad's storybook. This way a meta-storybook instance can be created that pulls in Nomad's stories.
You can see what it looks like when a Storybook instance composes another storybook instance's stories here2.
Footnotes
Source PR: https://github.com/hashicorp/structure/pull/81 ↩
Note that underneath the HCP stories there's a "Structure" section with a version dropdown. ↩