Allow environment overrides specifically for Storybook #87
Conversation
index.js
Outdated
| @@ -93,6 +94,22 @@ module.exports = { | |||
|
|
|||
| this.ui.writeDebugLine('Generating preview-head.html'); | |||
|
|
|||
| const environment = parsedConfig.meta.find(meta => meta.name.endsWith('config/environment')); | |||
There was a problem hiding this comment.
Can we write a test case for this?
There was a problem hiding this comment.
Yep! Just wanted to make sure you were cool with the feature first 😅
|
I'm also running into issues running storybook with a |
Stories are rendered as full Ember Apps including the default Environment which may have settings that aren't appropriate for only rendering a single story in an iframe. Now those can be overridden with a .storybook/environment.js file
|
Sorry about the delay. I rebased and added some tests. There weren't existing tests for index.js (which I get, since it would require mocking all the build stuff) so I refactored the implementation a bit to push more of the logic into utils. Hopefully that is sufficient coverage. |
|
Looking good to me. Going to hit the merge button 👍 Thanks @DingoEatingFuzz for your PR and patience 😊 |
Stories are rendered as full Ember Apps including the default environment, which may have settings that aren't appropriate for only rendering a single story in an iframe.
This makes it so settings in
environment.jscan be overridden by settings in.storybook/environment.js.It also resets
rootURLto/(after doing the existingrootURLresource transformations) since Ember doesn't at all like running the router in an iframe whenrootURLis anything other than/.