fix(lease): reworks the previous fix addressing renewal issues #1105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Addresses the true underlying problem impacting the lease acquire method Signed-off-by: Nathan Klick <[email protected]>
1 similar comment
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1105 +/- ##
==========================================
- Coverage 84.76% 84.76% -0.01%
==========================================
Files 76 76
Lines 19970 19968 -2
Branches 1253 1443 +190
==========================================
- Hits 16928 16926 -2
+ Misses 3022 2980 -42
- Partials 20 62 +42
... and 19 files with indirect coverage changes |
jeromy-cannon
approved these changes
Jan 3, 2025
swirlds-automation
added a commit
that referenced
this pull request
Jan 13, 2025
## [0.33.0](v0.32.0...v0.33.0) (2025-01-13) ### Features * add support for genesis throttle configuration ([#1026](#1026)) ([d8903a8](d8903a8)) * enable Blockstreams and uploader ([#1109](#1109)) ([ed6527b](ed6527b)) * inspect existing cluster resources during cluster setup ([#1094](#1094)) ([808516c](808516c)) * production readiness pass custom mirror node postgresql credentials and server address ([#1128](#1128)) ([f8b7e41](f8b7e41)) * support using GCS for backup uploader ([#1130](#1130)) ([5fe2f4e](5fe2f4e)) * update genesis-network.json to add roster entries and more ([#1122](#1122)) ([c27d1d6](c27d1d6)) * Updating solo to leverage changes after moving acme-cluster-issuer and haproxy-ingress out of mirror-node-explorer ([#1079](#1079)) ([7965894](7965894)) * use gcs for stream file storage ([#994](#994)) ([04d5806](04d5806)) ### Bug Fixes * add missing images, fix debug page images ([#1092](#1092)) ([4073d31](4073d31)) * Bug when running `solo cluster connect` after fresh install ([#1123](#1123)) ([1cd0e28](1cd0e28)) * bump solo-charts to 0.42.2 to pull in blockStreams fix ([#1138](#1138)) ([c482895](c482895)) * bump versions of hedera, json rpc relay, and mirror node ([#1147](#1147)) ([0784b46](0784b46)) * clarify how to use nvm ([#1125](#1125)) ([bdc1873](bdc1873)) * commit message of auto update ([#1106](#1106)) ([a3231f9](a3231f9)) * external link rendering ([#1118](#1118)) ([28af1fe](28af1fe)) * file size empty error when throttle file is provided on command line ([#1140](#1140)) ([5180a76](5180a76)) * fixed release artifact version issue and updated readme link ([#1090](#1090)) ([84e6611](84e6611)) * **lease:** reworks the previous fix addressing renewal issues ([#1105](#1105)) ([5edb9c9](5edb9c9)) * should run `npm install` before build ([#1117](#1117)) ([3398875](3398875)) * solo deployment create should use email address in local config if it is already there instead of prompting the user for it ([#1112](#1112)) ([362df60](362df60)) * started adding a yachli example and taskfile ([#1132](#1132)) ([8753723](8753723)) * update to AccountManager._getNodeClient() to parallel node connection setup ([#1091](#1091)) ([4959a12](4959a12))
|
🎉 This PR is included in version 0.33.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 0.33.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request changes the following:
acquiremethod is called to ensure the lease holder information is properly updated.Related Issues