Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: external link rendering #1118

Merged
merged 1 commit into from
Jan 7, 2025
Merged

fix: external link rendering #1118

merged 1 commit into from
Jan 7, 2025

Conversation

JeffreyDallas
Copy link
Contributor

Description

This pull request changes the following:

  • Fixed the default html link hood rendering template, it was incorrectly replacing external link to empty string

Related Issues

Signed-off-by: Jeffrey Tang <[email protected]>
@JeffreyDallas JeffreyDallas requested review from a team as code owners January 6, 2025 19:00
@JeffreyDallas JeffreyDallas self-assigned this Jan 6, 2025
Copy link
Contributor

github-actions bot commented Jan 6, 2025

Unit Test Results - Linux

  1 files  ±0   58 suites  ±0   3s ⏱️ ±0s
227 tests ±0  227 ✅ ±0  0 💤 ±0  0 ❌ ±0 
232 runs  ±0  232 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 23af2cc. ± Comparison against base commit a3231f9.

Copy link
Contributor

github-actions bot commented Jan 6, 2025

Unit Test Results - Windows

  1 files  ±0   58 suites  ±0   12s ⏱️ ±0s
227 tests ±0  227 ✅ ±0  0 💤 ±0  0 ❌ ±0 
232 runs  ±0  232 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 23af2cc. ± Comparison against base commit a3231f9.

@jeromy-cannon jeromy-cannon merged commit 28af1fe into main Jan 7, 2025
36 of 38 checks passed
swirlds-automation added a commit that referenced this pull request Jan 13, 2025
## [0.33.0](v0.32.0...v0.33.0) (2025-01-13)

### Features

* add support for genesis throttle configuration ([#1026](#1026)) ([d8903a8](d8903a8))
* enable Blockstreams and uploader ([#1109](#1109)) ([ed6527b](ed6527b))
* inspect existing cluster resources during cluster setup ([#1094](#1094)) ([808516c](808516c))
* production readiness pass custom mirror node postgresql credentials and server address ([#1128](#1128)) ([f8b7e41](f8b7e41))
* support using GCS for backup uploader ([#1130](#1130)) ([5fe2f4e](5fe2f4e))
* update genesis-network.json to add roster entries and more ([#1122](#1122)) ([c27d1d6](c27d1d6))
* Updating solo to leverage changes after moving acme-cluster-issuer and haproxy-ingress out of mirror-node-explorer ([#1079](#1079)) ([7965894](7965894))
* use gcs for stream file storage ([#994](#994)) ([04d5806](04d5806))

### Bug Fixes

* add missing images, fix debug page images ([#1092](#1092)) ([4073d31](4073d31))
* Bug when running `solo cluster connect` after fresh install ([#1123](#1123)) ([1cd0e28](1cd0e28))
* bump solo-charts to 0.42.2 to pull in blockStreams fix ([#1138](#1138)) ([c482895](c482895))
* bump versions of hedera, json rpc relay, and mirror node ([#1147](#1147)) ([0784b46](0784b46))
* clarify how to use nvm ([#1125](#1125)) ([bdc1873](bdc1873))
* commit message of auto update ([#1106](#1106)) ([a3231f9](a3231f9))
* external link rendering ([#1118](#1118)) ([28af1fe](28af1fe))
* file size empty error when throttle file is provided on command line ([#1140](#1140)) ([5180a76](5180a76))
* fixed release artifact version issue and updated readme link ([#1090](#1090)) ([84e6611](84e6611))
* **lease:** reworks the previous fix addressing renewal issues ([#1105](#1105)) ([5edb9c9](5edb9c9))
* should run `npm install` before build ([#1117](#1117)) ([3398875](3398875))
* solo deployment create should use email address in local config if it is already there instead of prompting the user for it ([#1112](#1112)) ([362df60](362df60))
* started adding a yachli example and taskfile ([#1132](#1132)) ([8753723](8753723))
* update to AccountManager._getNodeClient() to parallel node connection setup ([#1091](#1091)) ([4959a12](4959a12))
@swirlds-automation
Copy link
Contributor

🎉 This PR is included in version 0.33.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@swirlds-automation
Copy link
Contributor

🎉 This PR is included in version 0.33.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Solo documentation external link not working
3 participants