Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Production Readiness: Rework fix for leases sometimes not renewed due to failure to transfer an expired lease during the acquire call #1104

Closed
Tracked by #868
nathanklick opened this issue Jan 3, 2025 · 2 comments · Fixed by #1105
Closed
Tracked by #868

Production Readiness: Rework fix for leases sometimes not renewed due to failure to transfer an expired lease during the acquire call #1104

nathanklick opened this issue Jan 3, 2025 · 2 comments · Fixed by #1105
Assignees
@nathanklick
Labels
Bug A error that causes the feature to behave differently than what was expected based on design docs P0 An issue impacting production environments or impacting multiple releases or multiple individuals. released on @0.33.x released

Comments

@nathanklick
Copy link
Member

nathanklick commented Jan 3, 2025 •
edited
Loading

Description

The fix for the IntervalLease implementation included in PR #978 may create future issues since it ultimately changes a low level utility method to behave well beyond the original scope. Instead the fix should be applied to the incorrect logic in the acquire method.

See the changes made here for reference.
@nathanklick nathanklick mentioned this issue Jan 3, 2025
Open
@nathanklick nathanklick self-assigned this Jan 3, 2025
@nathanklick nathanklick added Bug A error that causes the feature to behave differently than what was expected based on design docs P0 An issue impacting production environments or impacting multiple releases or multiple individuals. labels Jan 3, 2025
@nathanklick nathanklick added this to Solo Jan 3, 2025
@github-project-automation github-project-automation bot moved this to 🆕 New in Solo Jan 3, 2025
@nathanklick nathanklick mentioned this issue Jan 3, 2025
Merged
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in Solo Jan 3, 2025
@swirlds-automation
Copy link
Contributor

🎉 This issue has been resolved in version 0.33.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@swirlds-automation
Copy link
Contributor

🎉 This issue has been resolved in version 0.33.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nathanklick nathanklick

Labels
Bug A error that causes the feature to behave differently than what was expected based on design docs P0 An issue impacting production environments or impacting multiple releases or multiple individuals. released on @0.33.x released
Projects
Solo
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(lease): reworks the previous fix addressing renewal issues hashgraph/solo
2 participants
@nathanklick @swirlds-automation