fix: refactored Taskfiles, fixed bugs with taskfile, lease interval, sdk node client connection, and commands missing quiet flag #978

jeromy-cannon · 2024-12-10T23:37:56Z

Description

This pull request changes the following:

major taskfile refactor with multiple fixes (root taskfile, helpertasks, and those in examples directory)
added quiet flags to commands that were missing it
updated examples readme with explanation on how to use task command with the examples
sorted allFlags
updated _checkNetworkNodeActiveness to use execContainer instead of portForward to avoid a web socket failure that happens when running against GKE
increased error handling
improved logging messages
bumped solo charts and hedera platform version
removed logic to use java 17 ubi init based on version, and use default from charts which is 21
updated how node client uses external load balancer IP
added resiliency logic to do grpc pings while building and maintaining the sdk node client
fixed bug in acquire lease that caused exception to be thrown when it was released
reduced jvm heap to better run on small machines like our CICD
closed some gaps where the sdk node client was getting loaded when there was no active network nodes to connect to
updated settings.txt to match those being used in performance testing
bumped hedera version and solo-charts version to latest

Related Issues

Closes Cannot install new version: missing key "app.kubernetes.io/managed-by" #966

github-actions · 2024-12-10T23:39:33Z

Unit Test Results - Linux

1 files ±0 58 suites ±0 3s ⏱️ -1s
228 tests - 1 228 ✅ - 1 0 💤 ±0 0 ❌ ±0
233 runs - 6 233 ✅ - 6 0 💤 ±0 0 ❌ ±0

Results for commit 0973c00. ± Comparison against base commit 861c579.

This pull request removes 1 test.

should determine root-image for Hedera platform version ‑ Helpers should determine root-image for Hedera platform version

♻️ This comment has been updated with latest results.

github-actions · 2024-12-10T23:40:59Z

Unit Test Results - Windows

1 files ±0 58 suites ±0 13s ⏱️ ±0s
228 tests - 1 228 ✅ - 1 0 💤 ±0 0 ❌ ±0
233 runs - 6 233 ✅ - 6 0 💤 ±0 0 ❌ ±0

Results for commit 0973c00. ± Comparison against base commit 861c579.

This pull request removes 1 test.

should determine root-image for Hedera platform version ‑ Helpers should determine root-image for Hedera platform version

♻️ This comment has been updated with latest results.

github-actions · 2024-12-11T00:10:19Z

E2E Test Report

13 files ±0 105 suites ±0 59m 56s ⏱️ + 2m 28s
220 tests ±0 220 ✅ ±0 0 💤 ±0 0 ❌ ±0
223 runs ±0 223 ✅ ±0 0 💤 ±0 0 ❌ ±0

Results for commit a69f531. ± Comparison against base commit 88c2506.

This pull request removes 97 and adds 97 tests. Note that renamed tests count towards both.

Account creation should succeed ‑ E2E Test Suite for 'node-cmd-e2e-pem-kill' node-cmd-e2e-pem-kill NodeCommand [testName node-cmd-e2e-pem-kill, mode kill, release v0.56.5] Node should have started successfully [mode kill, release v0.56.5] Account creation should succeed
Account creation should succeed ‑ E2E Test Suite for 'node-cmd-e2e-pem-kill' node-cmd-e2e-pem-kill NodeCommand [testName node-cmd-e2e-pem-kill, mode kill, release v0.56.5] Node should refresh successfully [mode kill, release v0.56.5] Account creation should succeed
Account creation should succeed ‑ E2E Test Suite for 'node-cmd-e2e-pem-stop' node-cmd-e2e-pem-stop NodeCommand [testName node-cmd-e2e-pem-stop, mode stop, release v0.56.5] Node should have started successfully [mode stop, release v0.56.5] Account creation should succeed
Account creation should succeed ‑ E2E Test Suite for 'node-cmd-e2e-pem-stop' node-cmd-e2e-pem-stop NodeCommand [testName node-cmd-e2e-pem-stop, mode stop, release v0.56.5] Node should refresh successfully [mode stop, release v0.56.5] Account creation should succeed
Balance query should succeed ‑ E2E Test Suite for 'node-cmd-e2e-pem-kill' node-cmd-e2e-pem-kill NodeCommand [testName node-cmd-e2e-pem-kill, mode kill, release v0.56.5] Node should have started successfully [mode kill, release v0.56.5] Balance query should succeed
Balance query should succeed ‑ E2E Test Suite for 'node-cmd-e2e-pem-kill' node-cmd-e2e-pem-kill NodeCommand [testName node-cmd-e2e-pem-kill, mode kill, release v0.56.5] Node should refresh successfully [mode kill, release v0.56.5] Balance query should succeed
Balance query should succeed ‑ E2E Test Suite for 'node-cmd-e2e-pem-stop' node-cmd-e2e-pem-stop NodeCommand [testName node-cmd-e2e-pem-stop, mode stop, release v0.56.5] Node should have started successfully [mode stop, release v0.56.5] Balance query should succeed
Balance query should succeed ‑ E2E Test Suite for 'node-cmd-e2e-pem-stop' node-cmd-e2e-pem-stop NodeCommand [testName node-cmd-e2e-pem-stop, mode stop, release v0.56.5] Node should refresh successfully [mode stop, release v0.56.5] Balance query should succeed
Node Proxy should be UP [mode kill, release v0.56.5 ‑ E2E Test Suite for 'node-cmd-e2e-pem-kill' node-cmd-e2e-pem-kill NodeCommand [testName node-cmd-e2e-pem-kill, mode kill, release v0.56.5] Node should have started successfully [mode kill, release v0.56.5] Node Proxy should be UP [mode kill, release v0.56.5
Node Proxy should be UP [mode stop, release v0.56.5 ‑ E2E Test Suite for 'node-cmd-e2e-pem-stop' node-cmd-e2e-pem-stop NodeCommand [testName node-cmd-e2e-pem-stop, mode stop, release v0.56.5] Node should have started successfully [mode stop, release v0.56.5] Node Proxy should be UP [mode stop, release v0.56.5
…

Account creation should succeed ‑ E2E Test Suite for 'node-cmd-e2e-pem-kill' node-cmd-e2e-pem-kill NodeCommand [testName node-cmd-e2e-pem-kill, mode kill, release v0.57.1] Node should have started successfully [mode kill, release v0.57.1] Account creation should succeed
Account creation should succeed ‑ E2E Test Suite for 'node-cmd-e2e-pem-kill' node-cmd-e2e-pem-kill NodeCommand [testName node-cmd-e2e-pem-kill, mode kill, release v0.57.1] Node should refresh successfully [mode kill, release v0.57.1] Account creation should succeed
Account creation should succeed ‑ E2E Test Suite for 'node-cmd-e2e-pem-stop' node-cmd-e2e-pem-stop NodeCommand [testName node-cmd-e2e-pem-stop, mode stop, release v0.57.1] Node should have started successfully [mode stop, release v0.57.1] Account creation should succeed
Account creation should succeed ‑ E2E Test Suite for 'node-cmd-e2e-pem-stop' node-cmd-e2e-pem-stop NodeCommand [testName node-cmd-e2e-pem-stop, mode stop, release v0.57.1] Node should refresh successfully [mode stop, release v0.57.1] Account creation should succeed
Balance query should succeed ‑ E2E Test Suite for 'node-cmd-e2e-pem-kill' node-cmd-e2e-pem-kill NodeCommand [testName node-cmd-e2e-pem-kill, mode kill, release v0.57.1] Node should have started successfully [mode kill, release v0.57.1] Balance query should succeed
Balance query should succeed ‑ E2E Test Suite for 'node-cmd-e2e-pem-kill' node-cmd-e2e-pem-kill NodeCommand [testName node-cmd-e2e-pem-kill, mode kill, release v0.57.1] Node should refresh successfully [mode kill, release v0.57.1] Balance query should succeed
Balance query should succeed ‑ E2E Test Suite for 'node-cmd-e2e-pem-stop' node-cmd-e2e-pem-stop NodeCommand [testName node-cmd-e2e-pem-stop, mode stop, release v0.57.1] Node should have started successfully [mode stop, release v0.57.1] Balance query should succeed
Balance query should succeed ‑ E2E Test Suite for 'node-cmd-e2e-pem-stop' node-cmd-e2e-pem-stop NodeCommand [testName node-cmd-e2e-pem-stop, mode stop, release v0.57.1] Node should refresh successfully [mode stop, release v0.57.1] Balance query should succeed
Node Proxy should be UP [mode kill, release v0.57.1 ‑ E2E Test Suite for 'node-cmd-e2e-pem-kill' node-cmd-e2e-pem-kill NodeCommand [testName node-cmd-e2e-pem-kill, mode kill, release v0.57.1] Node should have started successfully [mode kill, release v0.57.1] Node Proxy should be UP [mode kill, release v0.57.1
Node Proxy should be UP [mode stop, release v0.57.1 ‑ E2E Test Suite for 'node-cmd-e2e-pem-stop' node-cmd-e2e-pem-stop NodeCommand [testName node-cmd-e2e-pem-stop, mode stop, release v0.57.1] Node should have started successfully [mode stop, release v0.57.1] Node Proxy should be UP [mode stop, release v0.57.1
…

github-actions · 2024-12-11T00:10:21Z

E2E Test Report

16 files 121 suites 1h 20m 58s ⏱️
258 tests 258 ✅ 0 💤 0 ❌
261 runs 261 ✅ 0 💤 0 ❌

Results for commit 0973c00.

♻️ This comment has been updated with latest results.

codacy-production · 2024-12-11T00:10:32Z

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation	Diff coverage
Report missing for `861c579`¹	✅ 84.80%

Coverage variation details

	Coverable lines	Covered lines	Coverage
Common ancestor commit (`861c579`)	Report Missing	Report Missing	Report Missing
Head commit (`0973c00`)	19560	16704	85.40%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details

	Coverable lines	Covered lines	Diff coverage
Pull request (#978)	250	212	84.80%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings Change summary preferences

_{Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more}

Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct. ↩

codecov · 2024-12-11T00:11:10Z

Codecov Report

Attention: Patch coverage is 84.80000% with 38 lines in your changes missing coverage. Please review.

Project coverage is 84.44%. Comparing base (043efcf) to head (0973c00).
Report is 25 commits behind head on main.

Files with missing lines	Patch %	Lines
src/core/account_manager.ts	79.23%	27 Missing ⚠️
src/commands/cluster.ts	0.00%	3 Missing ⚠️
src/core/lease/interval_lease.ts	62.50%	3 Missing ⚠️
src/commands/network.ts	33.33%	2 Missing ⚠️
src/commands/node/tasks.ts	90.47%	2 Missing ⚠️
src/core/k8.ts	97.05%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #978      +/-   ##
==========================================
- Coverage   84.99%   84.44%   -0.56%     
==========================================
  Files          71       72       +1     
  Lines       19225    19560     +335     
  Branches     1288     1295       +7     
==========================================
+ Hits        16340    16517     +177     
- Misses       2865     3011     +146     
- Partials       20       32      +12

Files with missing lines	Coverage Δ
src/commands/flags.ts	`73.53% <100.00%> (-4.98%)`	⬇️
src/commands/node/configs.ts	`96.98% <100.00%> (+0.01%)`	⬆️
src/commands/node/flags.ts	`100.00% <100.00%> (ø)`
src/commands/node/handlers.ts	`90.73% <100.00%> (ø)`
src/core/constants.ts	`97.04% <100.00%> (+0.04%)`	⬆️
src/core/helpers.ts	`88.37% <ø> (-0.71%)`	⬇️
src/core/profile_manager.ts	`95.43% <100.00%> (+0.71%)`	⬆️
src/core/time/duration.ts	`87.75% <100.00%> (ø)`
version.ts	`100.00% <100.00%> (ø)`
src/core/k8.ts	`88.18% <97.05%> (+0.02%)`	⬆️
... and 5 more

... and 4 files with indirect coverage changes

examples/custom-network-config/log4j2.xml

Signed-off-by: Jeromy Cannon <[email protected]>

…statement Signed-off-by: Jeromy Cannon <[email protected]>

Signed-off-by: Jeromy Cannon <[email protected]>

…ilient Signed-off-by: Jeromy Cannon <[email protected]>

Signed-off-by: Jeromy Cannon <[email protected]>

commit 294aa0a Author: Ivo Yankov <[email protected]> Date: Thu Dec 26 10:36:26 2024 +0200 chore: add build step to unit test CI Signed-off-by: Ivo Yankov <[email protected]> commit f67071c Author: Ivo Yankov <[email protected]> Date: Thu Dec 26 10:26:14 2024 +0200 fix: update mocha scripts in package.json Signed-off-by: Ivo Yankov <[email protected]> commit be6d88e Author: Ivo Yankov <[email protected]> Date: Thu Dec 26 09:54:26 2024 +0200 chore: run formatter Signed-off-by: Ivo Yankov <[email protected]> commit c0b8b16 Author: Ivo Yankov <[email protected]> Date: Thu Dec 26 09:52:14 2024 +0200 fix: various unit tests Signed-off-by: Ivo Yankov <[email protected]> commit 5a05b87 Author: Ivo Yankov <[email protected]> Date: Thu Dec 26 08:13:22 2024 +0200 fix: injections in tests Signed-off-by: Ivo Yankov <[email protected]> commit 6178ccf Merge: 24269fe c3a9691 Author: Ivo Yankov <[email protected]> Date: Tue Dec 24 15:39:32 2024 +0200 Merge remote-tracking branch 'origin/00822-implement-inversion-of-control-2' into 00822-implement-inversion-of-control-2 # Conflicts: # src/core/account_manager.ts # src/core/config/local_config.ts # src/core/config_manager.ts # src/core/lease/lease_manager.ts # src/core/profile_manager.ts # src/index.ts # test/setup.ts # test/test_container.ts # test/test_util.ts # test/unit/commands/base.test.ts # test/unit/commands/context.test.ts # test/unit/commands/network.test.ts # test/unit/core/platform_installer.test.ts # test/unit/core/profile_manager.test.ts commit c3a9691 Author: Jeromy Cannon <[email protected]> Date: Mon Dec 23 20:35:20 2024 +0000 add reflect metadata back Signed-off-by: Jeromy Cannon <[email protected]> commit dd13b95 Author: Jeromy Cannon <[email protected]> Date: Mon Dec 23 20:28:06 2024 +0000 fixed eslint errors from `npm run check` Signed-off-by: Jeromy Cannon <[email protected]> commit 6d7522c Author: Jeromy Cannon <[email protected]> Date: Mon Dec 23 20:14:08 2024 +0000 npm run format Signed-off-by: Jeromy Cannon <[email protected]> commit f323ca7 Author: Jeromy Cannon <[email protected]> Date: Mon Dec 23 19:59:26 2024 +0000 Squashed commit of the following: commit 24269fe Author: Ivo Yankov <[email protected]> Date: Fri Dec 20 11:03:26 2024 +0200 wip: attempting to fix tests Signed-off-by: Ivo Yankov <[email protected]> commit 7698f16 Author: Ivo Yankov <[email protected]> Date: Thu Dec 19 15:41:38 2024 +0200 chore: format Signed-off-by: Ivo Yankov <[email protected]> commit 507a081 Author: Ivo Yankov <[email protected]> Date: Thu Dec 19 14:53:36 2024 +0200 feat: implement IOC in core classes Signed-off-by: Ivo Yankov <[email protected]> commit c582f12 Author: Ivo Yankov <[email protected]> Date: Wed Dec 18 17:32:22 2024 +0200 wip: refactoring dependencies Signed-off-by: Ivo Yankov <[email protected]> Signed-off-by: Jeromy Cannon <[email protected]> commit 1b9b7e6 Author: Jan Milenkov <[email protected]> Date: Mon Dec 23 21:22:56 2024 +0200 feat: dynamically construct the genesis-network.json and add it to the values file to be used during network deploy (#982) Signed-off-by: Jeromy Cannon <[email protected]> Co-authored-by: Jeromy Cannon <[email protected]> commit 3c3673a Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon Dec 23 08:12:58 2024 -0600 chore(deps): bump jfrog/setup-jfrog-cli from 4.5.2 to 4.5.3 (#1015) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 299cd85 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon Dec 23 08:12:30 2024 -0600 chore(deps): bump helm/kind-action from 1.11.0 to 1.12.0 (#1014) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 1d57fb8 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon Dec 23 07:47:07 2024 -0600 chore(deps): bump chalk from 5.4.0 to 5.4.1 (#1013) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit a4e5cd8 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon Dec 23 07:26:24 2024 -0600 chore(deps): bump inquirer from 12.2.0 to 12.3.0 (#1012) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 7a69623 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Sun Dec 22 19:20:53 2024 +0000 chore(deps-dev): bump eslint-plugin-n from 17.15.0 to 17.15.1 (#1011) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 7bb0e99 Author: Jeromy Cannon <[email protected]> Date: Sun Dec 22 07:31:54 2024 +0000 fix: refactored Taskfiles, fixed bugs with taskfile, lease interval, sdk node client connection, and commands missing quiet flag (#978) Signed-off-by: Jeromy Cannon <[email protected]> commit 861c579 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Thu Dec 19 11:06:35 2024 -0600 chore(deps-dev): bump globals from 15.13.0 to 15.14.0 (#1007) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit e80bda8 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Thu Dec 19 11:06:22 2024 -0600 chore(deps): bump chalk from 5.3.0 to 5.4.0 (#1008) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit f4b49aa Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Thu Dec 19 10:47:50 2024 -0600 chore(deps): bump @hashgraph/sdk from 2.55.1 to 2.56.0 (#1009) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit c9711c5 Author: Ivo Yankov <[email protected]> Date: Thu Dec 19 18:47:03 2024 +0200 feat: update `solo context connect` to connect to single remote cluster (#993) Signed-off-by: Ivo Yankov <[email protected]> commit 043efcf Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Wed Dec 18 16:56:19 2024 -0600 chore(deps): bump actions/upload-artifact from 4.4.3 to 4.5.0 (#1002) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 8115945 Author: Pranali Deshmukh <[email protected]> Date: Thu Dec 19 00:55:58 2024 +0200 docs(README): Updated the "Install Solo" section. (#1004) Signed-off-by: Pranali Deshmukh <[email protected]> commit 01ed969 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Wed Dec 18 11:19:09 2024 -0600 chore(deps): bump actions/setup-java from 4.5.0 to 4.6.0 (#1003) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Jeromy Cannon <[email protected]>

@ignore

commit 04e69ea Author: Jeromy Cannon <[email protected]> Date: Thu Dec 26 13:22:26 2024 +0000 Squashed commit of the following: commit 5ab8bfdffd3c5d1932e7ed6a61e736d7216b4248 Author: Jeromy Cannon <[email protected]> Date: Thu Dec 26 13:15:50 2024 +0000 got `solo init` to work. Signed-off-by: Jeromy Cannon <[email protected]> commit 8bcf11c95ca5e310b177ed00be3a58a24fdbbac6 Author: Jeromy Cannon <[email protected]> Date: Mon Dec 23 22:00:08 2024 +0000 remove eslint errors Signed-off-by: Jeromy Cannon <[email protected]> commit de0046a370e14582500ce25e412cb8c8fb7158a1 Author: Jeromy Cannon <[email protected]> Date: Mon Dec 23 21:59:51 2024 +0000 removed isolated modules, it seems to be adding js files and dist folders in incorrect locations Signed-off-by: Jeromy Cannon <[email protected]> commit 4909cbdcf289ba35d68620bab88bb73815f5ecc2 Author: Jeromy Cannon <[email protected]> Date: Mon Dec 23 21:59:23 2024 +0000 change eslint back, if we need to override, we can use @ignore tags and document Signed-off-by: Jeromy Cannon <[email protected]> Signed-off-by: Jeromy Cannon <[email protected]> commit 8c16717 Author: Jeromy Cannon <[email protected]> Date: Thu Dec 26 13:24:23 2024 +0000 Squashed commit of the following: commit 294aa0a Author: Ivo Yankov <[email protected]> Date: Thu Dec 26 10:36:26 2024 +0200 chore: add build step to unit test CI Signed-off-by: Ivo Yankov <[email protected]> commit f67071c Author: Ivo Yankov <[email protected]> Date: Thu Dec 26 10:26:14 2024 +0200 fix: update mocha scripts in package.json Signed-off-by: Ivo Yankov <[email protected]> commit be6d88e Author: Ivo Yankov <[email protected]> Date: Thu Dec 26 09:54:26 2024 +0200 chore: run formatter Signed-off-by: Ivo Yankov <[email protected]> commit c0b8b16 Author: Ivo Yankov <[email protected]> Date: Thu Dec 26 09:52:14 2024 +0200 fix: various unit tests Signed-off-by: Ivo Yankov <[email protected]> commit 5a05b87 Author: Ivo Yankov <[email protected]> Date: Thu Dec 26 08:13:22 2024 +0200 fix: injections in tests Signed-off-by: Ivo Yankov <[email protected]> commit 6178ccf Merge: 24269fe c3a9691 Author: Ivo Yankov <[email protected]> Date: Tue Dec 24 15:39:32 2024 +0200 Merge remote-tracking branch 'origin/00822-implement-inversion-of-control-2' into 00822-implement-inversion-of-control-2 # Conflicts: # src/core/account_manager.ts # src/core/config/local_config.ts # src/core/config_manager.ts # src/core/lease/lease_manager.ts # src/core/profile_manager.ts # src/index.ts # test/setup.ts # test/test_container.ts # test/test_util.ts # test/unit/commands/base.test.ts # test/unit/commands/context.test.ts # test/unit/commands/network.test.ts # test/unit/core/platform_installer.test.ts # test/unit/core/profile_manager.test.ts commit c3a9691 Author: Jeromy Cannon <[email protected]> Date: Mon Dec 23 20:35:20 2024 +0000 add reflect metadata back Signed-off-by: Jeromy Cannon <[email protected]> commit dd13b95 Author: Jeromy Cannon <[email protected]> Date: Mon Dec 23 20:28:06 2024 +0000 fixed eslint errors from `npm run check` Signed-off-by: Jeromy Cannon <[email protected]> commit 6d7522c Author: Jeromy Cannon <[email protected]> Date: Mon Dec 23 20:14:08 2024 +0000 npm run format Signed-off-by: Jeromy Cannon <[email protected]> commit f323ca7 Author: Jeromy Cannon <[email protected]> Date: Mon Dec 23 19:59:26 2024 +0000 Squashed commit of the following: commit 24269fe Author: Ivo Yankov <[email protected]> Date: Fri Dec 20 11:03:26 2024 +0200 wip: attempting to fix tests Signed-off-by: Ivo Yankov <[email protected]> commit 7698f16 Author: Ivo Yankov <[email protected]> Date: Thu Dec 19 15:41:38 2024 +0200 chore: format Signed-off-by: Ivo Yankov <[email protected]> commit 507a081 Author: Ivo Yankov <[email protected]> Date: Thu Dec 19 14:53:36 2024 +0200 feat: implement IOC in core classes Signed-off-by: Ivo Yankov <[email protected]> commit c582f12 Author: Ivo Yankov <[email protected]> Date: Wed Dec 18 17:32:22 2024 +0200 wip: refactoring dependencies Signed-off-by: Ivo Yankov <[email protected]> Signed-off-by: Jeromy Cannon <[email protected]> commit 1b9b7e6 Author: Jan Milenkov <[email protected]> Date: Mon Dec 23 21:22:56 2024 +0200 feat: dynamically construct the genesis-network.json and add it to the values file to be used during network deploy (#982) Signed-off-by: Jeromy Cannon <[email protected]> Co-authored-by: Jeromy Cannon <[email protected]> commit 3c3673a Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon Dec 23 08:12:58 2024 -0600 chore(deps): bump jfrog/setup-jfrog-cli from 4.5.2 to 4.5.3 (#1015) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 299cd85 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon Dec 23 08:12:30 2024 -0600 chore(deps): bump helm/kind-action from 1.11.0 to 1.12.0 (#1014) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 1d57fb8 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon Dec 23 07:47:07 2024 -0600 chore(deps): bump chalk from 5.4.0 to 5.4.1 (#1013) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit a4e5cd8 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon Dec 23 07:26:24 2024 -0600 chore(deps): bump inquirer from 12.2.0 to 12.3.0 (#1012) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 7a69623 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Sun Dec 22 19:20:53 2024 +0000 chore(deps-dev): bump eslint-plugin-n from 17.15.0 to 17.15.1 (#1011) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 7bb0e99 Author: Jeromy Cannon <[email protected]> Date: Sun Dec 22 07:31:54 2024 +0000 fix: refactored Taskfiles, fixed bugs with taskfile, lease interval, sdk node client connection, and commands missing quiet flag (#978) Signed-off-by: Jeromy Cannon <[email protected]> commit 861c579 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Thu Dec 19 11:06:35 2024 -0600 chore(deps-dev): bump globals from 15.13.0 to 15.14.0 (#1007) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit e80bda8 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Thu Dec 19 11:06:22 2024 -0600 chore(deps): bump chalk from 5.3.0 to 5.4.0 (#1008) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit f4b49aa Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Thu Dec 19 10:47:50 2024 -0600 chore(deps): bump @hashgraph/sdk from 2.55.1 to 2.56.0 (#1009) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit c9711c5 Author: Ivo Yankov <[email protected]> Date: Thu Dec 19 18:47:03 2024 +0200 feat: update `solo context connect` to connect to single remote cluster (#993) Signed-off-by: Ivo Yankov <[email protected]> commit 043efcf Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Wed Dec 18 16:56:19 2024 -0600 chore(deps): bump actions/upload-artifact from 4.4.3 to 4.5.0 (#1002) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 8115945 Author: Pranali Deshmukh <[email protected]> Date: Thu Dec 19 00:55:58 2024 +0200 docs(README): Updated the "Install Solo" section. (#1004) Signed-off-by: Pranali Deshmukh <[email protected]> commit 01ed969 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Wed Dec 18 11:19:09 2024 -0600 chore(deps): bump actions/setup-java from 4.5.0 to 4.6.0 (#1003) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Jeromy Cannon <[email protected]> commit 24269fe Author: Ivo Yankov <[email protected]> Date: Fri Dec 20 11:03:26 2024 +0200 wip: attempting to fix tests Signed-off-by: Ivo Yankov <[email protected]> commit 7698f16 Author: Ivo Yankov <[email protected]> Date: Thu Dec 19 15:41:38 2024 +0200 chore: format Signed-off-by: Ivo Yankov <[email protected]> commit 507a081 Author: Ivo Yankov <[email protected]> Date: Thu Dec 19 14:53:36 2024 +0200 feat: implement IOC in core classes Signed-off-by: Ivo Yankov <[email protected]> commit c582f12 Author: Ivo Yankov <[email protected]> Date: Wed Dec 18 17:32:22 2024 +0200 wip: refactoring dependencies Signed-off-by: Ivo Yankov <[email protected]> Signed-off-by: Jeromy Cannon <[email protected]>

@ignore

commit 04e69ea Author: Jeromy Cannon <[email protected]> Date: Thu Dec 26 13:22:26 2024 +0000 Squashed commit of the following: commit 5ab8bfdffd3c5d1932e7ed6a61e736d7216b4248 Author: Jeromy Cannon <[email protected]> Date: Thu Dec 26 13:15:50 2024 +0000 got `solo init` to work. Signed-off-by: Jeromy Cannon <[email protected]> commit 8bcf11c95ca5e310b177ed00be3a58a24fdbbac6 Author: Jeromy Cannon <[email protected]> Date: Mon Dec 23 22:00:08 2024 +0000 remove eslint errors Signed-off-by: Jeromy Cannon <[email protected]> commit de0046a370e14582500ce25e412cb8c8fb7158a1 Author: Jeromy Cannon <[email protected]> Date: Mon Dec 23 21:59:51 2024 +0000 removed isolated modules, it seems to be adding js files and dist folders in incorrect locations Signed-off-by: Jeromy Cannon <[email protected]> commit 4909cbdcf289ba35d68620bab88bb73815f5ecc2 Author: Jeromy Cannon <[email protected]> Date: Mon Dec 23 21:59:23 2024 +0000 change eslint back, if we need to override, we can use @ignore tags and document Signed-off-by: Jeromy Cannon <[email protected]> Signed-off-by: Jeromy Cannon <[email protected]> commit 8c16717 Author: Jeromy Cannon <[email protected]> Date: Thu Dec 26 13:24:23 2024 +0000 Squashed commit of the following: commit 294aa0a Author: Ivo Yankov <[email protected]> Date: Thu Dec 26 10:36:26 2024 +0200 chore: add build step to unit test CI Signed-off-by: Ivo Yankov <[email protected]> commit f67071c Author: Ivo Yankov <[email protected]> Date: Thu Dec 26 10:26:14 2024 +0200 fix: update mocha scripts in package.json Signed-off-by: Ivo Yankov <[email protected]> commit be6d88e Author: Ivo Yankov <[email protected]> Date: Thu Dec 26 09:54:26 2024 +0200 chore: run formatter Signed-off-by: Ivo Yankov <[email protected]> commit c0b8b16 Author: Ivo Yankov <[email protected]> Date: Thu Dec 26 09:52:14 2024 +0200 fix: various unit tests Signed-off-by: Ivo Yankov <[email protected]> commit 5a05b87 Author: Ivo Yankov <[email protected]> Date: Thu Dec 26 08:13:22 2024 +0200 fix: injections in tests Signed-off-by: Ivo Yankov <[email protected]> commit 6178ccf Merge: 24269fe c3a9691 Author: Ivo Yankov <[email protected]> Date: Tue Dec 24 15:39:32 2024 +0200 Merge remote-tracking branch 'origin/00822-implement-inversion-of-control-2' into 00822-implement-inversion-of-control-2 # Conflicts: # src/core/account_manager.ts # src/core/config/local_config.ts # src/core/config_manager.ts # src/core/lease/lease_manager.ts # src/core/profile_manager.ts # src/index.ts # test/setup.ts # test/test_container.ts # test/test_util.ts # test/unit/commands/base.test.ts # test/unit/commands/context.test.ts # test/unit/commands/network.test.ts # test/unit/core/platform_installer.test.ts # test/unit/core/profile_manager.test.ts commit c3a9691 Author: Jeromy Cannon <[email protected]> Date: Mon Dec 23 20:35:20 2024 +0000 add reflect metadata back Signed-off-by: Jeromy Cannon <[email protected]> commit dd13b95 Author: Jeromy Cannon <[email protected]> Date: Mon Dec 23 20:28:06 2024 +0000 fixed eslint errors from `npm run check` Signed-off-by: Jeromy Cannon <[email protected]> commit 6d7522c Author: Jeromy Cannon <[email protected]> Date: Mon Dec 23 20:14:08 2024 +0000 npm run format Signed-off-by: Jeromy Cannon <[email protected]> commit f323ca7 Author: Jeromy Cannon <[email protected]> Date: Mon Dec 23 19:59:26 2024 +0000 Squashed commit of the following: commit 24269fe Author: Ivo Yankov <[email protected]> Date: Fri Dec 20 11:03:26 2024 +0200 wip: attempting to fix tests Signed-off-by: Ivo Yankov <[email protected]> commit 7698f16 Author: Ivo Yankov <[email protected]> Date: Thu Dec 19 15:41:38 2024 +0200 chore: format Signed-off-by: Ivo Yankov <[email protected]> commit 507a081 Author: Ivo Yankov <[email protected]> Date: Thu Dec 19 14:53:36 2024 +0200 feat: implement IOC in core classes Signed-off-by: Ivo Yankov <[email protected]> commit c582f12 Author: Ivo Yankov <[email protected]> Date: Wed Dec 18 17:32:22 2024 +0200 wip: refactoring dependencies Signed-off-by: Ivo Yankov <[email protected]> Signed-off-by: Jeromy Cannon <[email protected]> commit 1b9b7e6 Author: Jan Milenkov <[email protected]> Date: Mon Dec 23 21:22:56 2024 +0200 feat: dynamically construct the genesis-network.json and add it to the values file to be used during network deploy (#982) Signed-off-by: Jeromy Cannon <[email protected]> Co-authored-by: Jeromy Cannon <[email protected]> commit 3c3673a Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon Dec 23 08:12:58 2024 -0600 chore(deps): bump jfrog/setup-jfrog-cli from 4.5.2 to 4.5.3 (#1015) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 299cd85 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon Dec 23 08:12:30 2024 -0600 chore(deps): bump helm/kind-action from 1.11.0 to 1.12.0 (#1014) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 1d57fb8 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon Dec 23 07:47:07 2024 -0600 chore(deps): bump chalk from 5.4.0 to 5.4.1 (#1013) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit a4e5cd8 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon Dec 23 07:26:24 2024 -0600 chore(deps): bump inquirer from 12.2.0 to 12.3.0 (#1012) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 7a69623 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Sun Dec 22 19:20:53 2024 +0000 chore(deps-dev): bump eslint-plugin-n from 17.15.0 to 17.15.1 (#1011) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 7bb0e99 Author: Jeromy Cannon <[email protected]> Date: Sun Dec 22 07:31:54 2024 +0000 fix: refactored Taskfiles, fixed bugs with taskfile, lease interval, sdk node client connection, and commands missing quiet flag (#978) Signed-off-by: Jeromy Cannon <[email protected]> commit 861c579 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Thu Dec 19 11:06:35 2024 -0600 chore(deps-dev): bump globals from 15.13.0 to 15.14.0 (#1007) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit e80bda8 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Thu Dec 19 11:06:22 2024 -0600 chore(deps): bump chalk from 5.3.0 to 5.4.0 (#1008) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit f4b49aa Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Thu Dec 19 10:47:50 2024 -0600 chore(deps): bump @hashgraph/sdk from 2.55.1 to 2.56.0 (#1009) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit c9711c5 Author: Ivo Yankov <[email protected]> Date: Thu Dec 19 18:47:03 2024 +0200 feat: update `solo context connect` to connect to single remote cluster (#993) Signed-off-by: Ivo Yankov <[email protected]> commit 043efcf Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Wed Dec 18 16:56:19 2024 -0600 chore(deps): bump actions/upload-artifact from 4.4.3 to 4.5.0 (#1002) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 8115945 Author: Pranali Deshmukh <[email protected]> Date: Thu Dec 19 00:55:58 2024 +0200 docs(README): Updated the "Install Solo" section. (#1004) Signed-off-by: Pranali Deshmukh <[email protected]> commit 01ed969 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Wed Dec 18 11:19:09 2024 -0600 chore(deps): bump actions/setup-java from 4.5.0 to 4.6.0 (#1003) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Jeromy Cannon <[email protected]> commit 24269fe Author: Ivo Yankov <[email protected]> Date: Fri Dec 20 11:03:26 2024 +0200 wip: attempting to fix tests Signed-off-by: Ivo Yankov <[email protected]> commit 7698f16 Author: Ivo Yankov <[email protected]> Date: Thu Dec 19 15:41:38 2024 +0200 chore: format Signed-off-by: Ivo Yankov <[email protected]> commit 507a081 Author: Ivo Yankov <[email protected]> Date: Thu Dec 19 14:53:36 2024 +0200 feat: implement IOC in core classes Signed-off-by: Ivo Yankov <[email protected]> commit c582f12 Author: Ivo Yankov <[email protected]> Date: Wed Dec 18 17:32:22 2024 +0200 wip: refactoring dependencies Signed-off-by: Ivo Yankov <[email protected]> Signed-off-by: Jeromy Cannon <[email protected]>

## [0.32.0](v0.31.1...v0.32.0) (2024-12-31) ### ⚠ BREAKING CHANGES * update readme with warning about BREAKING CHANGE in this next release (#730) ### Features * add ci test flow to test task command to launch solo ([#811](#811)) ([356f341](356f341)) * add example for using javascript SDK ([#832](#832)) ([1d9452e](1d9452e)) * add extended math utils and duration support ([#923](#923)) ([f5a69e7](f5a69e7)) * add separate commands for update ([#735](#735)) ([44c3132](44c3132)) * add solo smoke test to test flow ([#905](#905)) ([79410f0](79410f0)) * add support for flexible lease acquisition and production readiness ([#830](#830)) ([7fa86ad](7fa86ad)) * Add the ability to inject a ca certificate for use in gRPC and gRPC Web ([#753](#753)) ([2cd8a38](2cd8a38)) * add timeout flag to network destroy command ([#821](#821)) ([0fb570b](0fb570b)) * allow settings a reserved static IP address for the consensus nodes HAProxy and Envoy Proxy though the cli with flags ([#937](#937)) ([de9ec2e](de9ec2e)) * change mirror node and explorer from subchart to individual chart ([#743](#743)) ([58f0496](58f0496)) * Create a local config for storing configurations on the users machine ([#803](#803)) ([0a4382d](0a4382d)) * Create remote config ([#862](#862)) ([e8fe739](e8fe739)) * dynamically construct the genesis-network.json and add it to the values file to be used during network deploy ([#982](#982)) ([1b9b7e6](1b9b7e6)) * expose pod check attempts and delays as environment controlled variables ([#812](#812)) ([a7b3279](a7b3279)) * Implement IOC ([#1010](#1010)) ([ed23a7b](ed23a7b)) * Implement solo context connect ([#863](#863)) ([782b3ec](782b3ec)) * Increase helm chart version and switch to use oci registry ([#788](#788)) ([1973275](1973275)) * **k8s:** introduce Kubernetes lease lock mechanism ([#707](#707)) ([f1b8089](f1b8089)) * new command to save state files and upload state files ([#849](#849)) ([d5a9a18](d5a9a18)) * removed caching of ConfigManager and its flags ([#713](#713)) ([76a61e3](76a61e3)) * Setup mirror node monitor pinger service ([#893](#893)) ([f4c4320](f4c4320)) * update `solo context connect` to connect to single remote cluster ([#993](#993)) ([c9711c5](c9711c5)) * Update document ([#956](#956)) ([b378937](b378937)) * update readme and hugo workflow ([#930](#930)) ([0e08abc](0e08abc)) * Validate a remote config ([#922](#922)) ([a7bbae0](a7bbae0)) ### Bug Fixes * add delay before calling script ([#955](#955)) ([76f4b81](76f4b81)) * allow expired leases to be overwritten ([#828](#828)) ([1fa1d78](1fa1d78)) * bump chart and hedera version, re-enable node add ([#985](#985)) ([9cae011](9cae011)) * check if setup chart installed or not before network deploy ([#799](#799)) ([6930dab](6930dab)) * document typo ([#988](#988)) ([8e4fe04](8e4fe04)) * Error in `node update` separate commands when new admin key is not supplied ([#854](#854)) ([6e472b5](6e472b5)) * Examples of performance configs for HashSphere and Latitude ([#926](#926)) ([#957](#957)) ([928148b](928148b)) * fix missing file issues when running solo from npm install -g ([#736](#736)) ([2a5cfc1](2a5cfc1)) * fixed genesis-network.json file lock issue ([#1074](#1074)) ([e590516](e590516)) * flag check of node logs command and incorrect download source ([#848](#848)) ([03051f0](03051f0)) * inconsistent failures ([#866](#866)) ([13ea46d](13ea46d)) * local chart directory not being taken correctly ([#983](#983)) ([58e96e1](58e96e1)) * nextNode ID for release version > 0.56.0 ([#765](#765)) ([3b98dd6](3b98dd6)) * node id should start from `1` ([#884](#884)) ([d90c9b5](d90c9b5)) * node update with single node ([#981](#981)) ([74285bf](74285bf)) * patch issue with dist folder not showing up ([#733](#733)) ([077f989](077f989)) * performance improvements for node stop ([#986](#986)) ([437bbc6](437bbc6)) * refactored Taskfiles, fixed bugs with taskfile, lease interval, sdk node client connection, and commands missing quiet flag ([#978](#978)) ([7bb0e99](7bb0e99)) * remote config validation not working ([#967](#967)) ([88c2506](88c2506)) * resolve node update test failures ([#856](#856)) ([5e1c652](5e1c652)) * Revised example configs for Latitude deployment, automation friendly ([#1038](#1038)) ([434daf3](434daf3)) * undefined log output of namespace ([#764](#764)) ([ac15957](ac15957)) ### Documentation * update readme with warning about BREAKING CHANGE in this next release ([#730](#730)) ([06295f6](06295f6))

swirlds-automation · 2024-12-31T21:26:44Z

🎉 This PR is included in version 0.32.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

jeromy-cannon self-assigned this Dec 10, 2024

jeromy-cannon changed the title ~~00966 cluster setup issue~~ chore: fixed taskfile example not working with cluster setup partially installed Dec 10, 2024

jeromy-cannon mentioned this pull request Dec 12, 2024

feat: Update document #956

Merged

jeromy-cannon force-pushed the 00966-cluster-setup-issue branch 3 times, most recently from d55da6e to 1f78b18 Compare December 16, 2024 13:26

hashgraph deleted a comment from alex-kuzmin-hg Dec 16, 2024

jeromy-cannon force-pushed the 00966-cluster-setup-issue branch 2 times, most recently from 527660a to bd51fad Compare December 18, 2024 17:36

jeromy-cannon marked this pull request as ready for review December 18, 2024 22:54

jeromy-cannon requested review from a team and leninmehedy as code owners December 18, 2024 22:54

jeromy-cannon requested review from Ivo-Yankov, nathanklick, JeffreyDallas and instamenta December 18, 2024 22:54

jeromy-cannon requested review from a team as code owners December 19, 2024 09:12

jeromy-cannon requested a review from rbarkerSL December 19, 2024 09:12

instamenta reviewed Dec 19, 2024

View reviewed changes

examples/custom-network-config/log4j2.xml Show resolved Hide resolved

instamenta previously approved these changes Dec 19, 2024

View reviewed changes

jeromy-cannon dismissed instamenta’s stale review via 42f1c4a December 19, 2024 18:19

jeromy-cannon changed the title ~~chore: fixed taskfile example not working with cluster setup partially installed~~ fix: fixed taskfile example not working with cluster setup partially installed Dec 20, 2024

jeromy-cannon added 15 commits December 20, 2024 20:39

removed no longer needed if check for version less than 40

3b517bb

Signed-off-by: Jeromy Cannon <[email protected]>

don't set the release tag if the local build path is used

e036a35

Signed-off-by: Jeromy Cannon <[email protected]>

enhance debugging error message

48a78c2

Signed-off-by: Jeromy Cannon <[email protected]>

set new lease holder for acquire

b5119c4

Signed-off-by: Jeromy Cannon <[email protected]>

set new lease holder for acquire

8c75230

Signed-off-by: Jeromy Cannon <[email protected]>

reverted checkExpiration to static after no longer needing debug log …

459d43a

…statement Signed-off-by: Jeromy Cannon <[email protected]>

correct usage of taskfile var usage

ad1e3fa

Signed-off-by: Jeromy Cannon <[email protected]>

reduce number of nodes running for CICD

2f08380

Signed-off-by: Jeromy Cannon <[email protected]>

fixed node local hedera test and made grpc client connection more res…

13d0681

…ilient Signed-off-by: Jeromy Cannon <[email protected]>

fixed bug where client.isClientShutDown could be null

7d04b0d

Signed-off-by: Jeromy Cannon <[email protected]>

fixed tsdoc

0ee8cff

Signed-off-by: Jeromy Cannon <[email protected]>

removed test that was no longer needed

4f5f75c

Signed-off-by: Jeromy Cannon <[email protected]>

removed test that was no longer needed

17e7e9c

Signed-off-by: Jeromy Cannon <[email protected]>

removed comment that is out of context

db61cc1

Signed-off-by: Jeromy Cannon <[email protected]>

make parameter optional

cafbc7e

Signed-off-by: Jeromy Cannon <[email protected]>

jeromy-cannon force-pushed the 00966-cluster-setup-issue branch from 8c1ab0e to cafbc7e Compare December 20, 2024 20:39

jeromy-cannon added 4 commits December 20, 2024 20:41

removed unused import

b863bc5

Signed-off-by: Jeromy Cannon <[email protected]>

incorrect optional parameter syntax

d58e133

Signed-off-by: Jeromy Cannon <[email protected]>

missed some locations for shouldLoadNodeClient

ee718b2

Signed-off-by: Jeromy Cannon <[email protected]>

got test cases working

0973c00

Signed-off-by: Jeromy Cannon <[email protected]>

instamenta approved these changes Dec 21, 2024

View reviewed changes

jeromy-cannon merged commit 7bb0e99 into main Dec 22, 2024
37 of 39 checks passed

jeromy-cannon deleted the 00966-cluster-setup-issue branch December 22, 2024 07:31

swirlds-automation added the released label Dec 31, 2024

nathanklick mentioned this pull request Jan 3, 2025

Production Readiness: Rework fix for leases sometimes not renewed due to failure to transfer an expired lease during the acquire call #1104

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: refactored Taskfiles, fixed bugs with taskfile, lease interval, sdk node client connection, and commands missing quiet flag #978

fix: refactored Taskfiles, fixed bugs with taskfile, lease interval, sdk node client connection, and commands missing quiet flag #978

jeromy-cannon commented Dec 10, 2024 •

edited

Loading

github-actions bot commented Dec 10, 2024 •

edited

Loading

github-actions bot commented Dec 10, 2024 •

edited

Loading

github-actions bot commented Dec 11, 2024

github-actions bot commented Dec 11, 2024 •

edited

Loading

codacy-production bot commented Dec 11, 2024 •

edited

Loading

codecov bot commented Dec 11, 2024 •

edited

Loading

swirlds-automation commented Dec 31, 2024

fix: refactored Taskfiles, fixed bugs with taskfile, lease interval, sdk node client connection, and commands missing quiet flag #978

fix: refactored Taskfiles, fixed bugs with taskfile, lease interval, sdk node client connection, and commands missing quiet flag #978

Conversation

jeromy-cannon commented Dec 10, 2024 • edited Loading

Description

Related Issues

github-actions bot commented Dec 10, 2024 • edited Loading

Unit Test Results - Linux

github-actions bot commented Dec 10, 2024 • edited Loading

Unit Test Results - Windows

github-actions bot commented Dec 11, 2024

E2E Test Report

github-actions bot commented Dec 11, 2024 • edited Loading

E2E Test Report

codacy-production bot commented Dec 11, 2024 • edited Loading

Coverage summary from Codacy

See diff coverage on Codacy

See your quality gate settings Change summary preferences

Footnotes

codecov bot commented Dec 11, 2024 • edited Loading

Codecov Report

swirlds-automation commented Dec 31, 2024

jeromy-cannon commented Dec 10, 2024 •

edited

Loading

github-actions bot commented Dec 10, 2024 •

edited

Loading

github-actions bot commented Dec 10, 2024 •

edited

Loading

github-actions bot commented Dec 11, 2024 •

edited

Loading

codacy-production bot commented Dec 11, 2024 •

edited

Loading

codecov bot commented Dec 11, 2024 •

edited

Loading