feat: Implement solo context connect #863
Conversation
Signed-off-by: Ivo Yankov <[email protected]>
…of-2-updates-the-localconfig-by-connecting-a-deployment-to-a-k8s-context # Conflicts: # src/commands/node/handlers.ts # src/commands/node/tasks.ts # src/core/k8.ts
Signed-off-by: Ivo Yankov <[email protected]>
Signed-off-by: Ivo Yankov <[email protected]>
Signed-off-by: Ivo Yankov <[email protected]>
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #863 +/- ##
==========================================
- Coverage 83.81% 83.62% -0.19%
==========================================
Files 49 54 +5
Lines 14934 15241 +307
Branches 1034 1431 +397
==========================================
+ Hits 12517 12746 +229
+ Misses 2401 2384 -17
- Partials 16 111 +95
... and 25 files with indirect coverage changes |
…of-2-updates-the-localconfig-by-connecting-a-deployment-to-a-k8s-context
Ivo-Yankov
changed the title
|
|
||
| export const DEFAULT_FLAGS = { | ||
| requiredFlags: [], | ||
| requiredFlagsWithDisabledPrompt: [flags.namespace, flags.cacheDir, flags.releaseTag], |
There was a problem hiding this comment.
what makes releaseTag required or used for solo context connect?
| this.parent.logger.info(`currentDeploymentName: ${currentDeploymentName}`) | ||
| this.parent.logger.info(`contextName: ${contextName}`) | ||
| this.parent.logger.info(`clusterAliases: ${clusterAliases.join(' ')}`) | ||
| this.parent.logger.info('Save LocalConfig file') |
There was a problem hiding this comment.
| this.parent.logger.info(`currentDeploymentName: ${currentDeploymentName}`) | |
| this.parent.logger.info(`contextName: ${contextName}`) | |
| this.parent.logger.info(`clusterAliases: ${clusterAliases.join(' ')}`) | |
| this.parent.logger.info('Save LocalConfig file') | |
| this.parent.logger.info('Save LocalConfig file: [currentDeploymentName: ${currentDeploymentName}, contextName: ${contextName}, clusterAliases: ${clusterAliases.join(' ')}]') |
less verbose in the log file if it is on one line
There was a problem hiding this comment.
I recall us talking about storing the cluster to context mapping by reading it in, but not saving it to the local config file, so that it would be rebuilt each time and can be used by other parts of the application. Maybe I'll find it somewhere else while reviewing this PR?
| constructor (public title: string, public task: Function, public skip: Function | boolean = false) { | ||
| this.title = title | ||
| this.task = task | ||
| this.skip = skip | ||
| } |
There was a problem hiding this comment.
| constructor (public title: string, public task: Function, public skip: Function | boolean = false) { | |
| this.title = title | |
| this.task = task | |
| this.skip = skip | |
| } | |
| constructor (public title: string, public task: Function, public skip: Function | boolean = false) { } |
I think this means the same thing?
| .then(conn => { | ||
| self.logger.info(`${messagePrefix} connection established`) | ||
| localContext.connection = conn | ||
| ({ status }) => self.handleCallback(status, localContext, messagePrefix)) |
There was a problem hiding this comment.
what formatter are you using? I noticed that npm run format does not do this. I have an outstanding item to implement prettier. although now that we agreed on google style, there is probably a better way.
In IntelliJ, I had the Palantir Style set, previously in Java, so some of those settings carried over. If I reformat this file, it changes everything back to how I had it. We need to all get on the same page and use the same settings.
solo context connectcommand.contextandclusterNamesolo context connectaccepts the following flags:--namespace--context--cluster-name--quiet-modeWhen a flag is not specified the user will be prompted to input a value. For
contexta list of all contexts fromkubectl configis provided. Whenquiet=truethe default values fromkubectlare used.Currently the command utilizes the
promptLocalConfigTasktask, which creates thelocal-config.yamlfile if it doesn't exist and prompts foruserEmailAddressand fordeployments. In a future PR this will be changed so that a different command will be responsible for instantiating the local configuration.Related Issues
solo context connectpart 1 of 2 - updates the LocalConfig by connecting a deployment to a k8s context #754