feat: Validate a remote config #922

instamenta · 2024-12-04T17:18:33Z

Description

Added new static class RemoteConfigValidator that validates that components kept in the remote config reflect are present in the cluster

Related Issues

Closes # 776 777 774

…xt interfaces in seperate files and experimented a bit with new ways to write Listr2 related types Signed-off-by: instamenta <[email protected]>

…template renders and labels selectors added for components tracked by remote config Signed-off-by: instamenta <[email protected]>

…teconfig-with-a-deployment-that-has-a-mirror-node-and-explorer-deployed # Conflicts: # src/types/index.ts

github-actions · 2024-12-04T17:23:42Z

Unit Test Results - Linux

1 files ±0 50 suites ±0 5s ⏱️ +2s
198 tests ±0 198 ✅ ±0 0 💤 ±0 0 ❌ ±0
208 runs ±0 208 ✅ ±0 0 💤 ±0 0 ❌ ±0

Results for commit 030f338. ± Comparison against base commit 9cd610d.

♻️ This comment has been updated with latest results.

github-actions · 2024-12-04T17:25:28Z

Unit Test Results - Windows

1 files ±0 50 suites ±0 12s ⏱️ -1s
198 tests ±0 198 ✅ ±0 0 💤 ±0 0 ❌ ±0
208 runs ±0 208 ✅ ±0 0 💤 ±0 0 ❌ ±0

Results for commit 030f338. ± Comparison against base commit 9cd610d.

♻️ This comment has been updated with latest results.

github-actions · 2024-12-04T17:52:53Z

E2E Test Report

13 files ±0 98 suites ±0 56m 40s ⏱️ + 1m 10s
208 tests ±0 208 ✅ ±0 0 💤 ±0 0 ❌ ±0
211 runs ±0 211 ✅ ±0 0 💤 ±0 0 ❌ ±0

Results for commit b2cbd4d. ± Comparison against base commit 29778f0.

github-actions · 2024-12-04T17:52:54Z

E2E Test Report

13 files ± 0 105 suites +7 55m 43s ⏱️ -21s
220 tests +12 220 ✅ +12 0 💤 ±0 0 ❌ ±0
223 runs +12 223 ✅ +12 0 💤 ±0 0 ❌ ±0

Results for commit 030f338. ± Comparison against base commit 9cd610d.

♻️ This comment has been updated with latest results.

codecov · 2024-12-04T17:54:04Z

Codecov Report

Attention: Patch coverage is 93.60465% with 11 lines in your changes missing coverage. Please review.

Project coverage is 82.60%. Comparing base (9cd610d) to head (030f338).
Report is 60 commits behind head on main.

Files with missing lines	Patch %	Lines
src/core/config/remote/remote_config_validator.ts	93.57%	9 Missing ⚠️
src/core/config/remote/remote_config_manager.ts	71.42%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #922      +/-   ##
==========================================
+ Coverage   82.51%   82.60%   +0.09%     
==========================================
  Files          66       67       +1     
  Lines       18177    18335     +158     
  Branches     1112     1244     +132     
==========================================
+ Hits        14999    15146     +147     
+ Misses       3176     3131      -45     
- Partials        2       58      +56

Files with missing lines	Coverage Δ
src/commands/mirror_node.ts	`76.36% <100.00%> (ø)`
src/core/config/remote/components_data_wrapper.ts	`85.39% <100.00%> (+0.31%)`	⬆️
src/core/constants.ts	`97.05% <100.00%> (+0.10%)`	⬆️
src/core/templates.ts	`75.93% <100.00%> (+0.74%)`	⬆️
src/core/config/remote/remote_config_manager.ts	`80.67% <71.42%> (-0.83%)`	⬇️
src/core/config/remote/remote_config_validator.ts	`93.57% <93.57%> (ø)`

... and 10 files with indirect coverage changes

codacy-production · 2024-12-04T18:14:25Z

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation	Diff coverage
✅ +0.10% (target: -1.00%)	✅ 93.60%

Coverage variation details

	Coverable lines	Covered lines	Coverage
Common ancestor commit (`9cd610d`)	18149	15169	83.58%
Head commit (`030f338`)	18335 (+186)	15343 (+174)	83.68% (+0.10%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details

	Coverable lines	Covered lines	Diff coverage
Pull request (#922)	172	161	93.60%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings Change summary preferences

_{Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more}

Signed-off-by: instamenta <[email protected]>

…ent-that-has-a-mirror-node-and-explorer-deployed

Signed-off-by: instamenta <[email protected]>

…th-a-deployment-that-has-a-mirror-node-and-explorer-deployed' into 00776-validate-a-remoteconfig-with-a-deployment-that-has-a-mirror-node-and-explorer-deployed

Signed-off-by: instamenta <[email protected]>

## [0.32.0](v0.31.1...v0.32.0) (2024-12-31) ### ⚠ BREAKING CHANGES * update readme with warning about BREAKING CHANGE in this next release (#730) ### Features * add ci test flow to test task command to launch solo ([#811](#811)) ([356f341](356f341)) * add example for using javascript SDK ([#832](#832)) ([1d9452e](1d9452e)) * add extended math utils and duration support ([#923](#923)) ([f5a69e7](f5a69e7)) * add separate commands for update ([#735](#735)) ([44c3132](44c3132)) * add solo smoke test to test flow ([#905](#905)) ([79410f0](79410f0)) * add support for flexible lease acquisition and production readiness ([#830](#830)) ([7fa86ad](7fa86ad)) * Add the ability to inject a ca certificate for use in gRPC and gRPC Web ([#753](#753)) ([2cd8a38](2cd8a38)) * add timeout flag to network destroy command ([#821](#821)) ([0fb570b](0fb570b)) * allow settings a reserved static IP address for the consensus nodes HAProxy and Envoy Proxy though the cli with flags ([#937](#937)) ([de9ec2e](de9ec2e)) * change mirror node and explorer from subchart to individual chart ([#743](#743)) ([58f0496](58f0496)) * Create a local config for storing configurations on the users machine ([#803](#803)) ([0a4382d](0a4382d)) * Create remote config ([#862](#862)) ([e8fe739](e8fe739)) * dynamically construct the genesis-network.json and add it to the values file to be used during network deploy ([#982](#982)) ([1b9b7e6](1b9b7e6)) * expose pod check attempts and delays as environment controlled variables ([#812](#812)) ([a7b3279](a7b3279)) * Implement IOC ([#1010](#1010)) ([ed23a7b](ed23a7b)) * Implement solo context connect ([#863](#863)) ([782b3ec](782b3ec)) * Increase helm chart version and switch to use oci registry ([#788](#788)) ([1973275](1973275)) * **k8s:** introduce Kubernetes lease lock mechanism ([#707](#707)) ([f1b8089](f1b8089)) * new command to save state files and upload state files ([#849](#849)) ([d5a9a18](d5a9a18)) * removed caching of ConfigManager and its flags ([#713](#713)) ([76a61e3](76a61e3)) * Setup mirror node monitor pinger service ([#893](#893)) ([f4c4320](f4c4320)) * update `solo context connect` to connect to single remote cluster ([#993](#993)) ([c9711c5](c9711c5)) * Update document ([#956](#956)) ([b378937](b378937)) * update readme and hugo workflow ([#930](#930)) ([0e08abc](0e08abc)) * Validate a remote config ([#922](#922)) ([a7bbae0](a7bbae0)) ### Bug Fixes * add delay before calling script ([#955](#955)) ([76f4b81](76f4b81)) * allow expired leases to be overwritten ([#828](#828)) ([1fa1d78](1fa1d78)) * bump chart and hedera version, re-enable node add ([#985](#985)) ([9cae011](9cae011)) * check if setup chart installed or not before network deploy ([#799](#799)) ([6930dab](6930dab)) * document typo ([#988](#988)) ([8e4fe04](8e4fe04)) * Error in `node update` separate commands when new admin key is not supplied ([#854](#854)) ([6e472b5](6e472b5)) * Examples of performance configs for HashSphere and Latitude ([#926](#926)) ([#957](#957)) ([928148b](928148b)) * fix missing file issues when running solo from npm install -g ([#736](#736)) ([2a5cfc1](2a5cfc1)) * fixed genesis-network.json file lock issue ([#1074](#1074)) ([e590516](e590516)) * flag check of node logs command and incorrect download source ([#848](#848)) ([03051f0](03051f0)) * inconsistent failures ([#866](#866)) ([13ea46d](13ea46d)) * local chart directory not being taken correctly ([#983](#983)) ([58e96e1](58e96e1)) * nextNode ID for release version > 0.56.0 ([#765](#765)) ([3b98dd6](3b98dd6)) * node id should start from `1` ([#884](#884)) ([d90c9b5](d90c9b5)) * node update with single node ([#981](#981)) ([74285bf](74285bf)) * patch issue with dist folder not showing up ([#733](#733)) ([077f989](077f989)) * performance improvements for node stop ([#986](#986)) ([437bbc6](437bbc6)) * refactored Taskfiles, fixed bugs with taskfile, lease interval, sdk node client connection, and commands missing quiet flag ([#978](#978)) ([7bb0e99](7bb0e99)) * remote config validation not working ([#967](#967)) ([88c2506](88c2506)) * resolve node update test failures ([#856](#856)) ([5e1c652](5e1c652)) * Revised example configs for Latitude deployment, automation friendly ([#1038](#1038)) ([434daf3](434daf3)) * undefined log output of namespace ([#764](#764)) ([ac15957](ac15957)) ### Documentation * update readme with warning about BREAKING CHANGE in this next release ([#730](#730)) ([06295f6](06295f6))

swirlds-automation · 2024-12-31T21:28:56Z

🎉 This PR is included in version 0.32.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

instamenta added 2 commits December 4, 2024 13:53

added improved logic for adding the remote component, moved the conte…

e813396

…xt interfaces in seperate files and experimented a bit with new ways to write Listr2 related types Signed-off-by: instamenta <[email protected]>

implemented validation, proper remote config components tracking and …

9de7dc9

…template renders and labels selectors added for components tracked by remote config Signed-off-by: instamenta <[email protected]>

instamenta requested review from leninmehedy and a team as code owners December 4, 2024 17:18

instamenta linked an issue Dec 4, 2024 that may be closed by this pull request

Validate a RemoteConfig with a deployment that has a mirror node and explorer deployed #776

Closed

instamenta closed this Dec 4, 2024

instamenta reopened this Dec 4, 2024

instamenta self-assigned this Dec 4, 2024

instamenta marked this pull request as draft December 4, 2024 17:19

Merge remote-tracking branch 'origin/main' into 00776-validate-a-remo…

b2cbd4d

…teconfig-with-a-deployment-that-has-a-mirror-node-and-explorer-deployed # Conflicts: # src/types/index.ts

instamenta added 3 commits December 5, 2024 15:50

added tests for validator class

99b0e17

Signed-off-by: instamenta <[email protected]>

merge with main

396b4fd

Signed-off-by: instamenta <[email protected]>

merge with main

6da7a34

Signed-off-by: instamenta <[email protected]>

jeromy-cannon previously approved these changes Dec 5, 2024

View reviewed changes

instamenta marked this pull request as ready for review December 6, 2024 07:56

instamenta added 4 commits December 6, 2024 09:57

Merge branch 'main' into 00776-validate-a-remoteconfig-with-a-deploym…

4bb942f

…ent-that-has-a-mirror-node-and-explorer-deployed

merge with main

b49c688

Signed-off-by: instamenta <[email protected]>

Merge remote-tracking branch 'origin/00776-validate-a-remoteconfig-wi…

c77603d

…th-a-deployment-that-has-a-mirror-node-and-explorer-deployed' into 00776-validate-a-remoteconfig-with-a-deployment-that-has-a-mirror-node-and-explorer-deployed

fix issues related to merge

52cd73c

Signed-off-by: instamenta <[email protected]>

instamenta dismissed jeromy-cannon’s stale review via 52cd73c December 6, 2024 08:23

instamenta added 2 commits December 6, 2024 13:33

merge with main

35452b4

Signed-off-by: instamenta <[email protected]>

lint fix

030f338

Signed-off-by: instamenta <[email protected]>

jeromy-cannon approved these changes Dec 6, 2024

View reviewed changes

jeromy-cannon merged commit a7bbae0 into main Dec 6, 2024
35 checks passed

jeromy-cannon deleted the 00776-validate-a-remoteconfig-with-a-deployment-that-has-a-mirror-node-and-explorer-deployed branch December 6, 2024 12:12

This was referenced Dec 6, 2024

Validate a RemoteConfig with a deployment that has a relay deployed #777

Closed

Validate a RemoteConfig with a deployment that has one cluster instance #774

Closed

swirlds-automation added the released label Dec 31, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Validate a remote config #922

feat: Validate a remote config #922

instamenta commented Dec 4, 2024 •

edited

Loading

github-actions bot commented Dec 4, 2024 •

edited

Loading

github-actions bot commented Dec 4, 2024 •

edited

Loading

github-actions bot commented Dec 4, 2024

github-actions bot commented Dec 4, 2024 •

edited

Loading

codecov bot commented Dec 4, 2024 •

edited

Loading

codacy-production bot commented Dec 4, 2024 •

edited

Loading

swirlds-automation commented Dec 31, 2024

feat: Validate a remote config #922

feat: Validate a remote config #922

Conversation

instamenta commented Dec 4, 2024 • edited Loading

Description

Related Issues

github-actions bot commented Dec 4, 2024 • edited Loading

Unit Test Results - Linux

github-actions bot commented Dec 4, 2024 • edited Loading

Unit Test Results - Windows

github-actions bot commented Dec 4, 2024

E2E Test Report

github-actions bot commented Dec 4, 2024 • edited Loading

E2E Test Report

codecov bot commented Dec 4, 2024 • edited Loading

Codecov Report

codacy-production bot commented Dec 4, 2024 • edited Loading

Coverage summary from Codacy

See diff coverage on Codacy

See your quality gate settings Change summary preferences

swirlds-automation commented Dec 31, 2024

instamenta commented Dec 4, 2024 •

edited

Loading

github-actions bot commented Dec 4, 2024 •

edited

Loading

github-actions bot commented Dec 4, 2024 •

edited

Loading

github-actions bot commented Dec 4, 2024 •

edited

Loading

codecov bot commented Dec 4, 2024 •

edited

Loading

codacy-production bot commented Dec 4, 2024 •

edited

Loading