feat: Implement IOC #1010

Ivo-Yankov · 2024-12-20T09:06:23Z

Description

This pull request changes the following:

implement Inversion of Control / Dependency Injection via tsyringe-neo with managers and common instances used in command constructors

Related Issues

Closes Implement inversion of control #822
Closes Use Inversion of Control (IoC) container #37

github-actions · 2024-12-23T20:29:47Z

Unit Test Results - Linux

1 files ±0 58 suites ±0 3s ⏱️ ±0s
228 tests ±0 228 ✅ ±0 0 💤 ±0 0 ❌ ±0
233 runs ±0 233 ✅ ±0 0 💤 ±0 0 ❌ ±0

Results for commit 7b56326. ± Comparison against base commit 813a4ab.

♻️ This comment has been updated with latest results.

github-actions · 2024-12-23T20:31:09Z

Unit Test Results - Windows

1 files ±0 58 suites ±0 12s ⏱️ -2s
228 tests ±0 228 ✅ ±0 0 💤 ±0 0 ❌ ±0
233 runs ±0 233 ✅ ±0 0 💤 ±0 0 ❌ ±0

Results for commit 7b56326. ± Comparison against base commit 813a4ab.

♻️ This comment has been updated with latest results.

@ignore

commit 04e69ea Author: Jeromy Cannon <[email protected]> Date: Thu Dec 26 13:22:26 2024 +0000 Squashed commit of the following: commit 5ab8bfdffd3c5d1932e7ed6a61e736d7216b4248 Author: Jeromy Cannon <[email protected]> Date: Thu Dec 26 13:15:50 2024 +0000 got `solo init` to work. Signed-off-by: Jeromy Cannon <[email protected]> commit 8bcf11c95ca5e310b177ed00be3a58a24fdbbac6 Author: Jeromy Cannon <[email protected]> Date: Mon Dec 23 22:00:08 2024 +0000 remove eslint errors Signed-off-by: Jeromy Cannon <[email protected]> commit de0046a370e14582500ce25e412cb8c8fb7158a1 Author: Jeromy Cannon <[email protected]> Date: Mon Dec 23 21:59:51 2024 +0000 removed isolated modules, it seems to be adding js files and dist folders in incorrect locations Signed-off-by: Jeromy Cannon <[email protected]> commit 4909cbdcf289ba35d68620bab88bb73815f5ecc2 Author: Jeromy Cannon <[email protected]> Date: Mon Dec 23 21:59:23 2024 +0000 change eslint back, if we need to override, we can use @ignore tags and document Signed-off-by: Jeromy Cannon <[email protected]> Signed-off-by: Jeromy Cannon <[email protected]> commit 8c16717 Author: Jeromy Cannon <[email protected]> Date: Thu Dec 26 13:24:23 2024 +0000 Squashed commit of the following: commit 294aa0a Author: Ivo Yankov <[email protected]> Date: Thu Dec 26 10:36:26 2024 +0200 chore: add build step to unit test CI Signed-off-by: Ivo Yankov <[email protected]> commit f67071c Author: Ivo Yankov <[email protected]> Date: Thu Dec 26 10:26:14 2024 +0200 fix: update mocha scripts in package.json Signed-off-by: Ivo Yankov <[email protected]> commit be6d88e Author: Ivo Yankov <[email protected]> Date: Thu Dec 26 09:54:26 2024 +0200 chore: run formatter Signed-off-by: Ivo Yankov <[email protected]> commit c0b8b16 Author: Ivo Yankov <[email protected]> Date: Thu Dec 26 09:52:14 2024 +0200 fix: various unit tests Signed-off-by: Ivo Yankov <[email protected]> commit 5a05b87 Author: Ivo Yankov <[email protected]> Date: Thu Dec 26 08:13:22 2024 +0200 fix: injections in tests Signed-off-by: Ivo Yankov <[email protected]> commit 6178ccf Merge: 24269fe c3a9691 Author: Ivo Yankov <[email protected]> Date: Tue Dec 24 15:39:32 2024 +0200 Merge remote-tracking branch 'origin/00822-implement-inversion-of-control-2' into 00822-implement-inversion-of-control-2 # Conflicts: # src/core/account_manager.ts # src/core/config/local_config.ts # src/core/config_manager.ts # src/core/lease/lease_manager.ts # src/core/profile_manager.ts # src/index.ts # test/setup.ts # test/test_container.ts # test/test_util.ts # test/unit/commands/base.test.ts # test/unit/commands/context.test.ts # test/unit/commands/network.test.ts # test/unit/core/platform_installer.test.ts # test/unit/core/profile_manager.test.ts commit c3a9691 Author: Jeromy Cannon <[email protected]> Date: Mon Dec 23 20:35:20 2024 +0000 add reflect metadata back Signed-off-by: Jeromy Cannon <[email protected]> commit dd13b95 Author: Jeromy Cannon <[email protected]> Date: Mon Dec 23 20:28:06 2024 +0000 fixed eslint errors from `npm run check` Signed-off-by: Jeromy Cannon <[email protected]> commit 6d7522c Author: Jeromy Cannon <[email protected]> Date: Mon Dec 23 20:14:08 2024 +0000 npm run format Signed-off-by: Jeromy Cannon <[email protected]> commit f323ca7 Author: Jeromy Cannon <[email protected]> Date: Mon Dec 23 19:59:26 2024 +0000 Squashed commit of the following: commit 24269fe Author: Ivo Yankov <[email protected]> Date: Fri Dec 20 11:03:26 2024 +0200 wip: attempting to fix tests Signed-off-by: Ivo Yankov <[email protected]> commit 7698f16 Author: Ivo Yankov <[email protected]> Date: Thu Dec 19 15:41:38 2024 +0200 chore: format Signed-off-by: Ivo Yankov <[email protected]> commit 507a081 Author: Ivo Yankov <[email protected]> Date: Thu Dec 19 14:53:36 2024 +0200 feat: implement IOC in core classes Signed-off-by: Ivo Yankov <[email protected]> commit c582f12 Author: Ivo Yankov <[email protected]> Date: Wed Dec 18 17:32:22 2024 +0200 wip: refactoring dependencies Signed-off-by: Ivo Yankov <[email protected]> Signed-off-by: Jeromy Cannon <[email protected]> commit 1b9b7e6 Author: Jan Milenkov <[email protected]> Date: Mon Dec 23 21:22:56 2024 +0200 feat: dynamically construct the genesis-network.json and add it to the values file to be used during network deploy (#982) Signed-off-by: Jeromy Cannon <[email protected]> Co-authored-by: Jeromy Cannon <[email protected]> commit 3c3673a Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon Dec 23 08:12:58 2024 -0600 chore(deps): bump jfrog/setup-jfrog-cli from 4.5.2 to 4.5.3 (#1015) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 299cd85 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon Dec 23 08:12:30 2024 -0600 chore(deps): bump helm/kind-action from 1.11.0 to 1.12.0 (#1014) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 1d57fb8 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon Dec 23 07:47:07 2024 -0600 chore(deps): bump chalk from 5.4.0 to 5.4.1 (#1013) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit a4e5cd8 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon Dec 23 07:26:24 2024 -0600 chore(deps): bump inquirer from 12.2.0 to 12.3.0 (#1012) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 7a69623 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Sun Dec 22 19:20:53 2024 +0000 chore(deps-dev): bump eslint-plugin-n from 17.15.0 to 17.15.1 (#1011) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 7bb0e99 Author: Jeromy Cannon <[email protected]> Date: Sun Dec 22 07:31:54 2024 +0000 fix: refactored Taskfiles, fixed bugs with taskfile, lease interval, sdk node client connection, and commands missing quiet flag (#978) Signed-off-by: Jeromy Cannon <[email protected]> commit 861c579 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Thu Dec 19 11:06:35 2024 -0600 chore(deps-dev): bump globals from 15.13.0 to 15.14.0 (#1007) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit e80bda8 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Thu Dec 19 11:06:22 2024 -0600 chore(deps): bump chalk from 5.3.0 to 5.4.0 (#1008) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit f4b49aa Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Thu Dec 19 10:47:50 2024 -0600 chore(deps): bump @hashgraph/sdk from 2.55.1 to 2.56.0 (#1009) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit c9711c5 Author: Ivo Yankov <[email protected]> Date: Thu Dec 19 18:47:03 2024 +0200 feat: update `solo context connect` to connect to single remote cluster (#993) Signed-off-by: Ivo Yankov <[email protected]> commit 043efcf Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Wed Dec 18 16:56:19 2024 -0600 chore(deps): bump actions/upload-artifact from 4.4.3 to 4.5.0 (#1002) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 8115945 Author: Pranali Deshmukh <[email protected]> Date: Thu Dec 19 00:55:58 2024 +0200 docs(README): Updated the "Install Solo" section. (#1004) Signed-off-by: Pranali Deshmukh <[email protected]> commit 01ed969 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Wed Dec 18 11:19:09 2024 -0600 chore(deps): bump actions/setup-java from 4.5.0 to 4.6.0 (#1003) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Jeromy Cannon <[email protected]> commit 24269fe Author: Ivo Yankov <[email protected]> Date: Fri Dec 20 11:03:26 2024 +0200 wip: attempting to fix tests Signed-off-by: Ivo Yankov <[email protected]> commit 7698f16 Author: Ivo Yankov <[email protected]> Date: Thu Dec 19 15:41:38 2024 +0200 chore: format Signed-off-by: Ivo Yankov <[email protected]> commit 507a081 Author: Ivo Yankov <[email protected]> Date: Thu Dec 19 14:53:36 2024 +0200 feat: implement IOC in core classes Signed-off-by: Ivo Yankov <[email protected]> commit c582f12 Author: Ivo Yankov <[email protected]> Date: Wed Dec 18 17:32:22 2024 +0200 wip: refactoring dependencies Signed-off-by: Ivo Yankov <[email protected]> Signed-off-by: Jeromy Cannon <[email protected]>

Signed-off-by: Jeromy Cannon <[email protected]>

github-actions · 2024-12-27T22:02:01Z

E2E Test Report

16 files ±0 121 suites ±0 1h 21m 19s ⏱️ + 1m 13s
258 tests ±0 258 ✅ ±0 0 💤 ±0 0 ❌ ±0
261 runs ±0 261 ✅ ±0 0 💤 ±0 0 ❌ ±0

Results for commit 7b56326. ± Comparison against base commit 813a4ab.

This pull request removes 3 and adds 3 tests. Note that renamed tests count towards both.

should fail with invalid pod ‑ E2E Test Suite for 'pkg-installer-e2e' pkg-installer-e2e PackageInstallerE2E fetchPlatform should fail with invalid pod
should fail with invalid tag ‑ E2E Test Suite for 'pkg-installer-e2e' pkg-installer-e2e PackageInstallerE2E fetchPlatform should fail with invalid tag
should succeed with valid tag and pod ‑ E2E Test Suite for 'pkg-installer-e2e' pkg-installer-e2e PackageInstallerE2E fetchPlatform should succeed with valid tag and pod

should fail with invalid pod ‑ E2E Test Suite for 'pkg-installer-e2e' pkg-installer-e2e Platform Installer E2E fetchPlatform should fail with invalid pod
should fail with invalid tag ‑ E2E Test Suite for 'pkg-installer-e2e' pkg-installer-e2e Platform Installer E2E fetchPlatform should fail with invalid tag
should succeed with valid tag and pod ‑ E2E Test Suite for 'pkg-installer-e2e' pkg-installer-e2e Platform Installer E2E fetchPlatform should succeed with valid tag and pod

github-actions · 2024-12-27T22:02:01Z

E2E Test Report

16 files ±0 121 suites ±0 1h 21m 19s ⏱️ + 1m 13s
258 tests ±0 258 ✅ ±0 0 💤 ±0 0 ❌ ±0
261 runs ±0 261 ✅ ±0 0 💤 ±0 0 ❌ ±0

Results for commit 7b56326. ± Comparison against base commit 813a4ab.

This pull request removes 3 and adds 3 tests. Note that renamed tests count towards both.

should fail with invalid pod ‑ E2E Test Suite for 'pkg-installer-e2e' pkg-installer-e2e PackageInstallerE2E fetchPlatform should fail with invalid pod
should fail with invalid tag ‑ E2E Test Suite for 'pkg-installer-e2e' pkg-installer-e2e PackageInstallerE2E fetchPlatform should fail with invalid tag
should succeed with valid tag and pod ‑ E2E Test Suite for 'pkg-installer-e2e' pkg-installer-e2e PackageInstallerE2E fetchPlatform should succeed with valid tag and pod

should fail with invalid pod ‑ E2E Test Suite for 'pkg-installer-e2e' pkg-installer-e2e Platform Installer E2E fetchPlatform should fail with invalid pod
should fail with invalid tag ‑ E2E Test Suite for 'pkg-installer-e2e' pkg-installer-e2e Platform Installer E2E fetchPlatform should fail with invalid tag
should succeed with valid tag and pod ‑ E2E Test Suite for 'pkg-installer-e2e' pkg-installer-e2e Platform Installer E2E fetchPlatform should succeed with valid tag and pod

codacy-production · 2024-12-27T22:02:17Z

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation	Diff coverage
✅ +0.09% (target: -1.00%)	✅ 96.84%

Coverage variation details

	Coverable lines	Covered lines	Coverage
Common ancestor commit (`813a4ab`)	19689	16848	85.57%
Head commit (`7b56326`)	19918 (+229)	17061 (+213)	85.66% (+0.09%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details

	Coverable lines	Covered lines	Diff coverage
Pull request (#1010)	380	368	96.84%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings Change summary preferences

_{Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more}

codecov · 2024-12-27T22:03:05Z

Codecov Report

Attention: Patch coverage is 96.31579% with 14 lines in your changes missing coverage. Please review.

Project coverage is 84.79%. Comparing base (813a4ab) to head (7b56326).
Report is 11 commits behind head on main.

Files with missing lines	Patch %	Lines
src/core/container_init.ts	94.66%	8 Missing ⚠️
src/core/container_helper.ts	91.17%	3 Missing ⚠️
src/core/dependency_managers/dependency_manager.ts	78.57%	3 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1010      +/-   ##
==========================================
+ Coverage   84.58%   84.79%   +0.21%     
==========================================
  Files          74       76       +2     
  Lines       19716    19918     +202     
  Branches     1403     1187     -216     
==========================================
+ Hits        16676    16890     +214     
+ Misses       3013     3011       -2     
+ Partials       27       17      -10

Files with missing lines	Coverage Δ
src/commands/base.ts	`95.81% <100.00%> (+0.42%)`	⬆️
src/commands/node/handlers.ts	`90.72% <ø> (-0.02%)`	⬇️
src/core/account_manager.ts	`87.01% <100.00%> (+0.28%)`	⬆️
src/core/certificate_manager.ts	`51.85% <100.00%> (+2.08%)`	⬆️
src/core/chart_manager.ts	`89.13% <100.00%> (+1.72%)`	⬆️
src/core/config/local_config.ts	`68.20% <100.00%> (+0.81%)`	⬆️
src/core/config/remote/remote_config_manager.ts	`81.25% <100.00%> (+0.50%)`	⬆️
src/core/config_manager.ts	`94.53% <100.00%> (+0.61%)`	⬆️
...ore/dependency_managers/helm_dependency_manager.ts	`73.68% <100.00%> (+2.82%)`	⬆️
src/core/helm.ts	`98.11% <100.00%> (+0.86%)`	⬆️
... and 13 more

... and 8 files with indirect coverage changes

Ivo-Yankov

LGTM, but I can't approve it since the PR is opened by me

## [0.32.0](v0.31.1...v0.32.0) (2024-12-31) ### ⚠ BREAKING CHANGES * update readme with warning about BREAKING CHANGE in this next release (#730) ### Features * add ci test flow to test task command to launch solo ([#811](#811)) ([356f341](356f341)) * add example for using javascript SDK ([#832](#832)) ([1d9452e](1d9452e)) * add extended math utils and duration support ([#923](#923)) ([f5a69e7](f5a69e7)) * add separate commands for update ([#735](#735)) ([44c3132](44c3132)) * add solo smoke test to test flow ([#905](#905)) ([79410f0](79410f0)) * add support for flexible lease acquisition and production readiness ([#830](#830)) ([7fa86ad](7fa86ad)) * Add the ability to inject a ca certificate for use in gRPC and gRPC Web ([#753](#753)) ([2cd8a38](2cd8a38)) * add timeout flag to network destroy command ([#821](#821)) ([0fb570b](0fb570b)) * allow settings a reserved static IP address for the consensus nodes HAProxy and Envoy Proxy though the cli with flags ([#937](#937)) ([de9ec2e](de9ec2e)) * change mirror node and explorer from subchart to individual chart ([#743](#743)) ([58f0496](58f0496)) * Create a local config for storing configurations on the users machine ([#803](#803)) ([0a4382d](0a4382d)) * Create remote config ([#862](#862)) ([e8fe739](e8fe739)) * dynamically construct the genesis-network.json and add it to the values file to be used during network deploy ([#982](#982)) ([1b9b7e6](1b9b7e6)) * expose pod check attempts and delays as environment controlled variables ([#812](#812)) ([a7b3279](a7b3279)) * Implement IOC ([#1010](#1010)) ([ed23a7b](ed23a7b)) * Implement solo context connect ([#863](#863)) ([782b3ec](782b3ec)) * Increase helm chart version and switch to use oci registry ([#788](#788)) ([1973275](1973275)) * **k8s:** introduce Kubernetes lease lock mechanism ([#707](#707)) ([f1b8089](f1b8089)) * new command to save state files and upload state files ([#849](#849)) ([d5a9a18](d5a9a18)) * removed caching of ConfigManager and its flags ([#713](#713)) ([76a61e3](76a61e3)) * Setup mirror node monitor pinger service ([#893](#893)) ([f4c4320](f4c4320)) * update `solo context connect` to connect to single remote cluster ([#993](#993)) ([c9711c5](c9711c5)) * Update document ([#956](#956)) ([b378937](b378937)) * update readme and hugo workflow ([#930](#930)) ([0e08abc](0e08abc)) * Validate a remote config ([#922](#922)) ([a7bbae0](a7bbae0)) ### Bug Fixes * add delay before calling script ([#955](#955)) ([76f4b81](76f4b81)) * allow expired leases to be overwritten ([#828](#828)) ([1fa1d78](1fa1d78)) * bump chart and hedera version, re-enable node add ([#985](#985)) ([9cae011](9cae011)) * check if setup chart installed or not before network deploy ([#799](#799)) ([6930dab](6930dab)) * document typo ([#988](#988)) ([8e4fe04](8e4fe04)) * Error in `node update` separate commands when new admin key is not supplied ([#854](#854)) ([6e472b5](6e472b5)) * Examples of performance configs for HashSphere and Latitude ([#926](#926)) ([#957](#957)) ([928148b](928148b)) * fix missing file issues when running solo from npm install -g ([#736](#736)) ([2a5cfc1](2a5cfc1)) * fixed genesis-network.json file lock issue ([#1074](#1074)) ([e590516](e590516)) * flag check of node logs command and incorrect download source ([#848](#848)) ([03051f0](03051f0)) * inconsistent failures ([#866](#866)) ([13ea46d](13ea46d)) * local chart directory not being taken correctly ([#983](#983)) ([58e96e1](58e96e1)) * nextNode ID for release version > 0.56.0 ([#765](#765)) ([3b98dd6](3b98dd6)) * node id should start from `1` ([#884](#884)) ([d90c9b5](d90c9b5)) * node update with single node ([#981](#981)) ([74285bf](74285bf)) * patch issue with dist folder not showing up ([#733](#733)) ([077f989](077f989)) * performance improvements for node stop ([#986](#986)) ([437bbc6](437bbc6)) * refactored Taskfiles, fixed bugs with taskfile, lease interval, sdk node client connection, and commands missing quiet flag ([#978](#978)) ([7bb0e99](7bb0e99)) * remote config validation not working ([#967](#967)) ([88c2506](88c2506)) * resolve node update test failures ([#856](#856)) ([5e1c652](5e1c652)) * Revised example configs for Latitude deployment, automation friendly ([#1038](#1038)) ([434daf3](434daf3)) * undefined log output of namespace ([#764](#764)) ([ac15957](ac15957)) ### Documentation * update readme with warning about BREAKING CHANGE in this next release ([#730](#730)) ([06295f6](06295f6))

swirlds-automation · 2024-12-31T21:26:14Z

🎉 This PR is included in version 0.32.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Ivo-Yankov self-assigned this Dec 20, 2024

jeromy-cannon force-pushed the 00822-implement-inversion-of-control-2 branch from 24269fe to dd13b95 Compare December 23, 2024 20:28

jeromy-cannon force-pushed the 00822-implement-inversion-of-control-2 branch 2 times, most recently from 04e69ea to 7d988e3 Compare December 26, 2024 13:48

jeromy-cannon added 24 commits December 27, 2024 20:17

pushing current changes

956061e

Signed-off-by: Jeromy Cannon <[email protected]>

reverted back to using tsx and not compiled *.ts files.

2779fdd

Signed-off-by: Jeromy Cannon <[email protected]>

patched inject bug in tsyringe-neo

305fa35

Signed-off-by: Jeromy Cannon <[email protected]>

reverted workflow change

984dc0b

Signed-off-by: Jeromy Cannon <[email protected]>

removed commented out code

08fe24f

Signed-off-by: Jeromy Cannon <[email protected]>

revert a change to make PR easier to review

75a2b3f

Signed-off-by: Jeromy Cannon <[email protected]>

added missing changes

2cb2284

Signed-off-by: Jeromy Cannon <[email protected]>

fix errors

9c36fc1

Signed-off-by: Jeromy Cannon <[email protected]>

updated helm to be singleton

832e405

Signed-off-by: Jeromy Cannon <[email protected]>

removed k8 clone method

e3b12fc

Signed-off-by: Jeromy Cannon <[email protected]>

added local config inject

297eebe

Signed-off-by: Jeromy Cannon <[email protected]>

removed commented out code

4f25712

Signed-off-by: Jeromy Cannon <[email protected]>

removed commented out code

32fe8cf

Signed-off-by: Jeromy Cannon <[email protected]>

reverted directory change in cluster setup test

1d74a25

Signed-off-by: Jeromy Cannon <[email protected]>

removed dead code

e1a9851

Signed-off-by: Jeromy Cannon <[email protected]>

removed circular dependencies

09367d6

Signed-off-by: Jeromy Cannon <[email protected]>

removed circular dependencies

503fee9

Signed-off-by: Jeromy Cannon <[email protected]>

removed warnings

32fe757

Signed-off-by: Jeromy Cannon <[email protected]>

fix test case network.test.ts

f948ab2

Signed-off-by: Jeromy Cannon <[email protected]>

fix test case config_manager.test.ts

ee5c04a

Signed-off-by: Jeromy Cannon <[email protected]>

fixed test cases

6e715ff

Signed-off-by: Jeromy Cannon <[email protected]>

fixed network test and got annotations working

0e89599

Signed-off-by: Jeromy Cannon <[email protected]>

fixed singleton issue

ac06d2d

Signed-off-by: Jeromy Cannon <[email protected]>

jeromy-cannon added 2 commits December 27, 2024 20:19

removed console logs

b52ae20

Signed-off-by: Jeromy Cannon <[email protected]>

prep for PR

3434f71

Signed-off-by: Jeromy Cannon <[email protected]>

jeromy-cannon force-pushed the 00822-implement-inversion-of-control-2 branch from 38a51d1 to 3434f71 Compare December 27, 2024 20:19

jeromy-cannon added 2 commits December 27, 2024 21:07

fixed test case issues

cb26a5c

Signed-off-by: Jeromy Cannon <[email protected]>

reverted test_util.ts changes to fix test cases

7b56326

Signed-off-by: Jeromy Cannon <[email protected]>

jeromy-cannon marked this pull request as ready for review December 27, 2024 22:01

jeromy-cannon requested review from a team and leninmehedy as code owners December 27, 2024 22:01

jeromy-cannon requested review from nathanklick, JeffreyDallas and instamenta December 27, 2024 22:02

jeromy-cannon approved these changes Dec 27, 2024

View reviewed changes

jeromy-cannon self-assigned this Dec 27, 2024

Ivo-Yankov commented Dec 29, 2024

View reviewed changes

jeromy-cannon merged commit ed23a7b into main Dec 30, 2024
43 of 44 checks passed

jeromy-cannon deleted the 00822-implement-inversion-of-control-2 branch December 30, 2024 12:21

swirlds-automation added the released label Dec 31, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Implement IOC #1010

feat: Implement IOC #1010

Ivo-Yankov commented Dec 20, 2024 •

edited by jeromy-cannon

Loading

github-actions bot commented Dec 23, 2024 •

edited

Loading

github-actions bot commented Dec 23, 2024 •

edited

Loading

github-actions bot commented Dec 27, 2024

github-actions bot commented Dec 27, 2024

codacy-production bot commented Dec 27, 2024

codecov bot commented Dec 27, 2024 •

edited

Loading

Ivo-Yankov left a comment •

edited

Loading

swirlds-automation commented Dec 31, 2024

feat: Implement IOC #1010

feat: Implement IOC #1010

Conversation

Ivo-Yankov commented Dec 20, 2024 • edited by jeromy-cannon Loading

Description

Related Issues

github-actions bot commented Dec 23, 2024 • edited Loading

Unit Test Results - Linux

github-actions bot commented Dec 23, 2024 • edited Loading

Unit Test Results - Windows

github-actions bot commented Dec 27, 2024

E2E Test Report

github-actions bot commented Dec 27, 2024

E2E Test Report

codacy-production bot commented Dec 27, 2024

Coverage summary from Codacy

See diff coverage on Codacy

See your quality gate settings Change summary preferences

codecov bot commented Dec 27, 2024 • edited Loading

Codecov Report

Ivo-Yankov left a comment • edited Loading

Choose a reason for hiding this comment

swirlds-automation commented Dec 31, 2024

Ivo-Yankov commented Dec 20, 2024 •

edited by jeromy-cannon

Loading

github-actions bot commented Dec 23, 2024 •

edited

Loading

github-actions bot commented Dec 23, 2024 •

edited

Loading

codecov bot commented Dec 27, 2024 •

edited

Loading

Ivo-Yankov left a comment •

edited

Loading