Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Inversion of Control (IoC) container #37

Closed
Tracked by #48
leninmehedy opened this issue Dec 11, 2023 · 4 comments · Fixed by #1010
Closed
Tracked by #48

Use Inversion of Control (IoC) container #37

leninmehedy opened this issue Dec 11, 2023 · 4 comments · Fixed by #1010
Assignees
@jeromy-cannon
Labels
Needs Refinement The issue needs more refinement and/or design before it can be worked P0 An issue impacting production environments or impacting multiple releases or multiple individuals. released

Comments

@leninmehedy
Copy link
Member

leninmehedy commented Dec 11, 2023 •
edited by jeromy-cannon
Loading

Use one of:

Need to do evaluation on the available frameworks.
@leninmehedy leninmehedy mentioned this issue Dec 11, 2023
Closed
@leninmehedy leninmehedy self-assigned this Dec 11, 2023
@nathanklick nathanklick transferred this issue from hashgraph/full-stack-testing Feb 20, 2024
@nathanklick nathanklick changed the title CLI: use Inversion of Control (IoC) container Use Inversion of Control (IoC) container Feb 20, 2024
@nathanklick nathanklick removed this from FST Suite Feb 20, 2024
@nathanklick nathanklick added this to Solo Feb 20, 2024
@github-project-automation github-project-automation bot moved this to 🆕 New in Solo Feb 20, 2024
@nathanklick nathanklick mentioned this issue Feb 20, 2024
Open
@leninmehedy leninmehedy added the Feature Enhancement Enhancing an existing feature driven by business requirements. Typically backwards compatible. label Feb 21, 2024
@leninmehedy leninmehedy moved this from 🆕 New to 📋 Backlog in Solo Mar 13, 2024
@jeromy-cannon jeromy-cannon added the P3 Low priority issue. Will not impact the release schedule if not complete. label May 31, 2024
@jeromy-cannon jeromy-cannon added Pending Triage New issue that needs to be triaged by the team and removed P3 Low priority issue. Will not impact the release schedule if not complete. labels Sep 3, 2024
@jeromy-cannon jeromy-cannon added Needs Refinement The issue needs more refinement and/or design before it can be worked and removed Pending Triage New issue that needs to be triaged by the team Feature Enhancement Enhancing an existing feature driven by business requirements. Typically backwards compatible. labels Sep 17, 2024
@jeromy-cannon jeromy-cannon self-assigned this Sep 17, 2024
@instamenta
Copy link
Contributor

instamenta commented Sep 26, 2024 •
edited
Loading

@jeromy-cannon

During my research, I found that the only library truly designed to support Vanilla JS is Awilix, because:

  • It's the only one that's actively maintained.
  • It was specifically built for Vanilla JS.

Given this, I’m wondering if we should consider migrating to TypeScript. Doing so will address the current issue with Inversion of Control (IoC), improve the developer experience (DevEx), and possibly attract more outside contributions. Additionally, this change will make the codebase more maintainable for the future and reveal current bugs that haven't been found yet.

IoC for TypeScript:

@jeromy-cannon
Copy link
Contributor

@jeromy-cannon

During my research, I found that the only library truly designed to support Vanilla JS is Awilix, because:

  • It's the only one that's actively maintained.
  • It was specifically built for Vanilla JS.

Given this, I’m wondering if we should consider migrating to TypeScript. Doing so will address the current issue with Inversion of Control (IoC), improve the developer experience (DevEx), and possibly attract more outside contributions. Additionally, this change will make the codebase more maintainable for the future and reveal current bugs that haven't been found yet.

IoC for TypeScript:

@instamenta , I discussed this with @nathanklick , but we are not ready to move to TypeScript. We don't want to add the extra compiler layer. There is an upcoming version of NodeJS that allows TypeScript integration directly into NodeJS, however it is still early development and we want to keep our user base on the LTS version. So, at this point if there are no other options to consider, then we can move forward with Awilix

@jeromy-cannon jeromy-cannon moved this from 📋 Backlog to 🔖 Ready in Solo Oct 1, 2024
@jeromy-cannon jeromy-cannon added the P0 An issue impacting production environments or impacting multiple releases or multiple individuals. label Oct 24, 2024
@jeromy-cannon
Copy link
Contributor

being implemented in #590

@github-project-automation github-project-automation bot moved this from 🔖 Ready to ✅ Done in Solo Oct 31, 2024
@jeromy-cannon jeromy-cannon mentioned this issue Dec 27, 2024
Merged
@swirlds-automation
Copy link
Contributor

🎉 This issue has been resolved in version 0.32.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jeromy-cannon jeromy-cannon

Labels
Needs Refinement The issue needs more refinement and/or design before it can be worked P0 An issue impacting production environments or impacting multiple releases or multiple individuals. released
Projects
Solo
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Implement IOC hashgraph/solo
4 participants
@leninmehedy @jeromy-cannon @swirlds-automation @instamenta