fix: OperatorSelector inconsistencies, operator filter bugs #522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- remove redundant type explicitness - replace `operator_whitelist` with `MAJOR_OPERATORS` (single source of truth) - if an operator is selected, filter for it instead - move responsibility of filtering `MAJOR_OPERATORS` from `LineHbarChart` to `WorstLinesChart` (since it already filters for operatorId) - unify filtering (filter everywhere by id) - add `operator_whitelist` value as a comment to `MAJOR_OPERATORS`
|
Thanks! I'll dive into it tomorrow 🙏 |
NoamGaash
reviewed
Mar 1, 2024
| const response = await fetch(`${BASE_PATH}/gtfs_agencies/list`) | ||
| json = await response.json() | ||
| const data = (await response.json()) as Awaited<Agency[]> |
There was a problem hiding this comment.
Suggested change
| const data = (await response.json()) as Awaited<Agency[]> | |
| const data = (await response.json()) as Agency[] |
NoamGaash
approved these changes
Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#401
Description
Consistency delivered, some old code was adjusted and logic simplified.
@NoamGaash Please have a look if things look fine, ready to merge!
Result
Screen.Recording.2024-02-24.at.13.19.13.mov