חברה מפעילה input inconsistency

[Haswell-s]

The fact that items are pre-selected creates inconsistensies between pages and does not reflect the db.
I would suggest to chnage the behavior of the component to fetch the db instead.

To make it faster I would say to cache the data from the landing page (קיום נסיעות) charts and use them as the options, but this is out of the scope of this issue.

[Haswell-s]

I want to discuss possible solutions, should I do it here or on slack?
After clarification you can assign me to this one!

[NoamGaash]

@i5x64BIT could you please clarify and provide example for inconsistencies / false information?
This is the perfect place for discussing possible solutions for this issue

[Haswell-s]

@NoamGaash
So I found out that this issue is because instead of showing all the operators, we show only the major and pass the filtered as the options to Autocomplete:

// OperatorSelector

        setOperators(
          filter == FilterOperatorOptions.MAJOR && resultObj
            ? resultObj.filter((item) => majorOperatorsIds.includes(item.id))
            : resultObj,
        ),

// OperatorSelector

  return (
    <Autocomplete
      disablePortal
      style={{ width: '100%' }}
      value={value}
      onChange={(e, value) => setOperatorId(value ? value.id : '')}
      id="operator-select"
      options={operators}
      renderInput={(params) => <TextField {...params} label={t('choose_operator')} />}
      getOptionLabel={(option) => option.name}
    />
  )

So I figured that changing the OperatorSelector's attribute from FilterOperatorOptions.MAJOR to ALL should've fixed it.

// Dashboard

          <OperatorSelector
            operatorId={operatorId}
            setOperatorId={setOperatorId}
            filter={FilterOperatorOptions.MAJOR} // Changing from MAJOR to ALL should've fixed it
          />

but turns out that this filtering mechanic is buggy by itself.

After changing to ALL:

Screen.Recording.2024-02-07.at.22.30.50.mov

So to start off I would say my solution to the inconsistency would be to remove the filtering from OperatorSelector, display all operators and let autocomplete do the job.

Secondly displaying all the operators clearly needs some work so there is that.

[Haswell-s]

BTW the data for OperatorSelector is beign pulled from the API, so all the inconsistencies arrise from the filtering.
In my opinion having the exact same input field display different ammounts of data over the app is not a good UX, displaying all the options and scrolling through them is much better in my opinion.

[Haswell-s]

Screen.Recording.2024-02-24.at.11.31.41.mov

A followup on this issue is some wierdness with WorstLinesChart, where operators that aren't included in RELEVENT are not displayed properly.

[NoamGaash]

@all-contributors please add @Haswell-s for code

[allcontributors]

@NoamGaash

I've put up a pull request to add @Haswell-s! 🎉