Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: OperatorSelector inconsistencies, operator filter bugs #522

Merged
merged 4 commits into from
Mar 9, 2024
Merged

fix: OperatorSelector inconsistencies, operator filter bugs #522

merged 4 commits into from
Mar 9, 2024

Commits on Feb 24, 2024

  1. refactor: simplify OperatorSelector, operator and agencyList logic

    @Haswell-s
    Haswell-s committed Feb 24, 2024
    Configuration menu
    Copy the full SHA
    c236ab0 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin' into operator-selector-filter

    @Haswell-s
    Haswell-s committed Feb 24, 2024
    Configuration menu
    Copy the full SHA
    8563de1 View commit details
    Browse the repository at this point in the history

  3. refactor: simplify WorstLinesChart and support new operator logic 

    - remove redundant type explicitness
- replace `operator_whitelist` with `MAJOR_OPERATORS` (single source of truth)
- if an operator is selected, filter for it instead
- move responsibility of filtering `MAJOR_OPERATORS` from `LineHbarChart` to `WorstLinesChart` (since it already filters for operatorId)
- unify filtering (filter everywhere by id)
- add `operator_whitelist` value as a comment to `MAJOR_OPERATORS`
    @Haswell-s
    Haswell-s committed Feb 24, 2024
    Configuration menu
    Copy the full SHA
    84e3a81 View commit details
    Browse the repository at this point in the history

  4. fix build

    @Haswell-s
    Haswell-s committed Feb 24, 2024
    Configuration menu
    Copy the full SHA
    ebdd2b2 View commit details
    Browse the repository at this point in the history