Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use image instead of card-image-src #4353

Conversation

drakenguyen4000
Copy link
Member

Fixes #4159

What changes did you make and why did you make them ?

Changes made:
Remove the card-image-src: and card-image-alt: fields and the content of each of those fields in the following files:

  • _projects/311-data.md
  • _projects/access-the-data.md
  • _projects/engage.md
  • _projects/lucky-parking.md
  • _projects/open-community-survey.md

In _includes/program-area-pages-cards.html, do the following:

  • change
    <img class="card-image" src="{{ item.card-image-src }}" alt="{{ item.card-image-alt }}"/>
    
    to
    <img class="card-image" src="{{ item.image }}" alt="">
    
  • In the if statement, remove the line:
    item.card-image-src.size > 0 and
    

Why:

  • The image and card-image-src fields both have the path to the project's logo image. Since this information is the same, we don't need both fields. So, we will be removing the card-image-src fields from the Markdown files in _projects directory.

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

  • Removed card-image-src and card-image-alt. No visual changes to the website.

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b drakenguyen4000-use-image-instead-of-card-image-src-4159 gh-pages
git pull https://github.com/drakenguyen4000/website.git use-image-instead-of-card-image-src-4159

@github-actions github-actions bot added role: front end Tasks for front end developers Feature: Refactor JS / Liquid Page is working fine - JS / Liquid needs changes to become consistent with other pages Complexity: Small Take this type of issues after the successful merge of your second good first issue P-Feature: Citizen Engagement https://www.hackforla.org/citizen-engagement size: 0.25pt Can be done in 0.5 to 1.5 hours labels Mar 31, 2023
@mjshelton12 mjshelton12 self-requested a review March 31, 2023 19:33
@mjshelton12
Copy link
Member

Review Availability: Friday 3/31/23 5:30-7:30
Review ETA: EOD 3/31/23

Copy link
Member

@mjshelton12 mjshelton12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work on this one! First, the basics were done perfectly: Branches are good, issue is linked, and you gave really excellent information in the change explanation that made it easy to understand what you did.

The code is effectively changed and viewing it in docker (desktop, tablet, and phone) shows that it didn't unexpectedly change anything.

Great job, very thoroughly done!

@t-will-gillis t-will-gillis self-requested a review April 3, 2023 02:42
Copy link
Member

@t-will-gillis t-will-gillis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @drakenguyen4000 - Great job! Branches are correct, the issue is linked, the description provided good info about what you did. I checked in Docker and it appears everything works correctly.

Thanks and great job again

@t-will-gillis t-will-gillis merged commit d2aabd1 into hackforla:gh-pages Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Small Take this type of issues after the successful merge of your second good first issue Feature: Refactor JS / Liquid Page is working fine - JS / Liquid needs changes to become consistent with other pages P-Feature: Citizen Engagement https://www.hackforla.org/citizen-engagement role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Citizen Engagement page: Use image instead of card-image-src
3 participants