Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Citizen Engagement page: Use image instead of card-image-src #4159

Closed
11 of 12 tasks
Tracked by #4153 ...
JessicaLucindaCheng opened this issue Mar 13, 2023 · 6 comments · Fixed by #4353
Closed
11 of 12 tasks
Tracked by #4153 ...

Citizen Engagement page: Use image instead of card-image-src #4159

JessicaLucindaCheng opened this issue Mar 13, 2023 · 6 comments · Fixed by #4353
Assignees
Labels
Complexity: Small Take this type of issues after the successful merge of your second good first issue Feature: Refactor JS / Liquid Page is working fine - JS / Liquid needs changes to become consistent with other pages P-Feature: Citizen Engagement https://www.hackforla.org/citizen-engagement role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours
Milestone

Comments

@JessicaLucindaCheng
Copy link
Member

JessicaLucindaCheng commented Mar 13, 2023

Dependency

Overview

We need to refactor the code on the Citizen Engagement page to use image instead of card-image-src so that we aren't duplicating information.

Details

  • The image and card-image-src are fields in the project's Markdown files in _project directory. (Note: Not all of the project Markdown files have card-image-src yet.)
  • The image and card-image-src fields both have the path to the project's logo image. Since this information is the same, we don't need both fields. So, we will be removing the card-image-src fields from the Markdown files in _projects directory.
  • Also, the alt text for each project logo on the Citizen Engagement page is empty (meaning alt="") because the project name is displayed next to the logo. So, we will be removing the card-image-alt fields from the Markdown files in _projects directory.

Action Items

  • In _includes/program-area-pages-cards.html, do the following:
    • change
      <img class="card-image" src="{{ item.card-image-src }}" alt="{{ item.card-image-alt }}"/>
      
      to
      <img class="card-image" src="{{ item.image }}" alt="">
      
    • In the if statement, remove the line:
      item.card-image-src.size > 0 and
      
  • Remove the card-image-src: and card-image-alt: fields and the content of each of those fields in the following files:
    • _projects/311-data.md
    • _projects/access-the-data.md
    • _projects/engage.md
    • _projects/lucky-parking.md
    • _projects/open-community-survey.md
  • Using the search function in VS Code or IDE, search for card-image-src and card-image-alt. If you find any files with that, update the code in those files accordingly.
  • Using Docker, check the Citizen Engagement page looks good in mobile, tablet, and desktop views.

Merge Team, Technical Lead, or Product Manager

Resources/Instructions

@JessicaLucindaCheng JessicaLucindaCheng added role: front end Tasks for front end developers Complexity: Good second issue Feature: Refactor JS / Liquid Page is working fine - JS / Liquid needs changes to become consistent with other pages P-Feature: Citizen Engagement https://www.hackforla.org/citizen-engagement Draft Issue is still in the process of being created size: 0.25pt Can be done in 0.5 to 1.5 hours labels Mar 13, 2023
@ExperimentsInHonesty ExperimentsInHonesty added this to the 05. Know HFLA milestone Mar 16, 2023
@JessicaLucindaCheng JessicaLucindaCheng added Complexity: Small Take this type of issues after the successful merge of your second good first issue and removed Complexity: Good second issue labels Mar 19, 2023
@JessicaLucindaCheng JessicaLucindaCheng changed the title Citizen Engagement: Use image instead of card-image-src Citizen Engagement page: Use image instead of card-image-src Mar 19, 2023
@JessicaLucindaCheng JessicaLucindaCheng added Dependency An issue is blocking the completion or starting of another issue and removed Draft Issue is still in the process of being created labels Mar 19, 2023
@JessicaLucindaCheng

This comment was marked as resolved.

@t-will-gillis t-will-gillis added ready for dev lead Issues that tech leads or merge team members need to follow up on and removed Dependency An issue is blocking the completion or starting of another issue labels Mar 20, 2023
@JessicaLucindaCheng JessicaLucindaCheng added Ready for Prioritization and removed ready for dev lead Issues that tech leads or merge team members need to follow up on labels Mar 20, 2023
@Adaakal Adaakal self-assigned this Mar 24, 2023
@github-actions
Copy link

Hi @Adaakal, thank you for taking up this issue! Hfla appreciates you :)

Do let fellow developers know about your:-
i. Availability: (When are you available to work on the issue/answer questions other programmers might have about your issue?)
ii. ETA: (When do you expect this issue to be completed?)

You're awesome!

P.S. - You may not take up another issue until this issue gets merged (or closed). Thanks again :)

@ExperimentsInHonesty
Copy link
Member

@Adaakal, if you want to keep this issue, you need to move it to in progress column and give your
i. Availability: (When are you available to work on the issue/answer questions other programmers might have about your issue?)
ii. ETA: (When do you expect this issue to be completed?)

@ExperimentsInHonesty
Copy link
Member

@Adaakal I am unassigning you from this issue because you have already done a small issue. I will let you know as soon as there is a medium size issue for you to do. You are at the top of the list.

@github-actions
Copy link

Hi @drakenguyen4000, thank you for taking up this issue! Hfla appreciates you :)

Do let fellow developers know about your:-
i. Availability: (When are you available to work on the issue/answer questions other programmers might have about your issue?)
ii. ETA: (When do you expect this issue to be completed?)

You're awesome!

P.S. - You may not take up another issue until this issue gets merged (or closed). Thanks again :)

@drakenguyen4000
Copy link
Member

drakenguyen4000 commented Mar 29, 2023

i. Availability: M-F 6-9pm
ii. ETA: 3/30/23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Small Take this type of issues after the successful merge of your second good first issue Feature: Refactor JS / Liquid Page is working fine - JS / Liquid needs changes to become consistent with other pages P-Feature: Citizen Engagement https://www.hackforla.org/citizen-engagement role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours
Projects
Development

Successfully merging a pull request may close this issue.

5 participants