Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename citizen-engagement-cards.html #3756

Closed
11 tasks done
Tracked by #3328
JessicaLucindaCheng opened this issue Nov 30, 2022 · 6 comments · Fixed by #4205
Closed
11 tasks done
Tracked by #3328

Rename citizen-engagement-cards.html #3756

JessicaLucindaCheng opened this issue Nov 30, 2022 · 6 comments · Fixed by #4205
Assignees
Labels
Complexity: Small Take this type of issues after the successful merge of your second good first issue P-Feature: Citizen Engagement https://www.hackforla.org/citizen-engagement role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours Status: Updated No blockers and update is ready for review
Milestone

Comments

@JessicaLucindaCheng
Copy link
Member

JessicaLucindaCheng commented Nov 30, 2022

Dependency

Overview

We are going to rename the citizen-engagement-cards.html to program-area-pages-cards.html so that the name of the file reflects the purpose of the card better.

Details

The cards will be used in the future on more than just the Citizen Engagement webpage [see Resources/Instructions 1]. The card will be used for future program area pages, such as an Environment webpage and a Social Safety Net webpage.

Action Items

Developer

  • In your IDE on your computer, navigate to the _includes directory and find citizen-engagement-cards.html
    • Rename citizen-engagement-cards.html to program-area-pages-cards.html
    • In the file, add this comment at the top
      <!-- These are the cards found on a program area page, such as the cards on https://www.hackforla.org/citizen-engagement webpage. -->
      
  • In pages/citizen-engagement.html, change
{% include citizen-engagement-cards.html %}

to

{% include program-area-pages-cards.html %}
  • Using Docker and developer tools, check your changes
    • look good in desktop, tablet, and mobile views,
    • that nothing breaks, and
    • it still functions and looks the same as the Citizen Engagement page on the live website
  • Once your pull request has been merged,
    • In the Citizen Engagement page wiki page [see Resources/Instructions 4], change the following line from:
        * [_includes/citizen-engagement-cards.html](https://github.com/hackforla/website/blob/gh-pages/_includes/citizen-engagement-cards.html): HTML file that provides the layout/format for each card on the Citizen Engagement page
      
      to
        * [_includes/program-area-pages-cards.html](https://github.com/hackforla/website/blob/gh-pages/_includes/program-area-pages-cards.html): HTML file that provides the layout/format for each card on the Citizen Engagement page
          * This file used to be called `citizen-engagement-cards.html`.
      

Merge Team, Technical Lead, or Product Manager

Resources/Instructions

  1. Citizen Engagement webpage
  2. _includes/citizen-engagement-cards.html
  3. pages/citizen-engagement.html
  4. Citizen Engagement page wiki page
@JessicaLucindaCheng JessicaLucindaCheng added role: front end Tasks for front end developers Complexity: Small Take this type of issues after the successful merge of your second good first issue P-Feature: Citizen Engagement https://www.hackforla.org/citizen-engagement size: 0.25pt Can be done in 0.5 to 1.5 hours Draft Issue is still in the process of being created labels Nov 30, 2022
@github-actions github-actions bot removed the Draft Issue is still in the process of being created label Nov 30, 2022
@JessicaLucindaCheng

This comment was marked as outdated.

@JessicaLucindaCheng

This comment was marked as resolved.

@JessicaLucindaCheng

This comment was marked as outdated.

@JessicaLucindaCheng JessicaLucindaCheng added ready for dev lead Issues that tech leads or merge team members need to follow up on and removed Dependency An issue is blocking the completion or starting of another issue labels Mar 7, 2023
@jdingeman jdingeman added Ready for Prioritization and removed ready for dev lead Issues that tech leads or merge team members need to follow up on labels Mar 9, 2023
@jdingeman

This comment was marked as resolved.

@github-actions
Copy link

Hi @arcan9, thank you for taking up this issue! Hfla appreciates you :)

Do let fellow developers know about your:-
i. Availability: (When are you available to work on the issue/answer questions other programmers might have about your issue?)
ii. ETA: (When do you expect this issue to be completed?)

You're awesome!

P.S. - You may not take up another issue until this issue gets merged (or closed). Thanks again :)

@arcan9
Copy link
Member

arcan9 commented Mar 15, 2023

Availability: 03/15 - 03/17 after 7pm PST
ETA: 03/17 evening

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Small Take this type of issues after the successful merge of your second good first issue P-Feature: Citizen Engagement https://www.hackforla.org/citizen-engagement role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours Status: Updated No blockers and update is ready for review
Projects
Development

Successfully merging a pull request may close this issue.

4 participants