Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Citizen Engagement page: Display a message if missing program area detailed info #3757

Closed
10 of 11 tasks
Tracked by #3328
JessicaLucindaCheng opened this issue Nov 30, 2022 · 14 comments · Fixed by #4056
Closed
10 of 11 tasks
Tracked by #3328
Assignees
Labels
Complexity: Medium P-Feature: Citizen Engagement https://www.hackforla.org/citizen-engagement role: front end Tasks for front end developers size: 1pt Can be done in 4-6 hours Status: Updated No blockers and update is ready for review

Comments

@JessicaLucindaCheng
Copy link
Member

JessicaLucindaCheng commented Nov 30, 2022

Overview

On the Citizen Engagement webpage [1], we want to display a message on a project's program area card if the project is missing program area detailed information so

  • we make sure the page doesn't break and
  • we maintain a professional-looking website.

Action Items

Developer

  • Read Citizen Engagement wiki page [2]
  • If a project's Markdown file is missing one of the following program area detailed information fields: problem, solution, impact, sdg, card-image-src, sdg-image-src, then change the code in _includes/citizen-engagement-cards.html [3] so that the card on the Citizen Engagement webpage should show the project's name and dynamically display the message:
    We are currently drafting the Problem, Solution and Impact statements for this project.
    
    • Make sure the message is displayed for any future projects that are added and are missing program area info.
      • Keep in mind missing program area info can mean problem, solution, impact, sdg, card-image-src, or sdg-image-src fields
        • a) are not in a project's Markdown file at all
          OR
        • b) the fields exist but are left blank in a project's Markdown file.
    • To style the message, use existing SCSS classes when possible, such as for Typography. See Design System in Figma [4] for more info
      • If you need to add SCSS code, add it to _sass/components/_citizen_engagement.scss [5]
    • Using developer tools, make sure the message looks good in desktop, tablet, and mobile views
  • For testing your code and getting approval from the Stakeholder Rep,
    • In adopt-civic-art.md [6] and curbmap.md [7] in the _projects directory, you can temporarily change visible: false to visible: true in order to see what the card will look like with the message.
    • Show how the message looks on the card to the Stakeholder Rep and get the Stakeholder Rep's approval.
      • See the Website Team's project information page [8] for who the Stakeholder Rep is.
    • Before opening a pull request, please make sure to change visible: true back to visible: false in adopt-civic-art.md and curbmap.md so that the curbmap and ArtWatcher projects are not visible.

Merge Team, Technical Lead, or Product Manager

Resources/Instructions

@JessicaLucindaCheng JessicaLucindaCheng added role: front end Tasks for front end developers Complexity: Medium P-Feature: Citizen Engagement https://www.hackforla.org/citizen-engagement size: 1pt Can be done in 4-6 hours Draft Issue is still in the process of being created labels Nov 30, 2022
@github-actions github-actions bot removed the Draft Issue is still in the process of being created label Nov 30, 2022
@JessicaLucindaCheng JessicaLucindaCheng added the Draft Issue is still in the process of being created label Nov 30, 2022
@JessicaLucindaCheng

This comment was marked as outdated.

@JessicaLucindaCheng JessicaLucindaCheng changed the title Citizen Engagement page: Display in progress message if missing program area info Citizen Engagement page: Display a message if missing program area info Dec 3, 2022
@JessicaLucindaCheng

This comment was marked as outdated.

@JessicaLucindaCheng

This comment was marked as resolved.

@JessicaLucindaCheng JessicaLucindaCheng changed the title Citizen Engagement page: Display a message if missing program area info Citizen Engagement page: Display a message if missing program area detailed info Jan 16, 2023
@JessicaLucindaCheng JessicaLucindaCheng added Ready for Prioritization and removed Draft Issue is still in the process of being created labels Jan 16, 2023
@Jaretzbalba Jaretzbalba self-assigned this Jan 18, 2023
@github-actions
Copy link

Hi @Jaretzbalba, thank you for taking up this issue! Hfla appreciates you :)

Do let fellow developers know about your:-
i. Availability: (When are you available to work on the issue/answer questions other programmers might have about your issue?)
ii. ETA: (When do you expect this issue to be completed?)

You're awesome!

P.S. - You may not take up another issue until this issue gets merged (or closed). Thanks again :)

@Jaretzbalba
Copy link
Member

Review availability: Weekdays 10-12pm
ETA: 01/24 5pm

@github-actions github-actions bot added Status: Updated No blockers and update is ready for review and removed Status: Updated No blockers and update is ready for review labels Jan 20, 2023
@github-actions
Copy link

@Jaretzbalba

Please add update using the below template (even if you have a pull request). Afterwards, remove the 'To Update !' label and add the 'Status: Updated' label.

  1. Progress: "What is the current status of your project? What have you completed and what is left to do?"
  2. Blockers: "Difficulties or errors encountered."
  3. Availability: "How much time will you have this week to work on this issue?"
  4. ETA: "When do you expect this issue to be completed?"
  5. Pictures (optional): "Add any pictures of the visual changes made to the site so far."

If you need help, be sure to either: 1) place your issue in the developer meeting discussion column and ask for help at your next meeting, 2) put a "Status: Help Wanted" label on your issue and pull request, or 3) put up a request for assistance on the #hfla-site channel.

You are receiving this comment because your last comment was before Monday, January 23, 2023 at 11:16 PM PST.

@github-actions github-actions bot added the 2 weeks inactive An issue that has not been updated by an assignee for two weeks label Jan 27, 2023
@github-actions
Copy link

github-actions bot commented Feb 3, 2023

@Jaretzbalba

Please add update using the below template (even if you have a pull request). Afterwards, remove the 'To Update !' label and add the 'Status: Updated' label.

  1. Progress: "What is the current status of your project? What have you completed and what is left to do?"
  2. Blockers: "Difficulties or errors encountered."
  3. Availability: "How much time will you have this week to work on this issue?"
  4. ETA: "When do you expect this issue to be completed?"
  5. Pictures (optional): "Add any pictures of the visual changes made to the site so far."

If you need help, be sure to either: 1) place your issue in the developer meeting discussion column and ask for help at your next meeting, 2) put a "Status: Help Wanted" label on your issue and pull request, or 3) put up a request for assistance on the #hfla-site channel.

You are receiving this comment because your last comment was before Monday, January 30, 2023 at 11:17 PM PST.

@Jaretzbalba
Copy link
Member

Progress: "I have the code dynamically showing for all of the criteria except for when the alt field exists but is empty. "
Blockers: "Can't seem to figure out how to use the empty or blank tag in liquid to work."
Availability: "4 hours. I am prepping for a job interview so my time is limited right now."
ETA: "2/10"

@ExperimentsInHonesty ExperimentsInHonesty added Status: Updated No blockers and update is ready for review and removed 2 weeks inactive An issue that has not been updated by an assignee for two weeks labels Feb 7, 2023
@Jaretzbalba
Copy link
Member

@ExperimentsInHonesty Here are screenshots of how the new message looks in mobile, tablet, and desktop views. Please let me know if there are any changes you'd like. Thank you!

Mobile

mobile-citizen-engagement

Tablet

tablet-citizen-engagement

Desktop

desktop-citizen-engagement

@github-actions github-actions bot removed the Status: Updated No blockers and update is ready for review label Feb 24, 2023
@github-actions
Copy link

@Jaretzbalba

Please add update using the below template (even if you have a pull request). Afterwards, remove the '2 weeks inactive' label and add the 'Status: Updated' label.

  1. Progress: "What is the current status of your project? What have you completed and what is left to do?"
  2. Blockers: "Difficulties or errors encountered."
  3. Availability: "How much time will you have this week to work on this issue?"
  4. ETA: "When do you expect this issue to be completed?"
  5. Pictures (optional): "Add any pictures of the visual changes made to the site so far."

If you need help, be sure to either: 1) place your issue in the developer meeting discussion column and ask for help at your next meeting, 2) put a "Status: Help Wanted" label on your issue and pull request, or 3) put up a request for assistance on the #hfla-site channel.

You are receiving this comment because your last comment was before Monday, February 20, 2023 at 11:17 PM PST.

@github-actions github-actions bot added the 2 weeks inactive An issue that has not been updated by an assignee for two weeks label Feb 24, 2023
@ExperimentsInHonesty
Copy link
Member

@Jaretzbalba Please make sure that you use the same code that the projects page uses to keep project cards that we don't want displayed from showing. You will notice that the project cards artwatcher and curbmap both have
visible: false
in the md file.

See

{% assign visible_projects = site.projects | where: "visible", "true" %}

FYI @hackforla/website-merge

@ExperimentsInHonesty ExperimentsInHonesty removed the 2 weeks inactive An issue that has not been updated by an assignee for two weeks label Feb 26, 2023
@Jaretzbalba
Copy link
Member

@ExperimentsInHonesty Of course! My screenshots above were just used as an example to show what the page would look like if those cards had visible: true as requested in the action items for this issue. Before submitting a PR I will change it back to visible: false.

@ExperimentsInHonesty
Copy link
Member

@Jaretzbalba ok, cool! it looks good to me!

@ExperimentsInHonesty
Copy link
Member

ExperimentsInHonesty commented Mar 19, 2023

@hackforla/website-merge We need to test this with Access the data, because they said their info was out of date. Please make another issue to remove their PSI from their project.md card.

@ExperimentsInHonesty ExperimentsInHonesty added the ready for dev lead Issues that tech leads or merge team members need to follow up on label Mar 19, 2023
@ExperimentsInHonesty ExperimentsInHonesty removed the ready for dev lead Issues that tech leads or merge team members need to follow up on label Mar 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Medium P-Feature: Citizen Engagement https://www.hackforla.org/citizen-engagement role: front end Tasks for front end developers size: 1pt Can be done in 4-6 hours Status: Updated No blockers and update is ready for review
Projects
Development

Successfully merging a pull request may close this issue.

3 participants