Update Citizen engagement page to show missing message #4056
Conversation
…bsite into update-getting-started-3761
…rez-8/website into citizen-engagement-message-info-3757
…bsite into citizen-engagement-message-info-3757
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
github-actions
bot
added
role: front end
|
Availability: M-F 10 AM - 3 PM |
|
Review ETA: 7:40PM 2/28/23 |
There was a problem hiding this comment.
@Jaretzbalba The media queries looks well done so it makes the code work :)
|
Review ETA: 1 Mar 2023 |
There was a problem hiding this comment.
Nice work @Jaretzbalba ! The CSS is very effective in all viewports. Just wanted to make sure why the .bash_profile.swp file is added into this pull request.
|
@Thinking-Panda Thank you! And I'm not actually quite sure what that file is or how to get rid of it as I can't see it in my own code base. |
Hi @Jaretzbalba assuming you want to retain the file locally, and you just want to remove it from the branch, you could try |
There was a problem hiding this comment.
Great Job on doing this task @Jaretzbalba ! I have similar question about .bash_profile.swp as @Thinking-Panda but the changes are nicely done as per the action items in the issue.
|
@Thinking-Panda @mademarc @Suman2795 I was able to remove the .swp file so everything should be good now. Thank you! |
There was a problem hiding this comment.
@Jaretzbalba ,thank you for making the changes. Website works good on local machine.
There was a problem hiding this comment.
Hi @Jaretzbalba Great job with coordinating the changes with everyone! Only as notes: In Docker I can see that the hrefs at the card titles are functional and that for Open Community Survey, the Impact section has the original message and not 'Dolerem ipsum...' seen in the 'after' screenshots.
Looks good thanks!
Fixes #3757
What changes did you make and why did you make them ?
Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)
Visuals before changes are applied
Mobile
Tablet
Desktop
Visuals after changes are applied
Mobile
Tablet
Desktop