update project profile of home unite us page #3162
Conversation
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
github-actions
bot
added
P-Feature: Project Info and Page
|
ETA: End of the day on 5/22 |
|
Hey @trishajjohnson, can you make sure to add this pr to the project board? |
There was a problem hiding this comment.
@trishajjohnson Thank you for working on this issue! Everything looks good but for consistency among the project pages, could you please change the roles from "Product Management" to "Product Manager" for Regan, Kristy, and Ben?
|
ETA: 5/20/2022 (end of day) |
There was a problem hiding this comment.
@trishajjohnson Thank you for submitting your PR. Good job removing Abiha Ali from the leadership roster and adding Ben Ross to the leadership roster. I was able to see this change locally, as well. However, the link for Ben Ross's picture used in line 51 of _projects/home-unite-us.md is the same link used for Abiha Ali, so this needs to be changed so that the link for Ben Ross's picture is used.
I also second what @Jaretzbalba said about changing the roles from "Product Management" to "Product Manager" for Regan, Kristy, and Ben. That way, it will be consistent with the other project pages, as in the following examples:
Food Oasis Project Page
Brigade Organizers Playbook Project Page
100 Automations Project Page
And also, yes, make sure to add this PR to the project board. Thank you.
There was a problem hiding this comment.
This pr is on the correct branch. There is a correct linked issue. The pr addresses the linked issue, namely to remove Abiha Ali from the Home Unit Us project info page and add Ben Ross. The pictures of visual changes look good. The links work in browser. The picture for Ben Ross looks like it is still Abiha. Make that Change and I think you are good to go.
|
@answebdev and @Jaretzbalba I made the changed all Product Management roles to Product Manager, but I am unsure about the picture for Ben. In the actual issue, there was no pic given to use for Ben. I assumed that the pic for Abiha was a generic default pic, which is why I put it there. Did I miss the url for Ben completely or is it not there in the issue? UPDATE: I just realized that the pictures used on the site are their github profile pictures, so I'll get Ben's from his github. |
|
@trishajjohnson Thank you for making the change from "Product Management" to "Product Manager". But, were you able to see this change locally? I am not able to see this change. As you can see, I still see "Product Management", unless it's something on my end (see below). @Jaretzbalba Are you able to see the change to "Product Manager" locally on your end? Also, @trishajjohnson Were you able to get the link for Ben's GitHub picture? Home Unite Us - local
|
|
@answebdev Sorry for the delay. I hadn't pushed the revisions. They are there now, so you should be able to see the changes. I changed Product Management roles to Product Manager and I replaced Ben's picture with the correct url. Ready to re-review. |
There was a problem hiding this comment.
@trishajjohnson Thank you for pushing your revisions. I had a feeling my not being able to see your changes may have had something to do with that. But now I am able to see the changes. I can now see the change from "Product Management" to "Product Manager" for Regan, Kristy, and Ben, and I am now able to see Ben's GitHub picture as well. Great job!
|
ETA: End of Day on 5/30 |
|
@JessicaLucindaCheng is this ready for merging, or do I need to request for another re-review? |
|
@hackforla/website-merge Please respond to @trishajjohnson:
|
|
@trishajjohnson Please reach out to Tamara or one of the merge team members. You can find their Slack info here: https://github.com/hackforla/website/wiki/Meet-the-Team |
There was a problem hiding this comment.
@trishajjohnson I see the changes made to the roles to keep everything consistent and it looks great! I just left a comment to fix a line concerning the linked image and everything should be good. Thank you again for working on this!
Used a squash and merge for this * Applied Title classes to heading elements on donate page (hackforla#2723) * applied Title classes to heading elements on donate page, repositioned first h1 element on page to align with paragraph. * changed Titlex classes to titlex, removed title classes from sass file. * fixed requested errors * Fixed the styling issues, localhost and hfla site match. * made requested changes * commiting changes so I can sync with upstream. * made requested changes * Removed Ready for milestone for Pre-work Template - Developers Reason: Tech leads should manually check the preworks before adding ready for milestone label * Update meeting data * Update contributor and language data * Update meeting data * Update contributor and language data * Update issue templates * Update meeting data * Update contributor and language data * Edited the content field and removed the type field so that redundant code is removed and the code is easier to understand (hackforla#3182) Merged hackforla#3182 into gh-pages. * Remove alt-hero field from civic-opportunity-project.md project file hackforla#2923 (hackforla#3173) * Update meeting data * Update contributor and language data * Update pre-work-template--dev.md (hackforla#3192) * Update dev prework template * Update pre-work-template---design.md (hackforla#3184) Bonnie asked to update the design template * Updated dev prework template * Update dev prework template * Update meeting data * Update contributor and language data * Update issue templates Updated estimates, time spent so far and progress report items. * Update CONTRIBUTING.md Added a note about leaving issues (other than pre-work) in In progress column until merged. * Fixed Project md file: Removing unused `alt-hero` field * Fix Alt Text Audit - Design issue template I did not make edits as part of commit fd642a4 to .github/ISSUE_TEMPLATE/alt-text-audit---design.md but for some reason changes were made. I fixed it here by editing the file to change it back. * Update meeting data * Update contributor and language data * Edited content field and removed (hackforla#3193) Merged hackforla#3193 into gh-pages. * Update CONTRIBUTING.md Added link of a filtered project board for back end good first issues. * removed unused alt-hero field (hackforla#3178) Co-authored-by: Olanrewaju-Ak <[email protected]> * Update meeting data * Update contributor and language data * Updated Project Profile Card review and update template Capitalized GitHub in the links section * Updated Pre-work Template - Developers Changed team lead to technical lead * Update issue templates (hackforla#3219) updated developer prework template * edit content field and remove type field from _data/interal/credits/resume.yml (hackforla#3218) * Update README.md * Remove alt-text field in github-issues.html, responsible-use-of-images-on-opensource-projects.html, setting-up-1password-on-opensource-projects.html, all within the _guide-pages directory (hackforla#3176) * Update meeting data * Update contributor and language data * Update meeting data * Update contributor and language data * removed unused filed (hackforla#3221) * Removed type field 2878 (hackforla#3185) * modified content field * removed type field * modified content field * removed type field * revert jekyll version * Update meeting data * Update contributor and language data * Update developer pre-work issues * Update meeting data * Update contributor and language data * Update image location sponsors 2458 (hackforla#2984) * update image location for sponsors * update image location for sponsors * update class logo img * update code in sponsors.hmtl * add scss to cfa logo in citizen-engagement page * Remove alt hero field 3215 (hackforla#3231) * Docker-compose file update * Reverted docker-compose file from '4.2.0' back to 'pages' * alt-hero field deleted * Update meeting data * Update contributor and language data * Update meeting data * Update contributor and language data * remove unused alt field from vrms.md project file (hackforla#3226) * Update meeting data * Update contributor and language data * Update meeting data * Update contributor and language data * Lucky parking 2916 (hackforla#3086) * changed the spelling from webapp to web app on line 56 * chnaged the double quotes around the links to single quotes * Update meeting data * Update meeting data * Update contributor and language data * Update dev prework issue template * Update meeting data * Update contributor and language data * Add h tags 2952 (hackforla#3237) * add civic tech overview page to assets folder * change link in markdown file * Update merge conflict * Change p tags to h tags * Removed the alt text for the 311 project card image (hackforla#3241) to adhere to WCAG. * Update meeting data * Update contributor and language data * added a new note in section 2.2 before the existing one (hackforla#3235) Co-authored-by: Olanrewaju-Ak <[email protected]> * update project profile of home unite us page (hackforla#3162) * removed Abiha Ali and added Ben Ross under leadership for home unite us page * Update meeting data * Update contributor and language data * Update meeting data * Update contributor and language data * Update meeting data * Update contributor and language data * Update meeting data * Update contributor and language data * updated calendar-time.yml (hackforla#3258) Co-authored-by: olivi <[email protected]> * Update meeting data * Update contributor and language data * Removed credits type field and renamed content to content-type in redo.yml (hackforla#3285) * Update meeting data * Update contributor and language data * Updated how 'overview' link opens for Home Unite US (hackforla#3224) * Updated how 'overview' link opens for Home Unite US * Update meeting data * Update contributor and language data * removed unused filed (hackforla#3221) * Removed type field 2878 (hackforla#3185) * modified content field * removed type field * modified content field * removed type field * revert jekyll version * Updated how 'overview' link opens for Home Unite US Co-authored-by: GitHub Actions Bot <[email protected]> Co-authored-by: Arpita <[email protected]> * changed line 4 for the content field from content:icon to content-type:image. Also removed line 11 type:icon (hackforla#3264) * Update meeting data * Update contributor and language data * Changed sdg image's alt text for access the data (hackforla#3288) * Resolve issue 2155 to add a comment reminding new issue assignees to add their ETA and availability (hackforla#2962) * changed content and type into one field: content-type (hackforla#3291) Co-authored-by: tunglinn <[email protected]> * update instructions template 2897 (hackforla#3262) Co-authored-by: olivi <[email protected]> * Update meeting data * Update contributor and language data * Update meeting data * Update contributor and language data * Updated website team members (hackforla#3298) * Changed from Content to Content-Type (hackforla#3297) * changed from content to content type * ignore * Change content to content-type * edited and removed words (hackforla#3287) Co-authored-by: Lily Arjomand <[email protected]> * Update meeting data * Update contributor and language data * Bump node-fetch from 2.6.1 to 2.6.7 in /github-actions/github-data (hackforla#3263) Bumps [node-fetch](https://github.com/node-fetch/node-fetch) from 2.6.1 to 2.6.7. - [Release notes](https://github.com/node-fetch/node-fetch/releases) - [Commits](node-fetch/node-fetch@v2.6.1...v2.6.7) --- updated-dependencies: - dependency-name: node-fetch dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * changed line 4 and deleted line 11 (hackforla#3303) Co-authored-by: Riya Aswani <[email protected]> * Update meeting data * Update contributor and language data * Changed alt text for card image (hackforla#3304) Co-authored-by: Lily Arjomand <[email protected]> * Update issue templates * Update meeting data * Update contributor and language data * changed image alt in lucky-parking.md (hackforla#3317) Co-authored-by: tunglinn <[email protected]> * Change alt text for citizen engagement html file (hackforla#3320) * changed from content to content type * change content to content-type * change content to content-type * change content to content-type * change content to content-type * change alt text line 52 * reset docker-compose Co-authored-by: Patrick McGuigan <[email protected]> Co-authored-by: GitHub Actions Bot <[email protected]> Co-authored-by: alan-zambrano <[email protected]> Co-authored-by: mmogri <[email protected]> Co-authored-by: Ava Li <[email protected]> Co-authored-by: phuonguvan <[email protected]> Co-authored-by: Saumil Dhankar <[email protected]> Co-authored-by: mchavezm <[email protected]> Co-authored-by: Akinola Olanrewaju <[email protected]> Co-authored-by: Olanrewaju-Ak <[email protected]> Co-authored-by: Bonnie Wolfe <[email protected]> Co-authored-by: Don Brower <[email protected]> Co-authored-by: Julian Smith <[email protected]> Co-authored-by: Arpita <[email protected]> Co-authored-by: Jason Yee <[email protected]> Co-authored-by: Matthew Arofin <[email protected]> Co-authored-by: Erick Odero <[email protected]> Co-authored-by: riddle015 <[email protected]> Co-authored-by: Trisha Johnson <[email protected]> Co-authored-by: Olivia Wang <[email protected]> Co-authored-by: olivi <[email protected]> Co-authored-by: Beckett OBrien <[email protected]> Co-authored-by: Utkarsh Saboo <[email protected]> Co-authored-by: Tung Lin <[email protected]> Co-authored-by: tunglinn <[email protected]> Co-authored-by: Clayton Brossia <[email protected]> Co-authored-by: Lily Arjomand <[email protected]> Co-authored-by: Lily Arjomand <[email protected]> Co-authored-by: Sarah Sanger <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Riya Aswani <[email protected]> Co-authored-by: Riya Aswani <[email protected]>
Fixes #3084
What changes did you make and why did you make them ?
-Removed Abiha Ali from leadership roster
-Added Ben Ross to leadership roster with their name, github handle, role and slack id.
Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)
Visuals before changes are applied
Visuals after changes are applied