Lucky parking 2916

[eodero]

Fixes #2916

What changes did you make and why did you make them ?

-changed the double quotes around the links back to single quotes per H4LA standards.

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Visuals before changes are applied

Visuals after changes are applied

[github-actions]

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b eodero-lucky-parking-2916 gh-pages
git pull https://github.com/eodero/hack4la-website.git lucky-parking-2916

[matt-arofin]

• ETA: End of the day, 05/01/22
• Availability: 6pm - 8pm EST

[matt-arofin]

Hi @eodero,

I see that in addition to updating the spelling to 'web app' as originally requested by this issue you've been able to revert the double quotation marks back to single quotation marks. Great job applying the fix Adolf suggested, your code looks clean and properly formatted!

I did notice that you hadn't checked off the action items on the original issue, and hope you'll note it moving forward since it helps keep us all aware of how you're progressing 😄

[Carlos-A-P]

Availability: 1hr
ETA: 5/3/2022 EOD

[Carlos-A-P]

Hey @eodero, make sure to add "no visual changes" under Screenshots and also move this pr to the project board.

[eodero]

Hi @eodero,

I see that in addition to updating the spelling to 'web app' as originally requested by this issue you've been able to revert the double quotation marks back to single quotation marks. Great job applying the fix Adolf suggested, your code looks clean and properly formatted!

I did notice that you hadn't checked off the action items on the original issue, and hope you'll note it moving forward since it helps keep us all aware of how you're progressing 😄

Thank you @matt-arofin

[eodero]

Hey @eodero, before I review this pr make sure to add "no visual changes" under Screenshots and also move this pr to the project board.

@Carlos-A-P , thanks for the pointers.

[luke-karis]

Great Job working on this issue! The change to typo looks fixed to me. All that needs to be done is to change those double quotes back to single ones. Also, for this issue I think it would be actually be a good idea to include a before and after image because there are technically visible changes even if it is just fixing a typo.

Finally, once you've made these changes, don't forget to click the little circle of arrows next to each reviewers name, this will notify us that you're ready to have your code be re-reviewed!

[Carlos-A-P]

@eodero, I can see the code changes on my side, and everything looks good, awesome work! I previously said to include no visual changes, but that was my mistake since, for this issue, there are visible changes of the fixed typo, sorry about that. Make sure to include those screen shots under the before and after.

[Sparky-code]

Good Morning @eodero! Checking in to see if you're still working on this issue and if you had any questions? Please include an update to your availability and expected ETA for this issue in your reply.

[SAUMILDHANKAR]

@eodero Planning to close this PR due to inactivity. Please let us know when your availability changes. Will leave a slack message and email as well. Thanks.

[alan-zambrano]

@Carlos-A-P I was prepared to take this issue, but it seems all changes that were requested for the file have already been made? Is this issue only waiting on the screenshots? I can't seem to find the corresponding page to show a before/after, but the github readme has the same "webapp" typo https://github.com/hackforla/lucky-parking/blob/master/README.md

[Carlos-A-P]

@alan-zambrano the typo is visible on the following page: https://www.hackforla.org/citizen-engagement. You can take a screenshot of the before image from the hack for la site and an after image from your localhost.

[alan-zambrano]

Got it, I've updated the visuals.

[Carlos-A-P]

@alan-zambrano thanks for making those changes and adding the screenshots, great job working on this issue!

[JessicaLucindaCheng]

@alan-zambrano I think there has been some confusion. Usually, the PR creator (in this pr @eodero) would be making any requested changes.

If you were looking for a "good first issue" to work on, see Part 2: How the Website team works with GitHub issues in the CONTRIBUTING.md, especially section "2.3 Where can I find GitHub issues to work on?"

[SAUMILDHANKAR]

Update: Heard back from Erick on slack. Erick is planning to join back and share an update around Wednesday this week.

[eodero]

Sorry everyone for the the inconvenience, have my PC fixed now, reinstalling some programs and lost some directories which I need to reinstate.

• availability 3 hrs
• ETA - 6/2/2022

Changes have been made to reflect both the code and visual documentation revisions requested.

[Sparky-code]

@eodero The code changes look good and I do see you included the visual changes (Thank you for highlighting the change!).