Credits

[jqg123]

Fixes #2528

What changes did you make and why did you make them ?

-new icons
-credits
-figma prototype to feature branch

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Visuals before changes are applied

Visuals after changes are applied

![image](

Paste_Your_Image_Link_Here_After_Attaching_Files)

[SAUMILDHANKAR]

Review ETA: 2/17
Availability: Thursday 6-8 PM

[JessicaLucindaCheng]

@jqg123 In addition to my inline comments for changes, please make these changes too.

• There might have been possible changes to the branch since you last worked on this issue. Check the last pr merged on to the feature-homepage-launch branch, which should be a pr by arghmatey. In that pr, click the "Files Changed" to see what files were added.

  • Specifically, you should see what images were already added by comparing the images in Figma.
    • There are some svg images, such as infinite.svg, that do not show up as an image but as code when looking in the "Files Changed" tab, so you will have to use Docker by using 'docker-compose up' to see those images.
    • Then make a note of what the file names are for those images and edit your credits files' image-url fields accordingly with those image file names.
  • Delete any images that you added that are already on the feature-homepage-launch branch. To see what images you added, check the "Files Changed" tab for your pr.

    • I think the only image you need to keep is this one with hands:

      

• The citizen-engagement.yml should not have been edited as it is a credit file for a different image on a different page. Please revert the changes for that file and create a new file called citizen-engagement-2.yml

  • Change the alt field text description to match the image.

• The design.yml should not have been edited as it is a credit file for a different image on a different page. Please revert the changes for that file and create a new file called design-2.yml

  • title-link should be https://thenounproject.com/icon/design-3160558/

• discussion-teamwork.yml is missing an alt field for alt text.

• In the section under "What changes did you make and why did you make them?" in your original post/comment, you wrote "figma prototype to feature branch". I'm confused what that means. Can you please clarify what you meant by that in your original post/comment?

• I don't see an image for the section "Visuals before changes are applied" in your original post/comment. Please edit your comment/post with a before image. You can use GoFullPage Chrome Extension to get a full page screenshot.

• Also, I can't see all your images in the "Visuals after changes are applied". Please add a blank line in between each image in your original post/comment.

• Please add your pr to the Project Board.

  Click here for more detailed instructions on how to add your pr to the Project Board

  1. On the right, under the "Projects" section

  

  2. Click on the gear icon

  

  3. Then click on Project Board to add your pull request to the project board.

  

• When you are ready for me to re-review your pull request, please click the following in the Reviewers section on the right:

[JessicaLucindaCheng]

The image-url link should be /assets/images/program-areas/vote-representation.png

[SAUMILDHANKAR]

Revised review ETA: 5 PM 2/23/22
Availability: Wednesday 3-5 PM Pacific Time

[SAUMILDHANKAR]

This image is already there in the feature-homepage-launch branch, so please remove it.

[SAUMILDHANKAR]

Your yml file should basically edit the following yml file already in the feature branch as per new details on the Figma page. _data/internal/credits/product-management.yml

[SAUMILDHANKAR]

Please remove this yml file as this is not there on the Figma page.

[SAUMILDHANKAR]

There should be no changes made to this file, i.e., it should look exactly as it currently is on the feature branch and hence should not be in the files changed tab.

[SAUMILDHANKAR]

We don't need to add this file as it is a duplicate of the following: assets/images/hero/infinite.svg and is already there in the feature branch.

[SAUMILDHANKAR]

As the image already exists in the feature branch, so use that image-url here instead.

[SAUMILDHANKAR]

Please change the url with the following url: assets/images/program-areas/civic-tech-infrastructure.png as the image already exists in the feature branch. Also, delete the following file: assets/images/civictechinfrastructure/adeolu-eletu-unRkg2jH1j0-unsplash.jpg

[SAUMILDHANKAR]

@jqg123 Thanks for making the changes in your latest commit. We are getting there. Request you to make the following changes:

• The following jpg file used as image for workforce development should not be there as part of this PR, so please remove it. [assets/mages/WorkforceDevelopment/christina-wocintechchat-com-mxOdUd1BQIM-unsplash.jpg]
• The following two files should not be in the files changes tab as it is already there in the feature branch. [_data/internal/credits/operations.yml], assets/images/operations/noun-operations-1819014.svg(https://github.com/hackforla/website/pull/2774/files#diff-db5a867ab8ddb97cf786803bf4adfc17bb74de24680fb3c2c549bd1a9dc31399), also please do the same for data-science and marketing as well.
• Your accounting yml file should make changes to the revenue yml file which already exists in the feature branch and accounting image is also there with the name of fundraising.
• Your coding yml file should make changes to the engineering yml file which already exists in the feature branch, please make changes to the respective images as well.
• Your design-2 yml file should make changes to the ui-ux yml file which already exists in the feature branch, please make changes to the respective images as well.
• Citizen Engagement yml file should not be in the files changes tab. Changes that you have made to the citizen engagement file should actually be made to citizen-engagement-2 yml file. Also, the image url in citizen-engagement02 file should be assets/images/program-areas/citizen-engagement.png as the file already exists in the feature branch.

There are some more changes that need to be made which are similar to those I have already requested, i.e., images for Diversity equity inclusion, social safety net, vote representation, justice, environment are already there in the feature branch so no need to add them here. I will wait for you to make these changes and then take a look again. Please request a re-review once you are done. Thank you.

[jqg123]

I may need someone to take over this issue.
ETA:n/a
Availability: 1hr

Requested changes still need to be made

[JessicaLucindaCheng]

@jqg123

I may need someone to take over this issue. ETA:n/a Availability: 1hr

Do you want us to un-assign you from the issue related to this pr?

[SAUMILDHANKAR]

@jqg123 Just wanted to follow up and know more about the reasons you wanted someone to take over this issue. Do you have any questions, need help or not have enough time or if you would like to work on some other issue instead of this? Please let us know. We will wait for a few days for your response before taking next steps. I will leave a slack message about the same as well. Thank you.

[SAUMILDHANKAR]

Received an update from John: "not able to continue on this due to an upcoming job".
Planning to close this PR since it would take more time to make changes than doing it from scratch. Also, the issue needs a rewrite as well. Including Jessica and John for reference (@jqg123, @JessicaLucindaCheng)