Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new icons #2557

Conversation

jqg123
Copy link
Member

@jqg123 jqg123 commented Dec 8, 2021

Fixes #2528

What changes did you make and why did you make them ?

-new icons
-credits
-figma prototype to feature branch

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Visuals before changes are applied

image

Visuals after changes are applied

![image](
Screenshot (54)

Paste_Your_Image_Link_Here_After_Attaching_Files)

![Screenshot (55)](https://user-images.githubusercontent.com/9208705/153740882-32f2af5e-c3c9-40e6-b6f3-f0b5251f33e5.png) ![Screenshot (56)](https://user-images.githubusercontent.com/9208705/153740884-0313713d-cfe7-4c20-a2d5-410605b7bfe4.png) ![Screenshot (57)](https://user-images.githubusercontent.com/9208705/153740888-66983b0d-35e8-4d8f-828c-71e399ca56f6.png) ![Screenshot (58)](https://user-images.githubusercontent.com/9208705/153740889-4909062d-15a7-484f-a0c0-049cdcfa6413.png)

Screenshot (59)
Screenshot (60)
Screenshot (61)

Screenshot (62)

@github-actions
Copy link

github-actions bot commented Dec 8, 2021

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b jqg123-add-credit-icon-redesign-2528 feature-homepage-launch
git pull https://github.com/jqg123/website.git add-credit-icon-redesign-2528

@jqg123 jqg123 marked this pull request as ready for review December 15, 2021 12:43
@github-actions github-actions bot added Feature: Feature Branch Requires Branching off a Feature Branch instead of gh-pages P-Feature: Credit https://www.hackforla.org/credits/ role: front end Tasks for front end developers Complexity: Small Take this type of issues after the successful merge of your second good first issue Status: Updated No blockers and update is ready for review labels Dec 15, 2021
@jqg123 jqg123 changed the title not done yet new icons Dec 15, 2021
@macho-catt
Copy link
Member

Hi @jqg123, could you also add what changes you made in your post, and add the relevant images?

Thanks

@jqg123 jqg123 linked an issue Dec 15, 2021 that may be closed by this pull request
1 task
@SAUMILDHANKAR
Copy link
Member

@jqg123 Just following up on the issue. Please share the images after changes are applied. Let me know if you have questions. Thank you.

@JessicaLucindaCheng

This comment was marked as outdated.

@SAUMILDHANKAR
Copy link
Member

@jqg123 Thanks for getting back to me on Slack. Please update your progress here as well. Thank you.

@jqg123
Copy link
Member Author

jqg123 commented Feb 8, 2022

working on this. have not done this issue in a long time.

@JessicaLucindaCheng
Copy link
Member

Closing this pr because it is a duplicate of pr #2774

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Small Take this type of issues after the successful merge of your second good first issue Feature: Feature Branch Requires Branching off a Feature Branch instead of gh-pages P-Feature: Credit https://www.hackforla.org/credits/ role: front end Tasks for front end developers Status: Updated No blockers and update is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants