-
-
Notifications
You must be signed in to change notification settings - Fork 778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add credits for photos and icons for redesigned homepage #2528
Comments
This comment was marked as outdated.
This comment was marked as outdated.
Availability for this week: 20h |
I have a blocker. I do not know where to source the new icons from. The previous icons have photos in the assets folder. I have added a discussion teamwork link. I have attempted to download the svg from the link and add it to the images. The result was a blank pictures. Possibly the picture is scaled too large or I do not know the format of the svg file. I am working on the add-credit-icon-redesign-2528 branch of my forked repo. Any assistance is appreciated. |
@jqg123 you can export the image from the figma design. I can show you in tonight's meeting. |
@jqg123: Thanks for adding your availability and eta. Just wanted to share a point from our Sunday team meeting. We are now requesting all developers to add eta and availability at the time of picking up an issue or when you are assigned to an issue. You are already doing this, so nothing needs to be done at your end. Just wanted to let you know. Thanks for your awesome work. |
I have no idea how to resolve the conflicts. Perhaps there were update while I was away? I have tried to update the website from upstream first before I submitted. |
I changed the size label to medium since scope of work involved now is greater than a small issue. |
Received an update from John: "not able to continue on this due to an upcoming job". |
I want to make this into an epic. I will be breaking down each credit into its own small complexity issue. |
This issue will be broken down and implemented in this epic #3130 because
Thus, I will be closing this issue. |
Overview
We need to add credits for all new icons and photographs used in the redesigned version of the homepage so that the Credits page is up to date.
Note: Feature Branch
The pull request created from this issue should be pushed into a feature branch called "feature-homepage-launch." Please note this wiki article on how to work off of a feature branch.
Action Items
Resources/Instructions
HfLA - Credits Page
Figma - Homepage Redesign: Credits
The text was updated successfully, but these errors were encountered: