Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add credits for photos and icons for redesigned homepage #2528

Closed
1 task
kristine-eudey opened this issue Dec 1, 2021 · 10 comments
Closed
1 task

Add credits for photos and icons for redesigned homepage #2528

kristine-eudey opened this issue Dec 1, 2021 · 10 comments
Labels
Complexity: Medium Feature: Feature Branch Requires Branching off a Feature Branch instead of gh-pages Ignore: Duplicate Issue or pull request is a duplicate P-Feature: Credit https://www.hackforla.org/credits/ role: front end Tasks for front end developers size: 2pt Can be done in 7-12 hours

Comments

@kristine-eudey
Copy link
Member

kristine-eudey commented Dec 1, 2021

Overview

We need to add credits for all new icons and photographs used in the redesigned version of the homepage so that the Credits page is up to date.

Note: Feature Branch

The pull request created from this issue should be pushed into a feature branch called "feature-homepage-launch." Please note this wiki article on how to work off of a feature branch.

Action Items

  • Add credits to the Credits Page for all the icons and photographs used on the redesigned homepage. All the credit information can be found here.

Resources/Instructions

HfLA - Credits Page
Figma - Homepage Redesign: Credits

@kristine-eudey kristine-eudey added role: front end Tasks for front end developers Dependency An issue is blocking the completion or starting of another issue P-Feature: Credit https://www.hackforla.org/credits/ Complexity: Small Take this type of issues after the successful merge of your second good first issue Ready for Prioritization labels Dec 1, 2021
@github-actions

This comment was marked as outdated.

@ExperimentsInHonesty ExperimentsInHonesty added Feature: Feature Branch Requires Branching off a Feature Branch instead of gh-pages and removed Ready for Prioritization Dependency An issue is blocking the completion or starting of another issue labels Dec 5, 2021
@jqg123 jqg123 self-assigned this Dec 7, 2021
@jqg123
Copy link
Member

jqg123 commented Dec 7, 2021

Availability for this week: 20h
My estimated ETA for completing this issue: 12/14/21

@jqg123
Copy link
Member

jqg123 commented Dec 8, 2021

I have a blocker. I do not know where to source the new icons from. The previous icons have photos in the assets folder. I have added a discussion teamwork link. I have attempted to download the svg from the link and add it to the images. The result was a blank pictures. Possibly the picture is scaled too large or I do not know the format of the svg file. I am working on the add-credit-icon-redesign-2528 branch of my forked repo. Any assistance is appreciated.

@macho-catt
Copy link
Member

macho-catt commented Dec 8, 2021

@jqg123 you can export the image from the figma design. I can show you in tonight's meeting.

@github-actions github-actions bot added the Status: Updated No blockers and update is ready for review label Dec 10, 2021
@jqg123 jqg123 mentioned this issue Dec 15, 2021
@jqg123 jqg123 linked a pull request Dec 15, 2021 that will close this issue
@SAUMILDHANKAR
Copy link
Member

@jqg123: Thanks for adding your availability and eta. Just wanted to share a point from our Sunday team meeting. We are now requesting all developers to add eta and availability at the time of picking up an issue or when you are assigned to an issue. You are already doing this, so nothing needs to be done at your end. Just wanted to let you know. Thanks for your awesome work.

@jqg123 jqg123 linked a pull request Feb 13, 2022 that will close this issue
@jqg123 jqg123 mentioned this issue Feb 13, 2022
@jqg123 jqg123 removed a link to a pull request Feb 13, 2022
@jqg123
Copy link
Member

jqg123 commented Feb 13, 2022

I have no idea how to resolve the conflicts. Perhaps there were update while I was away? I have tried to update the website from upstream first before I submitted.

@SAUMILDHANKAR SAUMILDHANKAR added Complexity: Medium and removed Complexity: Small Take this type of issues after the successful merge of your second good first issue labels Feb 18, 2022
@SAUMILDHANKAR
Copy link
Member

I changed the size label to medium since scope of work involved now is greater than a small issue.

@SAUMILDHANKAR
Copy link
Member

Received an update from John: "not able to continue on this due to an upcoming job".
Unassigning and moving this issue back to new issue approval column as the issue needs a rewrite as well.
Including Jessica for reference (@JessicaLucindaCheng)

@JessicaLucindaCheng JessicaLucindaCheng changed the title Add credits for photos and icons for redesigned homepage Issue needs a rewrite. Jessica will be doing it. - Add credits for photos and icons for redesigned homepage Mar 12, 2022
@JessicaLucindaCheng JessicaLucindaCheng removed the Status: Updated No blockers and update is ready for review label Mar 12, 2022
@JessicaLucindaCheng JessicaLucindaCheng self-assigned this Mar 12, 2022
@JessicaLucindaCheng
Copy link
Member

JessicaLucindaCheng commented Mar 12, 2022

I want to make this into an epic. I will be breaking down each credit into its own small complexity issue.

@JessicaLucindaCheng JessicaLucindaCheng changed the title Issue needs a rewrite. Jessica will be doing it. - Add credits for photos and icons for redesigned homepage Add credits for photos and icons for redesigned homepage Mar 31, 2022
@JessicaLucindaCheng JessicaLucindaCheng removed their assignment May 12, 2022
@JessicaLucindaCheng
Copy link
Member

This issue will be broken down and implemented in this epic #3130 because

  • Some of the credits exist on the feature branch but need some of the information changed because it has outdated/inaccurate info.
  • Some credits need to be created from scratch but the image exists on the feature branch already.
  • One credit needs to be created and needs an image added.
  • It will make it easier to review each credit.

Thus, I will be closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Medium Feature: Feature Branch Requires Branching off a Feature Branch instead of gh-pages Ignore: Duplicate Issue or pull request is a duplicate P-Feature: Credit https://www.hackforla.org/credits/ role: front end Tasks for front end developers size: 2pt Can be done in 7-12 hours
Projects
Development

Successfully merging a pull request may close this issue.

7 participants