-
-
Notifications
You must be signed in to change notification settings - Fork 778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Work flow for guides to appear on the website #1630
Comments
proposed work flow |
we need to make it so that the pdfs load in the browser window using github. |
This comment has been minimized.
This comment has been minimized.
Progress: Testing markdown converter. Updating prototype so that front matter locates image path so that we can achieve the format we want for markdown file. Blockers: Learning more about liquid so that we can achieve the format as mentioned earlier. Availability: 8-10 hours ETA: 8/16/21 |
Action Items from 8/18/21 MeetingIn addition to the checklist mentioned in #1515:
Update 8/19/21
Update 8/19/21This is possible by adding a "-" at the end of the `href` in the front matter. Example:
Update 8/19/21
Update 8/19/21Will meet with Design Team later today. Development-wise, yes, with the following:
Questions So Far (for Friday's Meeting)
|
Action Items from 8/20/21 Meeting
|
Feedback from 8/22/21 Meeting
Action Items from 8/22/21 Meeting
|
Action Items from 8/25/21 Meeting
Update from 8/26/21: Meeting with Design Team re: What is the Header?
Feedback from 8/25/21 Meeting
Mock-Ups with New Image Headers (Created on 8/26/21)Questions for 8/27/21
Update 8/27/21Moved issue back to the icebox. More details here #1515 (comment) |
Minutes from 8/27/21
Action Items
|
Minutes for 8/29/21
Side-Notes
Action Item
|
Minutes 8/30/21
Action Items
|
Guide Page's New Hero ImageThe winner is Version 1. Please click the arrows below to see the final redesigns for both Desktop and Mobile. Mockups for both Desktop and Mobile available on Figma here. |
@alyssabenipayo What font choices do we have on the website? I looked in the design system pages and didn't see a font specified. We also did some testing (which you can find at the bottom of the figma page). Here is what we found. The reason for our testing is that the titles seem a bit large, and not as sophisticated as the current Google Guides. |
@alyssabenipayo At the top of this issue, I added an action item to release dependency once this issue is merged. |
@JessicaLucindaCheng Thanks for the reminder. Also, I imported it to _sass/main.scss and it worked. The only thing now is that the content is scattered. Fixing it now. Thank you! |
@alyssabenipayo Thank you for sharing your update. I discussed your blocker with Jessica and adding her here for further discussion (@JessicaLucindaCheng). Since, all the scss classes are compiled in the main.scss file before being used on the website, so I think we need to explore further if having same class names is the best approach. Also, wanted to suggest that it would be a better idea if we can create a new issue for your sticky side nav problem since this issue has a lot of comments and might be difficult to follow up. Thank you. |
@SAUMILDHANKAR @JessicaLucindaCheng Thanks for letting me know! I'll create a new issue this week after I finish fixing the styling as mentioned in my previous update. Thanks again. |
@alyssabenipayo With the way the SCSS files are set up to be imported all into one main.scss file, it is best to have different names. |
@JessicaLucindaCheng Noted! Thank you so much for the help and for following up with me. |
Please add update using the below template (even if you have a pull request). Afterwards, remove the 'To Update !' label and add the 'Status: Updated' label.
If you need help, be sure to either: 1) place your issue in the developer meeting discussion column and ask for help at your next meeting, 2) put a "Status: Help Wanted" label on your issue and pull request, or 3) put up a request for assistance on the #hfla-site channel. You are receiving this comment because your last comment was before Tuesday, April 26, 2022 at 12:21 AM PST. |
Hello! I'm sorry for the late update. Here's my progress- Progress: Working on standardizing components. |
Progress: Finished standardizing components. Finalizing adjusting styling for sticky nav. Next Steps:
|
@alyssabenipayo Hope you are doing well. Just wanted to follow up on the next steps for this issue. Looks like we are almost there. Please let us know. Thank you. |
Hi Saumil. Thanks for following up with me. Absolutely - quick update: I finished my issue. I was going to post as soon as I create a pull request and gather my notes. (Notes include file locations related to the Guide Pages and references that would help when I create a new issue on the next steps.) Will update again tonight! Thanks again! Image PreviewNote: Please excuse the odd navbar placements. I used an extension to snapshot the entire webpage and the navbar followed the extension as it scanned the page. |
Progress: Pull request is under review. |
Dependency
Waiting until PMs have identified all guides that are ready (at least 5 are needed for this test)Overview
As PMs we need guides to be easy and fast to add to the website so that we have our guides appear on the website as soon as possible.
Action Items
Resources/Instructions
Here is what we will post on the a guide issue when we assign an image to it
Guide: How to Write a Guide
Template: Guide
How to Set Reminders in Slack v4
Figma
Sample Documentation from GitHub as Reference
emojiterra
Figma / Type Space Figma Youtube Video
Tool researched by 100Automations
Test of Markdown converter guides#10 (comment)
Guide Pages Design System - Work flow for guides to appear on the website #1630 (comment)
The text was updated successfully, but these errors were encountered: