Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work flow for guides to appear on the website #1630

Closed
4 of 14 tasks
Tracked by #1515 ...
ExperimentsInHonesty opened this issue May 25, 2021 · 99 comments · Fixed by #3476 or #3548
Closed
4 of 14 tasks
Tracked by #1515 ...

Work flow for guides to appear on the website #1630

ExperimentsInHonesty opened this issue May 25, 2021 · 99 comments · Fixed by #3476 or #3548
Assignees
Labels
Complexity: Large P-Feature: Toolkit https://www.hackforla.org/toolkit/ role: design role: front end Tasks for front end developers size: 13+pt Must be broken down into smaller issues Status: Updated No blockers and update is ready for review

Comments

@ExperimentsInHonesty
Copy link
Member

ExperimentsInHonesty commented May 25, 2021

Dependency

  • Waiting for a PM to get assigned to Guides (ask Bonnie or Olivia for status if necessary)
  • Waiting until PMs have identified all guides that are ready (at least 5 are needed for this test)

Overview

As PMs we need guides to be easy and fast to add to the website so that we have our guides appear on the website as soon as possible.

Action Items

Resources/Instructions

Here is what we will post on the a guide issue when we assign an image to it

Here is the image that will show up when people go to hackforla.org/toolkit and see this guide
[INSERT IMAGE HERE]

Here are the details for the credits page
Name: Meetup (this needs to link to the original image location)
Used in: Toolkit
Artist: _______
Provider: _____
@ExperimentsInHonesty
Copy link
Member Author

proposed work flow
a guide gets assigned in the CoP
assignee reaches out to HfLA design team to ask for an image via a template issue on hfla github
designer posts back on the guide issue with image details
new issue on hfla github with finished guide pdf url and image details previously provided - issue is auto labeled to development

@ExperimentsInHonesty
Copy link
Member Author

we need to make it so that the pdfs load in the browser window using github.

@sayalikotkar sayalikotkar added the Feature Missing This label means that the issue needs to be linked to a precise feature label. label Jun 20, 2021
@Sihemgourou Sihemgourou added role missing and removed Feature Missing This label means that the issue needs to be linked to a precise feature label. labels Jun 24, 2021
@Sihemgourou Sihemgourou added P-Feature: Toolkit https://www.hackforla.org/toolkit/ role: product Product Management Dependency An issue is blocking the completion or starting of another issue and removed role missing labels Jul 6, 2021
@ExperimentsInHonesty ExperimentsInHonesty removed the Dependency An issue is blocking the completion or starting of another issue label Aug 9, 2021
@ExperimentsInHonesty ExperimentsInHonesty self-assigned this Aug 9, 2021
@Sihemgourou Sihemgourou added this to the 11. Frameworks milestone Aug 9, 2021
@github-actions

This comment has been minimized.

@abenipa3
Copy link
Member

abenipa3 commented Aug 15, 2021

Progress: Testing markdown converter. Updating prototype so that front matter locates image path so that we can achieve the format we want for markdown file.

Blockers: Learning more about liquid so that we can achieve the format as mentioned earlier.

Availability: 8-10 hours

ETA: 8/16/21

@abenipa3
Copy link
Member

abenipa3 commented Aug 18, 2021

Action Items from 8/18/21 Meeting

In addition to the checklist mentioned in #1515:

Update 8/19/21
  • How to Set a Reminder in Slack Guide Page Added.
  • Preview here.
  • Test to see how emojis work in the headings.
Update 8/19/21 This is possible by adding a "-" at the end of the `href` in the front matter. Example:
        - title: "When to Use Reminders ⏰"
          href: "#when-to-use-reminders-"
  • Test to see how cropped images turn out after downloading from Google Docs. (Will the edits/crop apply to the images when we download them?)
Update 8/19/21
  • After downloading the images (by downloading the Web Pages (HTML, zipped folder), images would be saved as original - any edits made (such as cropping, resizing) would not be applied.
  • Alternative option is the following:
    - Select File > Publish to the Web
    - Go to the Link provided by Google Docs.
    - Save Image As all the images. (I initially downloaded the zipped Web Pages folder, which included the images folder, so I would replace all the images with the edited ones from Publish to the Web.
    - When done, will need to unpublish the document by selecting File > Publish to the Web > Under "Publish content & setting", click on Stop Publishing.
  • Test to see if the indentation works design- and development-wise. (See image below for context.)

image

Update 8/19/21 Will meet with Design Team later today. Development-wise, yes, with the following:

      

Questions So Far (for Friday's Meeting)

  • Do we want to add emojis to the section title in the navbar, too?
  • Will the guides contain an overview?
  • If so, how do we want to create the preview section that's viewable on the toolkit page?
  • Alternatives for downloading (edited) images?

@github-actions github-actions bot added the Status: Updated No blockers and update is ready for review label Aug 20, 2021
@abenipa3
Copy link
Member

abenipa3 commented Aug 20, 2021

Action Items from 8/20/21 Meeting

  • Create mock-ups of Guide Page before Sunday.
Update 8/22/21

Created these mockups so far.

image

image

Figma FIle

  • Edit the indentation of the subsections (See JavaScript).
  • Bold "When", "How" - Refer to changes made in Slack Reminders Guide V4.

@abenipa3
Copy link
Member

abenipa3 commented Aug 22, 2021

Feedback from 8/22/21 Meeting

  • Navbar: Team voted for navbar with bolded title:
    image

  • Title: No capitalization for titles (header and section titles).

image

image

Action Items from 8/22/21 Meeting

Update 8/23/21

Created these mockups so far.

Figma FIle

  • Make a mock-up where the subsections in the navbar are not indented.

@abenipa3
Copy link
Member

abenipa3 commented Aug 26, 2021

Action Items from 8/25/21 Meeting

  • Consult with @hackforla/website-design: What is the hero section for our Guide Page? We want our guide pages to show that we can help readers from all over the globe through our hero section.
Update from 8/26/21: Meeting with Design Team re: What is the Header?
  • Our team suggested that we either change the image or edit the current header as seen below.
    image

  • If anything, I created new mockups that suggests new images that may replace the current header.

  • Add Credits at the end of the mock-up.
  • Update Guide Page Team with Design Team's response on 8/27/21.
  • Consult with the website team and cast votes, regarding subsections format on Sunday. (More details under Feedback.)
With Indentation for Subsections

21 - GH-Issues-Mock-Up-Desktop

Without Indentation for Subsections

21 - GH-Issues-Mock-Up-Desktop

Feedback from 8/25/21 Meeting

  • Discussed how to format the subsections for navbar: Without Indentation vs. With Indentation.
    - Action Item for Sunday Consult with the website team and cast votes.
  • Discussed if we want the overview portion of the guide to be titled "Overview" or "What is _____?"
    - Decided vote for "What is ?" - We want the guides to be open to everyone around the globe.
    - "What is
    ?" would be clickable than having the section titled "Overview."

Mock-Ups with New Image Headers (Created on 8/26/21)

Same Header, but Zoomed In

image

"Document Concept Illustration" Header

image

image

"Completed Steps Illustration" Header

image

image

"Publish Article Illustration" Header

image

image

Link to New Mock-Ups

Questions for 8/27/21

Update 8/27/21

Moved issue back to the icebox. More details here #1515 (comment)

@abenipa3
Copy link
Member

abenipa3 commented Aug 28, 2021

Minutes from 8/27/21

  • Reviewed new mockups.
    • We agreed to include the parallelogram in our hero section; it brings out more color. Preview below this section.
    • We voted on mock-ups. Preview below. Will need to redesign.
Mock-Up Hero Section (With Parallelograms) Previews

image

image

image

image

Mock-Up Voted

image

image

Action Items

  • Add credits section title to the mockups: "Guide Authors"
  • Make edits to the image as follows:
    • Replace the bar graph with the map.
    • Replace first page with a how-to image.
    • See site component audit for references.
  • Consult with the website team and cast votes, regarding subsections format, color vs. no-color (hero section) on Sunday.
Mock-Ups for Hero Section

Mock-Up without Color

image

Mock-Up with Color

image

@abenipa3
Copy link
Member

abenipa3 commented Aug 30, 2021

Minutes for 8/29/21

  • Mock-Ups for Hero Section Feedback

    • Bring more color accent to the hero section.
    • Color the chart green in the third page
    • Add yellow to the image, either to the character's pants, shoes, or box image box in the first page.
    • Add a gradient to half of the side of the hero section.
  • Casted votes on Subsection formats. [Option 1] [Option 2]

    • The website team voted for Option 1. 🔥 🔥 🔥

Side-Notes

Action Item

  • Redesign hero image per today's feedback.
New Redesigns for Hero Image

Version 1

image

Version 2

image

Version 3

image

Version 4

image

@abenipa3
Copy link
Member

abenipa3 commented Aug 31, 2021

Minutes 8/30/21

  • Voted on the new hero image. More details on the next post.
  • Discussed how to automatically get the navigation bar collect sections and subsections (and skip the manual process in adding the titles and hrefs to the front matter.)
    • Decided to reach out to 100automations Team.
  • Discussed how the Doc to Markdown works using this example.

Action Items

  • Add the indentation of the mockup (missed it previously).
  • Reach out to 100automations (Carlos and Dean) in regards to their table of contents/navigation bar, and share info on how to get the navigation to follow the readers when they scroll through the pages.
  • Create a mobile version of the mockup.
  • Add redesigns to this issue.

@abenipa3
Copy link
Member

abenipa3 commented Aug 31, 2021

Guide Page's New Hero Image

The winner is Version 1. Please click the arrows below to see the final redesigns for both Desktop and Mobile.

Mock-Up for Desktop

Desktop

Mock-Up for Mobile

Mobile

Mockups for both Desktop and Mobile available on Figma here.

@ExperimentsInHonesty
Copy link
Member Author

ExperimentsInHonesty commented Sep 1, 2021

@alyssabenipayo What font choices do we have on the website? I looked in the design system pages and didn't see a font specified.

We also did some testing (which you can find at the bottom of the figma page). Here is what we found. The reason for our testing is that the titles seem a bit large, and not as sophisticated as the current Google Guides.

image

@JessicaLucindaCheng
Copy link
Member

@alyssabenipayo At the top of this issue, I added an action item to release dependency once this issue is merged.

@abenipa3
Copy link
Member

abenipa3 commented Apr 8, 2022

@alyssabenipayo We don't have office hours nor meetings the 1st through 7th of every month because it is a planning week.

For your blocker, did you import it to _sass/main.scss?

@JessicaLucindaCheng Thanks for the reminder. Also, I imported it to _sass/main.scss and it worked. The only thing now is that the content is scattered. Fixing it now. Thank you!

Preview

image

@abenipa3
Copy link
Member

abenipa3 commented Apr 15, 2022

Update 4/14/22

Progress: Got the layouts fixed. Just need to adjust the footer.
image

Blockers:
Question: Is it best practice to have different class names so scss won't alter class names of the same name from other pages of the website? For instance, I have a class name called sticky-nav for the sticky navigation which is the same name for the navigation on the about page. However, when I set the width and height of the sticky nav on the guide pages, it also changes the width and height of the sticky nav on the about page.

Availability: 8 hours

ETA: 4/16/22

@SAUMILDHANKAR
Copy link
Member

@alyssabenipayo Thank you for sharing your update. I discussed your blocker with Jessica and adding her here for further discussion (@JessicaLucindaCheng). Since, all the scss classes are compiled in the main.scss file before being used on the website, so I think we need to explore further if having same class names is the best approach. Also, wanted to suggest that it would be a better idea if we can create a new issue for your sticky side nav problem since this issue has a lot of comments and might be difficult to follow up. Thank you.

@abenipa3
Copy link
Member

abenipa3 commented Apr 16, 2022

@SAUMILDHANKAR @JessicaLucindaCheng Thanks for letting me know! I'll create a new issue this week after I finish fixing the styling as mentioned in my previous update. Thanks again.

@JessicaLucindaCheng
Copy link
Member

@alyssabenipayo With the way the SCSS files are set up to be imported all into one main.scss file, it is best to have different names.
I'm not sure if the sticky nav for the about page is named/coded as a re-usable component; however, here is a wiki on Standardized Components and there is a section on Page-Specific Class, which may help with how classes should be named.

@abenipa3
Copy link
Member

@JessicaLucindaCheng Noted! Thank you so much for the help and for following up with me.

@github-actions github-actions bot removed the Status: Updated No blockers and update is ready for review label Apr 29, 2022
@github-actions
Copy link

@alyssabenipayo

Please add update using the below template (even if you have a pull request). Afterwards, remove the 'To Update !' label and add the 'Status: Updated' label.

  1. Progress: "What is the current status of your project? What have you completed and what is left to do?"
  2. Blockers: "Difficulties or errors encountered."
  3. Availability: "How much time will you have this week to work on this issue?"
  4. ETA: "When do you expect this issue to be completed?"
  5. Pictures: "Add any pictures of the visual changes made to the site so far."

If you need help, be sure to either: 1) place your issue in the developer meeting discussion column and ask for help at your next meeting, 2) put a "Status: Help Wanted" label on your issue and pull request, or 3) put up a request for assistance on the #hfla-site channel.

You are receiving this comment because your last comment was before Tuesday, April 26, 2022 at 12:21 AM PST.

@github-actions github-actions bot added the 2 weeks inactive An issue that has not been updated by an assignee for two weeks label Apr 29, 2022
@SAUMILDHANKAR SAUMILDHANKAR added To Update ! No update has been provided and removed 2 weeks inactive An issue that has not been updated by an assignee for two weeks labels Apr 30, 2022
@abenipa3
Copy link
Member

abenipa3 commented May 4, 2022

Hello! I'm sorry for the late update. Here's my progress-

Progress: Working on standardizing components.
Blockers: N/A
Availability: 6 hours
ETA: Should be done with standardizing by today (5/4/22) or Friday (5/6/22) at the latest.

@github-actions github-actions bot added Status: Updated No blockers and update is ready for review and removed To Update ! No update has been provided labels May 6, 2022
@abenipa3
Copy link
Member

abenipa3 commented May 13, 2022

Progress: Finished standardizing components. Finalizing adjusting styling for sticky nav.
Blockers: N/A
Availability: 6 hours
ETA: 5/13/22 5/17/22 (I was under the weather this past weekend. Updated ETA)

Next Steps:

  • Note what files were added to the HfLA repo.
  • Create a new issue on the next steps regarding sticky navigation.
Preview

screencapture-127-0-0-1-4000-guide-pages-how-to-set-reminders-in-slack-2022-05-13-00_06_23

@SAUMILDHANKAR
Copy link
Member

@alyssabenipayo Hope you are doing well. Just wanted to follow up on the next steps for this issue. Looks like we are almost there. Please let us know. Thank you.

@abenipa3
Copy link
Member

abenipa3 commented May 20, 2022

@alyssabenipayo Hope you are doing well. Just wanted to follow up on the next steps for this issue. Looks like we are almost there. Please let us know. Thank you.

Hi Saumil. Thanks for following up with me. Absolutely - quick update: I finished my issue. I was going to post as soon as I create a pull request and gather my notes. (Notes include file locations related to the Guide Pages and references that would help when I create a new issue on the next steps.) Will update again tonight! Thanks again!

Image Preview

Note: Please excuse the odd navbar placements. I used an extension to snapshot the entire webpage and the navbar followed the extension as it scanned the page.

image

Image Preview (Snippet Version)

image

@abenipa3
Copy link
Member

abenipa3 commented Jun 1, 2022

Progress: Pull request is under review.
Blockers: N/A
Availability: N/A
ETA: N/A

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Large P-Feature: Toolkit https://www.hackforla.org/toolkit/ role: design role: front end Tasks for front end developers size: 13+pt Must be broken down into smaller issues Status: Updated No blockers and update is ready for review
Projects
9 participants