-
-
Notifications
You must be signed in to change notification settings - Fork 777
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
toggle see more/see less on wins card #1732
toggle see more/see less on wins card #1732
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bugs
- There seems to some problems with the
See more
,See Less
button in regards to styling. Please look at the below image for reference.
- Also when I am in mobile view and click on
See More
-> which causes the button to toggle toSee Less
-> and then i transition to desktop view. The text stays atSee Less
and does not go back to default.
- There seems to be a bug in the
See Less
button where its not clicking at these dimension for some reason
Side Notes
[ @daniellex0 - Could you please give your thoughts on these? ]
- The position of the see more/ see less button seems haphazardly placed. Imho, this looks aesthetically unpleasant.
- The inconsistency of some cards having a linkedin icon only, some having a github icon only also seems very messy aesthetically speaking.
I will work on the styling some more. Thanks for reviewing @akibrhast |
@akibrhast The styling error is fixed, and the In regards to "See Less button not toggling back to See More on mobile to desktop transition", this is a logic we have to add in. We can file an issue regarding this feature. Currently the mobile has the option to |
Could you be more specific please?
This was part of the original design by a previous designer that was approved by Bonnie. But future iterations might be able to include a different layout. One of our designers did notice that these icons are sharp black ( # 000 ) when they are supposed to be dark gray like the text (# 333), so that would be a good issue for someone to figure out how to fix and I think might make the logos pop out less. @akibrhast could you please make a dev issue for this? |
My apologies for not being specific @daniellex0 @qiqicodes There seems to be still some styling error with the see less button on mobile. Please look at image 2 above, at the "Sean Flores" and "Josh Robins" cards Some food for thought: I am going to move this PR to the dev discussion board to have the chance to bring it during tomorrow's developer meeting to get everyone's feedback and opinions on this matter. |
Discussed on Tuesday developer meeting, @jbubar will reach out to @qiqicodes to discuss and resolve. Moving this to draft until a resolution is reached and changes implemented from their discussion. |
@jbubar to close this draft pull request when he makes a new pull request |
fix #1549
see more
/see less
on the bottom right of the wins card2
see more
has ellipsis, sticking with same Figma designtoggle.see.more.see.less.mov