Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#About Meetings #1724

Closed
4 tasks done
Sihemgourou opened this issue Jun 12, 2021 · 7 comments
Closed
4 tasks done

#About Meetings #1724

Sihemgourou opened this issue Jun 12, 2021 · 7 comments

Comments

@Sihemgourou
Copy link
Contributor

Sihemgourou commented Jun 12, 2021

Please write here the questions for the development meeting :

  • New team members do not know that doing PR reviews is part of their contribution to H4LA
  • How to get this information out there?
  • Proposal: Have one meeting a month dedicating to teaching members how to do PR reviews
  • Desired outcome: Teach members how to do PR reviews and get the information out there.

What are everyone's thoughts?

@akibrhast
Copy link
Member

Spend time on Developer meeting both on sunday and tuesday and do at least one pull request review with the crowd, and sell the wiki link that ava wrote https://github.com/hackforla/website/wiki/How-to-Review-Pull-Requests

@Aveline-art
Copy link
Member

Aveline-art commented Jun 18, 2021

Backend meeting June 17, 2021 Notes

  • Sorting through new labels. There are size labels and roles labels, but also a lot of misc. labels. When are they supposed to be used? How are we going to relay the intent behind these labels to our team?

Add-ons:

  • How do we feel about people working on a new issue when one issue is under a pull request review? Is this desirable? Should there be a maximum number of issues a contributor can take on at once? Also, it seems that part of the reason why people want to take on multiple issues is that there is a lot of energy. Should we have a process that speeds up merging so that this energy is not lost?
  • What are some good weekly reminders to give out? Let us make a list so that we can make it a part of our meeting opening!

@akibrhast
Copy link
Member

akibrhast commented Jun 18, 2021

I believe we should ask all the developers to connect their github account and their slack account together. That way the new PR notification feature created by @arghmatey that is running on the hfla-site-pr will be able automatically be able to notify said people on their PRs that has been stalled for a long time.

@sayalikotkar sayalikotkar added the Feature Missing This label means that the issue needs to be linked to a precise feature label. label Jun 20, 2021
@akibrhast
Copy link
Member

Things to discuss with @Sihemgourou :

@akibrhast akibrhast removed the Feature Missing This label means that the issue needs to be linked to a precise feature label. label Jun 23, 2021
@Aveline-art
Copy link
Member

Aveline-art commented Jul 2, 2021

Backend meeting July 1, 2021 Notes:

  • Consider using GitHub Explorer GitHub GraphQL endpoint to perform API requests for GitHub actions rather than depend on multiple disjointed RESTAPI calls,.

@akibrhast
Copy link
Member

Btw in the future please add screenshots of how the changes look on the website to your PR, because other designers won't be able to review the branch on their machine :)

The above comment was made by @daniellex0 in this review, #1819 (review) .

This a one of the primary barriers that needs to be resolved to motivate communication between designers and developers .

The backend team should involve it's members in researching possible solutions such that designers can review changes made in pull request from a visual perspective without needing to muddle in the git stuff and forking and what not..

@Aveline-art
Copy link
Member

Aveline-art commented Jul 4, 2021

Closing this in favor of a better way to organize ideas for meetings #1891 . Format is based on #1734 .

@abuna1985 I believe you are heading the meeting next Tuesday? If so, you can feel free to use this to organize (it is also helpful if you have an emergency and we need to pick up on the agenda)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

6 participants