Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjusted project images to correct size and resolution #1819

Merged
merged 1 commit into from
Jul 2, 2021
Merged

Adjusted project images to correct size and resolution #1819

merged 1 commit into from
Jul 2, 2021

Conversation

mgodoy2023
Copy link
Member

@mgodoy2023 mgodoy2023 commented Jun 23, 2021 •
edited
Loading

Fixes #1165

What changes did you make and why did you make them ?

  • Adjusted the image size and resolution for the following project cards on the homepage to 600 pixels x 400 pixels and a standard resolution of 72dpi as was requested in the issue:
  1. 100 Automations
  2. Home Unite Us
  3. VRMS

Placed updated images in here

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Edit_This_To_Add_Image_Description

Paste_Your_Image_Link_Here
100Automations - UpdatedProjectImage
HomeUniteUs - UpdatedProjectImage
VRMS - UpdatedProjectImage

@mgodoy2023 mgodoy2023 requested a review from daniellex0 June 23, 2021 20:28
daniellex0
daniellex0 approved these changes Jun 27, 2021
View reviewed changes
Copy link
Member

@daniellex0 daniellex0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, well done @mgodoy2020 ! Sorry about all of my comments on slack! Btw in the future please add screenshots of how the changes look on the website to your PR, because other designers won't be able to review the branch on their machine :)

@mgodoy2023 mgodoy2023 closed this Jun 28, 2021
@mgodoy2023 mgodoy2023 deleted the adjust-project-images branch June 28, 2021 16:41
@mgodoy2023 mgodoy2023 restored the adjust-project-images branch June 28, 2021 16:41
@mgodoy2023 mgodoy2023 reopened this Jun 30, 2021
@HackforLABot HackforLABot added role: front end Tasks for front end developers To Update ! No update has been provided and removed role: design labels Jun 30, 2021
@mgodoy2023
Copy link
Member Author

@daniellex0 Added screenshots of the changes. Are there any next steps I need to take to complete this PR or am I all set? Thank you!

@daniellex0
Copy link
Member

@mgodoy2020 All set, thanks 👍

@Aveline-art Aveline-art removed the To Update ! No update has been provided label Jul 1, 2021
@akibrhast akibrhast mentioned this pull request Jul 2, 2021
Closed
4 tasks
@akibrhast akibrhast merged commit 9e98d7b into hackforla:gh-pages Jul 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniellex0 daniellex0 daniellex0 approved these changes

Assignees
No one assigned
Labels
good first issue Good for newcomers P-Feature: Home page https://www.hackforla.org/ role: front end Tasks for front end developers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adjust file size of some homepage project card images
7 participants
@mgodoy2023 @daniellex0 @akibrhast @ExperimentsInHonesty @Aveline-art @HackforLABot @mgodoy2020