Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add engines block on master branch for force prod redeployment #1195

Merged
merged 6 commits into from
May 9, 2022

Conversation

nichhk
Copy link
Member

@nichhk nichhk commented May 9, 2022

Fixes #1194

  • Up to date with master branch
  • Branch name follows guidelines
  • All PR Status checks are successful
  • Peer reviewed and approved

Any questions? See the getting started guide

Adding the engines is a no-op; it's essentially adding documentation (see #1189). I already merged this into dev, so I'm cherry-picking this commit from dev into master. Any change in client/ should trigger a prod deployment.

But it turns out that the prod deployment on master is broken too, so we need to update those with the fixes we brought into dev (see #1193).

Copy link
Member

@ExperimentsInHonesty ExperimentsInHonesty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not 100% sure, but willing to try this to see if it fixing current problem with v2 showing instead of v1

@ExperimentsInHonesty ExperimentsInHonesty merged commit 991ab85 into master May 9, 2022
@ExperimentsInHonesty ExperimentsInHonesty deleted the 1194-v2-was-pushed-to-v1-prod-site4 branch May 9, 2022 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants