Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make other frontend Actions use Node v12 #1193

Merged
merged 5 commits into from
May 8, 2022
Merged

Make other frontend Actions use Node v12 #1193

merged 5 commits into from
May 8, 2022

Conversation

nichhk
Copy link
Member

@nichhk nichhk commented May 8, 2022 •
edited
Loading

Fixes #1191

  • Up to date with dev branch
  • Branch name follows guidelines
  • All PR Status checks are successful
  • Peer reviewed and approved

Any questions? See the getting started guide

@nichhk nichhk linked an issue May 8, 2022 that may be closed by this pull request
Fix other frontend Actions to use Node v12 #1191
Closed
@nichhk
Copy link
Member Author

nichhk commented May 8, 2022

The deployments passed for both prod and dev. For dev, we see that the behavior from #1148 is active on dev.311-data.org.

I initially added a workflow_dispatch for the prod deployment, but I realized we probably don't want people to manually trigger prod deployments :)

@nichhk nichhk self-assigned this May 8, 2022
@nichhk nichhk requested a review from joshuayhwu May 8, 2022 02:17
@nichhk
Copy link
Member Author

nichhk commented May 8, 2022

After this is merged, I can merge #1149, and it should be automatically deployed to dev.

@nichhk
Copy link
Member Author

nichhk commented May 8, 2022

Thanks Josh!

@nichhk nichhk merged commit ab87f92 into dev May 8, 2022
@nichhk nichhk deleted the 1191-fix-other-frontend-actions-to-use-node-v12 branch May 8, 2022 03:10
@nichhk nichhk mentioned this pull request May 9, 2022
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshuayhwu joshuayhwu joshuayhwu approved these changes

Assignees

@nichhk nichhk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix other frontend Actions to use Node v12
2 participants
@nichhk @joshuayhwu