Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add engines block to client/package.json so that Node version is explicitly stated #1189

Merged
merged 1 commit into from
May 6, 2022
Merged

Add engines block to client/package.json so that Node version is explicitly stated #1189

merged 1 commit into from
May 6, 2022

Conversation

nichhk
Copy link
Member

@nichhk nichhk commented May 6, 2022 •
edited
Loading

Fixes #1184

Note that this is simply documentation; it has no effect on the execution of the code, so there are no tests for it.

  • Up to date with dev branch
  • Branch name follows guidelines
  • All PR Status checks are successful
  • Peer reviewed and approved

Any questions? See the getting started guide

@nichhk nichhk requested a review from joshuayhwu May 6, 2022 02:22
@nichhk nichhk merged commit 4570c8d into dev May 6, 2022
@nichhk nichhk deleted the 1184-state-node-version-in-clientpackagejson branch May 6, 2022 02:30
@nichhk
Copy link
Member Author

nichhk commented May 6, 2022

Thanks for the review!

@nichhk nichhk mentioned this pull request May 9, 2022
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshuayhwu joshuayhwu joshuayhwu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

State Node version in client/package.json
2 participants
@nichhk @joshuayhwu