Upgrade govuk_template to version 0.19.1 #699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes the following changes: Remove generated gov.uk from relative print links alphagov/govuk_template#234 Fix extended footer on certain pages alphagov/govuk_template#177 Degrade gracefully when external JS can’t be loaded alphagov/govuk_template#248 Add docs for adding tabindex="-1" to fix the skiplink alphagov/govuk_template#250 Logo fixes alphagov/govuk_template#237 Remove external links styles alphagov/govuk_template#231 Don’t include both html5shiv and html5shiv-printshiv alphagov/govuk_template#254 Update govuk_frontend_toolkit to 5.0.0 alphagov/govuk_template#256 Fixed scala compilation failure for play template alphagov/govuk_template#261
Guntrisoft
force-pushed
the
upgrade_frontend_template
branch
from
a0c6cef to
3105ba0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The most visible changes from this upgrade are a slight modification to the GOVUK logo, removing of the external link icon (see accessibility link in footer), and a fix for relative URLs in printing pension wise pages.
Full list of changes:
Remove generated gov.uk from relative print links
alphagov/govuk_template#234
Fix extended footer on certain pages
alphagov/govuk_template#177
Degrade gracefully when external JS can’t be loaded
alphagov/govuk_template#248
Add docs for adding tabindex="-1" to fix the skiplink
alphagov/govuk_template#250
Logo fixes
alphagov/govuk_template#237
Remove external links styles
alphagov/govuk_template#231
Don’t include both html5shiv and html5shiv-printshiv
alphagov/govuk_template#254
Update govuk_frontend_toolkit to 5.0.0
alphagov/govuk_template#256
Fixed scala compilation failure for play template
alphagov/govuk_template#261