Remove generated gov.uk from relative print links #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Relative links currently have a https://www.gov.uk prepended to them in the print view. This is fine for gov.uk but not for other consumers of the template. I’ve updated static to include the prefix (alphagov/static#823); this commit removes it from the template.
Merged
gemmaleigh
added a commit
to alphagov/govuk_accessibility_sandbox
that referenced
this pull request
Sep 6, 2016
https://raw.githubusercontent.com/alphagov/govuk_template/master/CHANGEL OG.md # 0.18.1 - Remove gov.uk prefix from relative links when printing ([PR #234](alphagov/govuk_template#234)) - Fix a `.visually-hidden` bug on GOV.UK ([PR #177](alphagov/govuk_template#177)) # 0.18.0 - Publish the Jinja version of the template to NPM - Update HTML5 Shiv to the latest version - Remove an errant font loader script that was only being used for IE8 # 0.17.3 - Fix colour of H2 headings in footer # 0.17.2 - Fix a bug with the skip-to-content link and iOS Voiceover - Migrate @Viewport statement from govuk_frontend_toolkit # 0.17.1 - Reduce file size of template: removes HTML comments, `type` attributes on scripts, and uses HTML5 charset declaration. #208 - Switch external link media query to be mobile first #205 - Sass file cleanups - Replace old grid mixins with newer grid from frontend toolkit #134 - Remove duplicate grey variables #201 # 0.17.0 - Add CSS hook (`.js-hidden`) for hiding content when JS is enabled. Some apps have an equivalent hook, which can be removed once upgraded to this version # 0.16.4 - Fix publish the Jinja version of the template with a `package.json` for those consuming it with NPM # 0.16.3 - make the Django version of the template into a proper Python package - publish the Jinja version of the template with a `package.json` for those consuming it with NPM # 0.16.2 - more static assets added to `assets.precompile` to improve compatibility with apps running rails > 4.2.5 # 0.16.1 - Fix colour of logo when in `:active` state
Guntrisoft
added a commit
to guidance-guarantee-programme/pension_guidance
that referenced
this pull request
Dec 2, 2016
Makes the following changes: Remove generated gov.uk from relative print links alphagov/govuk_template#234 Fix extended footer on certain pages alphagov/govuk_template#177 Degrade gracefully when external JS can’t be loaded alphagov/govuk_template#248 Add docs for adding tabindex="-1" to fix the skiplink alphagov/govuk_template#250 Logo fixes alphagov/govuk_template#237 Remove external links styles alphagov/govuk_template#231 Don’t include both html5shiv and html5shiv-printshiv alphagov/govuk_template#254 Update govuk_frontend_toolkit to 5.0.0 alphagov/govuk_template#256 Fixed scala compilation failure for play template alphagov/govuk_template#261
Guntrisoft
added a commit
to guidance-guarantee-programme/pension_guidance
that referenced
this pull request
Dec 2, 2016
Makes the following changes: Remove generated gov.uk from relative print links alphagov/govuk_template#234 Fix extended footer on certain pages alphagov/govuk_template#177 Degrade gracefully when external JS can’t be loaded alphagov/govuk_template#248 Add docs for adding tabindex="-1" to fix the skiplink alphagov/govuk_template#250 Logo fixes alphagov/govuk_template#237 Remove external links styles alphagov/govuk_template#231 Don’t include both html5shiv and html5shiv-printshiv alphagov/govuk_template#254 Update govuk_frontend_toolkit to 5.0.0 alphagov/govuk_template#256 Fixed scala compilation failure for play template alphagov/govuk_template#261
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relative links currently have a
https://www.gov.ukprepended to them in the print view. This is fine for gov.uk but not for other consumers of the template. I’ve updated static to include the prefix; this commit removes it from the template. Will fix #224.