Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump logback-classic to 1.4.14 #1291

Closed
wants to merge 1 commit into from
Closed

Bump logback-classic to 1.4.14 #1291

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion project/Dependencies.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ object Dependencies {
val magentaLibDeps =
commonDeps ++ jacksonOverrides ++ akkaSerializationJacksonOverrides ++ Seq(
"com.squareup.okhttp3" % "okhttp" % "4.12.0",
"ch.qos.logback" % "logback-classic" % "1.4.8", // scala-steward:off
"ch.qos.logback" % "logback-classic" % "1.4.14", // scala-steward:off
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We previously experienced an issue updating this dependency in this repository - #1232. Have we successfully deployed to CODE?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't tried this in code. The error does seem unrelated though

java.lang.AssertionError: assertion failed: no symbol could be loaded from interface software.amazon.awssdk.services.s3.model.ListObjectsV2Response$Builder in class ListObjectsV2Response with name Builder and classloader sbt.internal.LayeredClassLoader@6286d22d

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea builds now, just a fragile test. Ill give it a go in CODE tomorrow just on case though.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are absolutely right this does break CODE. Unfortunately I don't think we can just dump logback and switch to devx-logs... As far as I understand Logback is pretty core to Play logging, and you would still need to use it regardless of logging to kinesis or logging to stdout 🤔

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#1292 switches to devx-logs, it might not resolve the reported vulnerabilities, but it's less code in the repository 😄.

"software.amazon.awssdk" % "core" % Versions.aws,
"software.amazon.awssdk" % "autoscaling" % Versions.aws,
"software.amazon.awssdk" % "s3" % Versions.aws,
Expand Down