chore(deps): Configure Scala Steward to ignore logback-classic
#1232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akash1810
force-pushed
the
aa/logback-classic
branch
from
c75042e
to
c8d03d8
Compare
jacobwinch
approved these changes
Aug 16, 2023
It appears that later versions of `logback-classic` are not compatible with the version of `play-logback` as on app start, we get: ```log [error] java.lang.NoSuchMethodError: 'void ch.qos.logback.classic.util.ContextInitializer.configureByResource(java.net.URL)' [error] at play.api.libs.logback.LogbackLoggerConfigurator.configure(LogbackLoggerConfigurator.scala:125) [error] at play.api.libs.logback.LogbackLoggerConfigurator.init(LogbackLoggerConfigurator.scala:31) [error] at play.core.server.DevServerStart$.$anonfun$mainDev$1(DevServerStart.scala:106) [error] at play.utils.Threads$.withContextClassLoader(Threads.scala:22) [error] at play.core.server.DevServerStart$.mainDev(DevServerStart.scala:76) [error] at play.core.server.DevServerStart$.mainDevHttpMode(DevServerStart.scala:50) [error] at play.core.server.DevServerStart.mainDevHttpMode(DevServerStart.scala) [error] at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) [error] at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) [error] at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) [error] at java.base/java.lang.reflect.Method.invoke(Method.java:566) [error] at play.runsupport.Reloader$.startDevMode(Reloader.scala:306) [error] at play.sbt.run.PlayRun$.devModeServer$lzycompute$1(PlayRun.scala:100) [error] at play.sbt.run.PlayRun$.devModeServer$1(PlayRun.scala:83) [error] at play.sbt.run.PlayRun$.$anonfun$playRunTask$3(PlayRun.scala:107) [error] at play.sbt.run.PlayRun$.$anonfun$playRunTask$3$adapted(PlayRun.scala:67) [error] at scala.Function1.$anonfun$compose$1(Function1.scala:49) [error] stack trace is suppressed; run last Compile / run for the full output [error] (Compile / run) java.lang.reflect.InvocationTargetException [error] Total time: 5 s, completed 15 Aug 2023, 08:03:13 ``` Configure Scala Steward to ignore it, for now, to avoid noisy PRs.
akash1810
force-pushed
the
aa/logback-classic
branch
from
c8d03d8
to
42772a0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
It appears that later versions of
logback-classicare not compatible with the version ofplay-logbackas on app start, we get:Configure Scala Steward to ignore it, for now, to avoid noisy PRs. We previously merged #1227, and then reverted in #1228. Scala Steward has now raised #1231, which is a duplicate of #1227.
How to test
N/A
How can we measure success?
Fewer PRs.
Have we considered potential risks?
Should a vulnerability be discovered in
logback-classicour options might be a little limited. To address this, we should remove logback dependencies from this repository entirely and instead adopt devx-logs. This should also resolve this comment.Closes #1231.