Skip to content

Commit

Permalink
chore(deps): Configure Scala Steward to ignore logback-classic
Browse files Browse the repository at this point in the history
It appears that later versions of `logback-classic` are not compatible with the version of `play-logback`
as on app start, we get:

```log
[error] java.lang.NoSuchMethodError: 'void ch.qos.logback.classic.util.ContextInitializer.configureByResource(java.net.URL)'
[error]         at play.api.libs.logback.LogbackLoggerConfigurator.configure(LogbackLoggerConfigurator.scala:125)
[error]         at play.api.libs.logback.LogbackLoggerConfigurator.init(LogbackLoggerConfigurator.scala:31)
[error]         at play.core.server.DevServerStart$.$anonfun$mainDev$1(DevServerStart.scala:106)
[error]         at play.utils.Threads$.withContextClassLoader(Threads.scala:22)
[error]         at play.core.server.DevServerStart$.mainDev(DevServerStart.scala:76)
[error]         at play.core.server.DevServerStart$.mainDevHttpMode(DevServerStart.scala:50)
[error]         at play.core.server.DevServerStart.mainDevHttpMode(DevServerStart.scala)
[error]         at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
[error]         at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
[error]         at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
[error]         at java.base/java.lang.reflect.Method.invoke(Method.java:566)
[error]         at play.runsupport.Reloader$.startDevMode(Reloader.scala:306)
[error]         at play.sbt.run.PlayRun$.devModeServer$lzycompute$1(PlayRun.scala:100)
[error]         at play.sbt.run.PlayRun$.devModeServer$1(PlayRun.scala:83)
[error]         at play.sbt.run.PlayRun$.$anonfun$playRunTask$3(PlayRun.scala:107)
[error]         at play.sbt.run.PlayRun$.$anonfun$playRunTask$3$adapted(PlayRun.scala:67)
[error]         at scala.Function1.$anonfun$compose$1(Function1.scala:49)
[error] stack trace is suppressed; run last Compile / run for the full output
[error] (Compile / run) java.lang.reflect.InvocationTargetException
[error] Total time: 5 s, completed 15 Aug 2023, 08:03:13
```

Configure Scala Steward to ignore it, for now, to avoid noisy PRs.
  • Loading branch information
akash1810 committed Aug 16, 2023
1 parent a7c48ed commit 42772a0
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion project/Dependencies.scala
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ object Dependencies {
val magentaLibDeps =
commonDeps ++ jacksonOverrides ++ akkaSerializationJacksonOverrides ++ Seq(
"com.squareup.okhttp3" % "okhttp" % "4.11.0",
"ch.qos.logback" % "logback-classic" % "1.4.8",
"ch.qos.logback" % "logback-classic" % "1.4.8", // scala-steward:off
"software.amazon.awssdk" % "core" % Versions.aws,
"software.amazon.awssdk" % "autoscaling" % Versions.aws,
"software.amazon.awssdk" % "s3" % Versions.aws,
Expand Down

0 comments on commit 42772a0

Please sign in to comment.