Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt log shipping via DevX logs #1292

Merged
merged 1 commit into from
Dec 15, 2023
Merged

Adopt log shipping via DevX logs #1292

merged 1 commit into from
Dec 15, 2023

Conversation

akash1810
Copy link
Member

@akash1810 akash1810 commented Dec 14, 2023

Requires https://github.com/guardian/deploy-tools-platform/pull/738.

What does this change?

Adopts https://github.com/guardian/devx-logs to ship application logs to Central ELK. This change allows us to remove an application dependency (https://github.com/guardian/kinesis-logback-appender), ultimately reducing the volume of code in the repository.

Important

We'll lose the buildNumber log marker with this change.

How to test

Rollout

  • Add required tags to the ASG (https://github.com/guardian/deploy-tools-platform/pull/738)
  • Cycle the instance; the new one will have the new tag (this'll result in 502/504 responses from the load balancer, as Riff-Raff operates as a singleton instance)
    ssm cmd -t riff-raff,PROD -p deployTools --cmd "curl --silent -X POST localhost:9000/requestInstanceRotation"
  • Merge

@akash1810 akash1810 changed the title feat: Switch to devx-logs Adopt log shipping via DevX logs Dec 14, 2023
@akash1810 akash1810 marked this pull request as ready for review December 14, 2023 21:02
@akash1810 akash1810 merged commit eedd719 into main Dec 15, 2023
1 check passed
@akash1810 akash1810 deleted the aa/devx-logs branch December 15, 2023 09:42
@akash1810
Copy link
Member Author

Confirming that PROD logs are appearing as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants