Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: convert setup.py based setup to pyproject.toml #283

Closed
wants to merge 1 commit into from
Closed

build: convert setup.py based setup to pyproject.toml #283

wants to merge 1 commit into from

Conversation

afuetterer
Copy link
Contributor

@afuetterer afuetterer commented Apr 10, 2024

This PR proposes the following changes:

  • remove setup.py based project setup
  • use modern python project setup with pyproject.toml
  • add optional dependency group test, can be installed with pip install .[test]
  • add a second CI job, that uses build-and-inspect-python-package to check the built package and see it contents at a glance, see: summary

Please let me know what you think.

Refs:

@afuetterer
Copy link
Contributor Author

Also the setup.py stated python_requires='>=3.6.0', but CI tested only from 3.7 on.

Python versions 3.6 and 3.7 reached end of life in 2021 and 2023. I would recommend to drop support and require Python >= 3.8. What do you think?

Ref: https://devguide.python.org/versions/

@afuetterer
Copy link
Contributor Author

Hi @gtonkinhill,
is this not desired? If you don't like the change, please let me know. I will close the PR then. Thanks.

@afuetterer afuetterer closed this Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant