BROKEN on Windows: Avoid using Jetty ALPN #4857
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dapengzhang0
approved these changes
Sep 18, 2018
|
There's something still broken on Windows; timeouts. It is strongly correlated with the errors seen in google/conscrypt#444 and google/conscrypt#502 |
ejona86
changed the title
We still want Netty to test that it continues working with Jetty ALPN, but otherwise we don't want to use it. Fixes grpc#2266
ejona86
force-pushed
the
avoid-jetty-alpn
branch
from
4e83846 to
91c34e5
Compare
|
Closing in favor of #10288 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We still want Netty to test that it continues working with Jetty ALPN,
but otherwise we don't want to use it.
Fixes #2266