Remove build usages of Jetty ALPN #10288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larry-safran
approved these changes
Jun 16, 2023
|
Ugh. Apparently we are still using an old JDK version on Windows Kokoro, and there's not a pre-built image with a new enough JDK version. |
|
b/287662313 |
ejona86
force-pushed
the
jetty-alpn-isnt-used
branch
2 times, most recently
from
8b52e45 to
bbe8675
Compare
It wasn't actually being used. Since Java 8u252 in early 2020 we've been using ALPN from the JDK. The Jetty ALPN Agent has been a noop. We do keep the Jetty ALPN support in the code and tests, but we don't have the infrastructure to actually run it.
ejona86
force-pushed
the
jetty-alpn-isnt-used
branch
from
bbe8675 to
e723b49
Compare
|
Force-pushed to rebase onto master. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It wasn't actually being used. Since Java 8u252 in early 2020 we've been using ALPN from the JDK. The Jetty ALPN Agent has been a noop.
We do keep the Jetty ALPN support in the code and tests, but we don't have the infrastructure to actually run it.
This is a re-do of #4857, but instead of swapping to Conscript we just use the JDK.