Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error opening zip file or JAR manifest missing when using qps_client / openloop_client #2266

Closed
normanmaurer opened this issue Sep 14, 2016 · 3 comments
Closed

Error opening zip file or JAR manifest missing when using qps_client / openloop_client #2266

normanmaurer opened this issue Sep 14, 2016 · 3 comments
Milestone
1.33

Comments

@normanmaurer
Copy link

normanmaurer commented Sep 14, 2016 •
edited
Loading

Steps to reproduce:

# wget http://repo1.maven.org/maven2/io/grpc/grpc-benchmarks/1.0.0/grpc-benchmarks-1.0.0.tar
# tar xf grpc-benchmarks-1.0.0.tar
# grpc-benchmarks-1.0.0/bin/qps_client

Error opening zip file or JAR manifest missing : /root/.gradle/caches/modules-2/files-2.1/org.mortbay.jetty.alpn/jetty-alpn-agent/2.0.3/89e34338e9214ca753b33f23ccf80a4b5b861bb7/jetty-alpn-agent-2.0.3.jar
Error occurred during initialization of VM
agent library failed to init: instrument

Basically I think you should just comment the DEFAULT_JVM_OPTS.
@ejona86
Copy link
Member

ejona86 commented Jul 27, 2017

I think this should now be as easy as porting #3037 to benchmarks/.

@ejona86 ejona86 added this to the Next milestone Jul 27, 2017
@ejona86 ejona86 self-assigned this Sep 13, 2018
ejona86 added a commit to ejona86/grpc-java that referenced this issue Sep 13, 2018
@ejona86
Avoid using Jetty ALPN
84c62a2 
We still want Netty to test that it continues working with Jetty ALPN,
but otherwise we don't want to use it.

Fixes grpc#2266
@ejona86 ejona86 mentioned this issue Sep 13, 2018
Closed
@ejona86
Copy link
Member

ejona86 commented Sep 13, 2018

We should use Conscrypt instead of Jetty ALPN in the benchmarks. We're already using netty_tcnative most of the time, but OkHttp would benefit from Conscrypt.

ejona86 added a commit to ejona86/grpc-java that referenced this issue Sep 30, 2019
@ejona86
Avoid using Jetty ALPN
d71e174 
We still want Netty to test that it continues working with Jetty ALPN,
but otherwise we don't want to use it.

Fixes grpc#2266
@ejona86 ejona86 removed their assignment Apr 10, 2020
@ejona86
Copy link
Member

ejona86 commented Dec 28, 2020

Fixed in #7368. Jetty ALPN isn't important these days since Java 8 has ALPN support.

@ejona86 ejona86 closed this as completed Dec 28, 2020
@ejona86 ejona86 modified the milestones: Next, 1.33 Dec 28, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.33
Development

Successfully merging a pull request may close this issue.

BROKEN on Windows: Avoid using Jetty ALPN ejona86/grpc-java
2 participants
@normanmaurer @ejona86