Fix .setup file #399
Closed
Fix .setup file #399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit a92f21a.
* The org.eclipse.test feature doesn't need to be installed into the IDE, so I removed that. * We only need to make sure that the feature can be found when the target platform is resolved, so I added the required p2 repos to the relevant repository lists. Signed-off-by: Felix Dorner <[email protected]>
Signed-off-by: Felix Dorner <[email protected]>
|
Only Groovy 2.1 is required to build. |
|
Eclipse Test Framework (aka org.eclipse.test.feature.group) is required in the target platform. |
That's not the issue here. It doesn't hurt to have them all and that's how it was set up before too..
We can of course add it explicitly, but IIUC it's not actually required. The jdt builder tests just need the eclipse performance tests plugin, and by adding the required update sites, the required plugins will be pulled in automatically, even if we don't mention them in our requirements. |
|
It doesn't hurt to add more than is needed. But why would we?
|
|
I don't know, maybe because someone wants to try and compile it with a
newer version? 2.1 is pretty old.. But again, this is not the issue here...
…On Tue, Dec 5, 2017 at 10:08 PM, Eric Milles ***@***.***> wrote:
It doesn't hurt to add more than is needed. But why would we?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#399 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAK9z0Bl3qcvBUnIwc9uLXPSk6548lzqks5s9bC-gaJpZM4Q2CE_>
.
--
Linux. The choice of a GNU generation.
|
|
So I removed the extras and you are putting them back. To me that's an issue. I don't like to have merge requests that revert desired changes.
|
|
Eric, feel free to do what you want. You see what's needed to fix it.
…On Dec 5, 2017 22:20, "Eric Milles" ***@***.***> wrote:
So I removed the extras and you are putting them back. To me that's an
issue. I don't like to have merge requests that revert desired changes.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#399 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAK9z_g6upaBJprO3iV1KJPfZIYNohWNks5s9bOVgaJpZM4Q2CE_>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes for #397 and #398