Oomph setup script does not complete

[konfri]

Hey,

I've tried to setup the groovy plugin workspace but I wasn't able to complete successfully due to some missing dependencies.

I've tried Neon as well as Oxygen as target but both didn't work.

Best regards,
Kon

[eric-milles]

Oh, yes, the tests require the "org.eclipse.test" feature now. Let me see if I can add that to the setup.

[konfri]

That would be great :)

[eric-milles]

Should be okay now

[konfri]

Hey,

thank you for you effort :) I retried the setup with the default entry given by the eclipse installer. I still did not finish completely without dependencies issues. As I'm not sure if the update of the setup file is immediately visible, I downloaded the setup file (including your changes) and tried to executed the installer with the local file.

I had to use a different name due to naming conflict with the default one just for the try. But unfortunately it did not complete successfully :(

[eric-milles]

What error are you seeing? I must admit I don't know too much about how this works. @felixdo added the setup script and I never tried it before this past week.

[felixdo]

Will check

…

On Dec 4, 2017 4:55 PM, "Eric Milles" ***@***.***> wrote: Reopened #397 <#397>. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#397 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAK9z_zDLa3NeQZ998zZ6_pg86mXxCX7ks5s9BXWgaJpZM4QypWv> .

[konfri]

It's basically the dependency issue that I mentioned in the first post. Thanks for investigating it @felixdo :)

[eric-milles]

I'm not sure I follow. I tested the setup file locally and it failed to resolve the test framework dependency. Then I altered the setup file and tested again. The test framework was properly resolved and setup proceeded normally (in my estimation). Are you saying the original issue remains unchanged for you?

[felixdo]

I will create pull request later.

…

On Mon, Dec 4, 2017 at 7:27 PM, Eric Milles ***@***.***> wrote: I'm not sure I follow. I tested the setup file locally and it failed to resolve the test framework dependency. Then I altered the setup file and tested again. The test framework was properly resolved and setup proceeded normally (in my estimation). Are you saying the original issue remains unchanged for you? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#397 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAK9z0kUcgAGj8NlFCQ_kCQkR-8KoOD5ks5s9DmkgaJpZM4QypWv> .

-- Linux. The choice of a GNU generation.

[konfri]

Yes, the same issue remains. Just tried on a different machine with the default entry from "Eclipse IDE for Eclipse Committers" -> "Groovy-Eclipse"

[felixdo]

Konfri, if you replace the groovy-eclipse.setup file in your git clone with the one I just committed here felixdo@44c599c and then try to 'Help->Perform Setup Tasks', does it complete?

If it does, then I'll create a pull request for Eric. You can then also safely uninstall the org.eclipse.test feature via Help->About Eclipse->Installation Details...

Explanation: For testing changes to .setup files, there is a mechanism that works like this: In your eclipse.ini there should be a line that says something like

-Doomph.redirection.Groovy-Eclipse=https://raw.githubusercontent.com/groovy/groovy-eclipse/master/groovy-eclipse.setup->file:/C:/develop/groovy-eclipse/git/groovy-eclipse/groovy-eclipse.setup
This means that the local .setup contents will be used when oomph tries to execute the groovy-eclipse setup, effectively overriding the contents of the file in our master branch on github. That's how to test modifications to the setup before publishing them.

[konfri]

@felixdo thanks for the PL. Works now :)

[felixdo]

As a sidenote.. when I run the installer, I still cannot see erics changes from over 10 weeks ago. For example, I still get greclipse 4.6 in my IDE even if the setup now asks for 4.7. Can you check under Help->About->Installation Details if it sais e46 or e47 under the groovy features (for example check the groovy jdt patch)

[konfri]

It is set to 4.7 but I must admit that I've selected Oxygen :)

[felixdo]

@eric-milles even if it apparently works now, there's still another issue with the setup. I will check and come back to you.

[konfri]

As my issues has been fix, I will close this :)